feat(ref-imp): #781 - lint

lib/core/versions/latest/CreateOperation.ts

@@ -126,7 +126,7 @@ export default class CreateOperation implements OperationModel {
     const suffixData = {
       deltaHash: operationObject.suffix_data.delta_hash,
       recoveryCommitment: operationObject.suffix_data.recovery_commitment
-    }
+    };
 
     // For compatibility with data pruning, we have to assume that `delta` may be unavailable,
     // thus an operation with invalid `delta` needs to be processed as an operation with unavailable `delta`,
@@ -195,7 +195,7 @@ export default class CreateOperation implements OperationModel {
 
   private static validateSuffixData (suffixData: any): void {
     if (typeof suffixData !== 'object') {
-      throw new SidetreeError(ErrorCode.CreateOperationSuffixDataIsNotObject)
+      throw new SidetreeError(ErrorCode.CreateOperationSuffixDataIsNotObject);
     }
 
     const properties = Object.keys(suffixData);

lib/core/versions/latest/Did.ts

@@ -95,7 +95,7 @@ export default class Did {
         createOperation = await Did.constructCreateOperationFromInitialState(initialState);
       } else {
         const initialStateEncodedJcs = Did.getInitialStateFromDidStringWithExtraColon(didString);
-        createOperation = Did.constructCreateOperationFromEncodedJCS(initialStateEncodedJcs);
+        createOperation = Did.constructCreateOperationFromEncodedJcs(initialStateEncodedJcs);
       }
 
       // NOTE: we cannot use the unique suffix directly from `createOperation.didUniqueSuffix` for comparison,
@@ -164,12 +164,12 @@ export default class Did {
     return initialStateValue;
   }
 
-  private static constructCreateOperationFromEncodedJCS (initialStateEncodedJcs: string): CreateOperation {
+  private static constructCreateOperationFromEncodedJcs (initialStateEncodedJcs: string): CreateOperation {
     // Initial state should be in the format base64url(JCS(initialState))
     const initialStateDecodedJcs = Encoder.decodeAsString(initialStateEncodedJcs);
     let initialStateObject;
     try {
-      initialStateObject = JSON.parse(initialStateDecodedJcs)
+      initialStateObject = JSON.parse(initialStateDecodedJcs);
     } catch {
       throw new SidetreeError(ErrorCode.DidInitialStateJcsIsNotJosn, 'long form initial state should be encoded jcs');
     }
@@ -189,7 +189,7 @@ export default class Did {
   /**
    * Make sure initial state is JCS
    */
-  private static validateInitialState(initialStateEncodedJcs: string, initialStateObject: any): void {
+  private static validateInitialState (initialStateEncodedJcs: string, initialStateObject: any): void {
     const expectedInitialState = Encoder.encode(JsonCanonicalizer.canonicalizeAsBuffer(initialStateObject));
     if (expectedInitialState !== initialStateEncodedJcs) {
       throw new SidetreeError(ErrorCode.DidInitialStateJcsIsNotJcs, 'make sure to jcs then encode the initial state');

lib/core/versions/latest/Operation.ts

@@ -42,6 +42,10 @@ export default class Operation {
     }
   }
 
+  /**
+   * validate delta and throw if invalid
+   * @param delta the delta to validate
+   */
   public static validateDelta (delta: any): void {
     if (typeof delta !== 'object') {
       throw new SidetreeError(ErrorCode.DeltaIsNotObject);

tests/core/CreateOperation.spec.ts

@@ -17,11 +17,11 @@ describe('CreateOperation', async () => {
           recovery_commitment: 'something'
         },
         delta: 'this is not a valid delta'
-      }
+      };
 
-      spyOn(CreateOperation as any, 'validateSuffixData').and.callFake(()=> { 
-        //do nothing 
-      })
+      spyOn(CreateOperation as any, 'validateSuffixData').and.callFake(() => {
+        // do nothing
+      });
 
       const result = CreateOperation.parseJcsObject(operationObject, Buffer.from('something'));
       expect(result.delta).toBeUndefined();
@@ -44,18 +44,18 @@ describe('CreateOperation', async () => {
       } catch (e) {
         expect(e).toEqual(new SidetreeError(ErrorCode.CreateOperationMissingOrUnknownProperty));
       }
-    })
+    });
 
     it('should throw sidetree error if type is not create', () => {
-      const testObject = {type: 'notCreate', two: 2, three: 3};
+      const testObject = { type: 'notCreate', two: 2, three: 3 };
       try {
         CreateOperation.parseJcsObject(testObject, Buffer.from(JSON.stringify(testObject)));
         fail('expect to throw sidetree error but did not');
       } catch (e) {
         expect(e).toEqual(new SidetreeError(ErrorCode.CreateOperationTypeIncorrect));
       }
-    })
-  })
+    });
+  });
   describe('computeDidUniqueSuffix()', async () => {
     it('should pass test vector.', async (done) => {
       const suffixDataString = 'AStringActingAsTheSuffixData';
@@ -113,7 +113,7 @@ describe('CreateOperation', async () => {
         expect(e).toEqual(new SidetreeError(ErrorCode.CreateOperationSuffixDataIsNotObject));
       }
     });
-  })
+  });
 
   describe('parseSuffixData()', async () => {
     // TODO SIP 2 #781 deprecates this. These tests can be siwtched over to validateSuffixData

tests/core/Did.spec.ts

@@ -11,23 +11,23 @@ describe('DID', async () => {
     it('should throw sidetree error if initial state is not an json', () => {
       const testInitialState = Encoder.encode('notJson');
       try {
-        Did['constructCreateOperationFromEncodedJCS'](testInitialState)
+        Did['constructCreateOperationFromEncodedJcs'](testInitialState);
         fail('expect to throw sidetree error but did not');
       } catch (e) {
         expect(e).toEqual(new SidetreeError(ErrorCode.DidInitialStateJcsIsNotJosn, 'long form initial state should be encoded jcs'));
       }
-    })
+    });
 
     it('should throw sidetree error if initial state is not jcs', () => {
-      const testInitialState = Encoder.encode(JSON.stringify({z: 1, a: 2, b: 1}));
+      const testInitialState = Encoder.encode(JSON.stringify({ z: 1, a: 2, b: 1 }));
       try {
-        Did['constructCreateOperationFromEncodedJCS'](testInitialState)
+        Did['constructCreateOperationFromEncodedJcs'](testInitialState);
         fail('expect to throw sidetree error but did not');
       } catch (e) {
         expect(e).toEqual(new SidetreeError(ErrorCode.DidInitialStateJcsIsNotJcs, 'make sure to jcs then encode the initial state'));
       }
-    })
-  })
+    });
+  });
 
   describe('create()', async () => {
     it('should create a short-form DID successfully.', async () => {

tests/core/Operation.spec.ts

@@ -22,12 +22,12 @@ describe('Operation', async () => {
     it('should throw sidetree error if input is not an object', () => {
       const input = 'this is not an object, this is a string';
       try {
-        Operation.validateDelta(input)
+        Operation.validateDelta(input);
       } catch (e) {
         expect(e).toEqual(new SidetreeError(ErrorCode.DeltaIsNotObject));
       }
-    })
-  })
+    });
+  });
 
   describe('parseDelta()', async () => {
     it('should throw if delta is not string', async () => {

tests/core/RequestHandler.spec.ts

@@ -143,7 +143,7 @@ describe('RequestHandler', () => {
     const response = await requestHandler.handleResolveRequest(longFormFixture);
     expect(response.status).toEqual(ResponseStatus.Succeeded);
     expect(response).toEqual(longFormResultingDocument as any);
-  })
+  });
 
   it('should process create operation from test vectors correctly', async () => {
     const createOperationBuffer = Buffer.from(JSON.stringify(createFixture));
@@ -321,7 +321,7 @@ describe('RequestHandler', () => {
     });
 
     it('[Bug #817] should return status as `deactivated` if DID is deactivated.', async () => {
-      // Intentionally not 
+      // Intentionally not
       const document = { unused: 'unused' };
       const mockedResolverReturnedDidState: DidState = {
         document,

tests/generators/OperationGenerator.ts

@@ -120,10 +120,10 @@ export default class OperationGenerator {
 
   /**
    * generate a long form did
-   * @param recoveryPublicKey 
-   * @param updatePublicKey 
-   * @param otherPublicKeys 
-   * @param serviceEndpoints 
+   * @param recoveryPublicKey
+   * @param updatePublicKey
+   * @param otherPublicKeys
+   * @param serviceEndpoints
    */
   public static async generateLongFormDid (
     recoveryPublicKey?: JwkEs256k,
@@ -172,8 +172,8 @@ export default class OperationGenerator {
     return {
       longFormDid,
       shortFormDid,
-      didUniqueSuffix,
-      
+      didUniqueSuffix
+
     };
   }