feat(ref-imp): #781 - make long form use jcs SIP2 #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OR13
reviewed
Sep 21, 2020
OR13
reviewed
Sep 21, 2020
OR13
previously approved these changes
Sep 21, 2020
isaacJChen
changed the title
| @@ -7,6 +7,7 @@ import Operation from './Operation'; | |||
| import OperationModel from './models/OperationModel'; | |||
| import OperationType from '../../enums/OperationType'; | |||
| import SidetreeError from '../../../common/SidetreeError'; | |||
| import JsonCanonicalizer from './util/JsonCanonicalizer'; | |||
There was a problem hiding this comment.
Nit: sort, or perhaps once and for all: https://eslint.org/docs/rules/sort-imports
| // thus an operation with invalid `delta` needs to be processed as an operation with unavailable `delta`, | ||
| // so here we let `delta` be `undefined`. | ||
| } | ||
| encodedDelta = Encoder.encode(JsonCanonicalizer.canonicalizeAsBuffer(operationObject.delta)); |
There was a problem hiding this comment.
Sanity: I suppose this is temporary right? As in this encoded string is not going to be useable for the other code path, the property is probably entirely unnecessary after SIP2.
There was a problem hiding this comment.
Yes, this is just here because createOperation still needs it for now.
Comment on lines
+114
to
+115
| const actual = Multihash.canonicalizeThenHashThenEncode(suffixData); | ||
| const expected = fs.readFileSync('tests/fixtures/uniqueSuffix/resultingSuffix.txt', 'utf8'); |
There was a problem hiding this comment.
Style nit: I can see the argument for external files. Though I'd suggest to encapsulate/hide info when possible, in this case I suggest to have both JSON inline instead of external file 'coz those data are not used anywhere.
thehenrytsai
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.