Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade ethers and did-provider-ethr for sepolia support #1306

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

strumswell
Copy link
Contributor

@strumswell strumswell commented Dec 13, 2023

What issue is this PR fixing

n/a

What is being changed

This PR bumps the version of ethr-did in the did-provider-ethr to add support for did:ethr:sepolia. I am also bumping ethers across the board for compatibility with the new ethr-did.

Quality

Check all that apply:

  • I want these changes to be integrated
  • I successfully ran pnpm i, pnpm build, pnpm test, pnpm test:browser locally.
  • I allow my PR to be updated by the reviewers (to speed up the review process).
  • I added unit tests.
  • I added integration tests.
  • I did not add automated tests because _________, and I am aware that a PR without tests will likely get rejected.

Details

n/a

Signed-off-by: Philipp Bolte <philipp.bolte@spherity.com>
Signed-off-by: Philipp Bolte <philipp.bolte@spherity.com>
@mirceanis
Copy link
Member

looks good, but we should update ethers to the same version in all packages that have it:
did-provider-ion
did-provider-key
did-provider-pkh
key-manager
kms-local
utils

Signed-off-by: Philipp Bolte <philipp.bolte@spherity.com>
@strumswell
Copy link
Contributor Author

Thanks for your feedback. Completely forgot about the other packages. Should be on the same version now across the board.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2157e70) 85.47% compared to head (94a78b5) 85.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #1306   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files         170      170           
  Lines       18950    18950           
  Branches     2115     2115           
=======================================
  Hits        16197    16197           
  Misses       2753     2753           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mirceanis mirceanis merged commit ac1b620 into decentralized-identity:next Dec 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants