Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Participatory texts - review workflow document upload #4770

Closed
2 tasks done
carolromero opened this issue Jan 14, 2019 · 6 comments
Closed
2 tasks done

Participatory texts - review workflow document upload #4770

carolromero opened this issue Jan 14, 2019 · 6 comments
Assignees
Labels
type: bug Issues that describe a bug

Comments

@carolromero
Copy link
Member

carolromero commented Jan 14, 2019

Describe the bug

What went wrong?

  1. When you upload a new document as a participatory text, you have a preview to check that everything is in order, but if it's not, if there is an error, you don't have the option to go back and reload it again.
    This means that in order to repeat the operation you have to create a new component of proposals, not being able to delete the first one. And you can end up having 'n' proposal components depending on the errors you make when uploading the file.
  2. Also: you can't edit the document title once is published, and this can be also a problem.

What did you expect to happen?

  1. I expected to have an option to reset and reload the file as long as it hasn't been published yet.
  2. I expected to be able to change the title of the PT without having to upload any file.

Additional context
https://meta.decidim.org/processes/bug-report/f/210/proposals/13772

@carolromero carolromero added the type: bug Issues that describe a bug label Jan 14, 2019
@tramuntanal
Copy link
Contributor

I guess that this are enhancements instead of bugs because this is the design for the Admin Panel that was proposed and accepted: #3949

By the way, I've already opened issue #4760 to allow to change the title and description of a Participatory Text without having to upload a new file.

@carolromero
Copy link
Member Author

I guess that this are enhancements instead of bugs because this is the design for the Admin Panel that was proposed and accepted: #3949

Hi @tramuntanal, indeed this is the approved design, but the problem is the behavior of the component in case there is an error with the file upload, and IMHO that should be taken into account when programming it.

By the way, I've already opened issue #4760 to allow to change the title and description of a Participatory Text without having to upload a new file.

Thanks, also I think this is not so different from the above, considering that there is also no design for editing the title and description. By the way, where is the description shown? In the frontend it is not visible.

@tramuntanal
Copy link
Contributor

Probably I could have raised a hand, my fault. But why it is so clear that it had to be taken into account when programming but not when designing it or when approving it?

Anyway we'll enhance this feature as requested because it is not usable this way. Can you provide your expected workflow and designs please? (maybe a "reset current text" checkbox in the form?

Regarding the description it is not rendered anywhere. I added it just for admin's self organization but I can remove it if it has no sense.

@tramuntanal tramuntanal self-assigned this Jan 23, 2019
@tramuntanal
Copy link
Contributor

tramuntanal commented Jan 29, 2019

Hi @decidim/product we'll add

  • a reset button at the top which will remove all unpublished participatory text content.
  • a save button at the bottom to persist changes before publishing

If the admin does not like the uploaded participaory text she will have to click RESET ALL (the new button), confirm (alert in the button), and then click the current IMPORT DOCUMENT again.

  • Optionally we can render all cards open by default if you confirm.

The admin view is this one:
imatge

@carolromero
Copy link
Member Author

Hi @tramuntanal sounds good!
All three options, including rendering open cards by default.

@tramuntanal
Copy link
Contributor

@decidim/product This Issue can be closed as all features are now implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issues that describe a bug
Projects
None yet
Development

No branches or pull requests

3 participants