Add conference registration types CRUD + Public view #4408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
27 tasks
isaacmg410
force-pushed
the
conference_registration_types
branch
from
d196d1e
to
05b8fa8
Compare
isaacmg410
changed the title
|
@decidim/lot-core ready to review :) |
oriolgual
suggested changes
Nov 6, 2018
...conferences/app/controllers/decidim/conferences/admin/conference_registrations_controller.rb
Outdated
Show resolved
Hide resolved
...ences/app/controllers/decidim/conferences/admin/registration_type_publications_controller.rb
Outdated
Show resolved
Hide resolved
...ences/app/controllers/decidim/conferences/admin/registration_type_publications_controller.rb
Outdated
Show resolved
Hide resolved
decidim-conferences/app/controllers/decidim/conferences/admin/registration_types_controller.rb
Outdated
Show resolved
Hide resolved
|
|
||
| def conference_meetings(registration_type) | ||
| meeting_components = registration_type.conference.components.where(manifest_name: "meetings") | ||
| Decidim::ConferenceMeeting.where(component: meeting_components).where(id: @form.attributes[:conference_meeting_ids]) |
There was a problem hiding this comment.
What's a Decidim::ConferenceMeeting? Shouldn't it be scoped to Decidim::Conferences?
There was a problem hiding this comment.
Maybe yes, but 'Decidim::ConferenceMeeting' is already in master. If 'ConferenceMeeting' should be scoped to 'Decidim::Conferences', in my opinion is out of this scope and it will be better to do in another PR.
What you think?
There was a problem hiding this comment.
Seems fair, let's do it in another PR!
added 12 commits
November 7, 2018 15:38
isaacmg410
force-pushed
the
conference_registration_types
branch
from
c495eaf
to
93cb8c7
Compare
|
@oriolgual requested changes applied 馃槃 |
oriolgual
approved these changes
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
This PR adds a selective registration by registration types configur days. --> 1st Iteration #4048
Distinguish early and late registration
馃搶 Related Issues
馃搵 Subtasks
CHANGELOGentry馃摲 Screenshots (optional)