Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply copy modifications conferences #4481

Merged
merged 5 commits into from
Nov 19, 2018
Merged

apply copy modifications conferences #4481

merged 5 commits into from
Nov 19, 2018

Conversation

isaacmg410
Copy link
Contributor

@isaacmg410 isaacmg410 commented Nov 15, 2018 •
edited
Loading

🎩 What? Why?

Change some conference copies

  • Replace "Join Conference" with "Registration"
  • Replace "Main promotors" with "Organizers"
  • Replace "Collaborators" with "Partners"
  • Replace "You are login" with "You are logged in"
  • Replace "Login to register at this conference" with "Login to register for the conference"
  • Replace "Register for free in decidim to register" with "Create an account in decidim to register for the conference"

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Change copies
  • Change/fix tests

📷 Screenshots (optional)

Description

@ghost ghost assigned isaacmg410 Nov 15, 2018
@ghost ghost added the status: WIP label Nov 15, 2018
@carolromero carolromero mentioned this pull request Nov 15, 2018
Closed
17 tasks
@ghost ghost added the status: WIP label Nov 16, 2018
@isaacmg410
Copy link
Contributor Author

@decidim/lot-core requested changes applied

@isaacmg410
Copy link
Contributor Author

@decidim/lot-core all checks are green, ready to be merged 😄

@mrcasals mrcasals merged commit 0fd6d91 into master Nov 19, 2018
@mrcasals mrcasals deleted the 4427_copy_modifications branch November 19, 2018 07:51
@ghost ghost removed the status: WIP label Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolromero carolromero carolromero left review comments

@mrcasals mrcasals mrcasals approved these changes

Assignees

@isaacmg410 isaacmg410

Labels
in-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isaacmg410 @mrcasals @carolromero