[Feature] Make Blog Posts endorsable #5668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmnzdz
force-pushed
the
feature/generalize_endorsements_and_apply_to_blog_posts
branch
7 times, most recently
from
6af62ae
to
80fac84
Compare
jmnzdz
force-pushed
the
feature/generalize_endorsements_and_apply_to_blog_posts
branch
from
80fac84
to
b64db6b
Compare
This versions seems to work for other projects: https://github.com/DEFRA/defra-ruby-validators/pull/49/files
jmnzdz
force-pushed
the
feature/generalize_endorsements_and_apply_to_blog_posts
branch
from
780b39c
to
ea19907
Compare
jmnzdz
force-pushed
the
feature/generalize_endorsements_and_apply_to_blog_posts
branch
from
ea19907
to
42e4e79
Compare
To check if cc-test-reporter supports simplecov 0.18. Following what has been said [here](codeclimate/test-reporter#418) it should fail.
tramuntanal
approved these changes
Jan 30, 2020
This reverts commit f9dff26.
@tramuntanal |
… into feature/generalize_endorsements_and_apply_to_blog_posts
jmnzdz
force-pushed
the
feature/generalize_endorsements_and_apply_to_blog_posts
branch
from
223fb38
to
f0c251e
Compare
…' of ssh://github.com/CodiTramuntana/decidim into feature/generalize_endorsements_and_apply_to_blog_posts
…' into feature/generalize_endorsements_and_apply_to_blog_posts
tramuntanal
merged commit 6a38064
into
decidim:feature/generalize_endorsements_and_apply_to_blog_posts
tramuntanal
deleted the
feature/generalize_endorsements_and_apply_to_blog_posts
branch
tramuntanal
added a commit
that referenced
this pull request
Mar 10, 2020
* Generalize endorsements permissions and extract from proposals. * [WIP] Extracting Endorsable concern * [WIP] EndorseResource and UnendorseRerouce commands. * [WIP] EndorsementsController tests. * Add timestamps to decidim_endorsements db migration. * [I18N] Update yamls. * [WIP] Extract endorsements from proposals module. But keep funcionality for proposals. * [DOC] Update changelog upgrade notes. * Apply edlint.js style. * normalize i18n files. * [TEST|I18N] Pending development translations. * [TEST] Update factory modifications to not break other tests. * [TEST] Extract endorse_proposal_spec logic into system_endorse_resource_examples. * [TEST] Rename shared system example. * [REFACTOR] Separate logic and view in endorsement_buttons_cell#render_endorsements_button_card_part. * Get rid of Decidim::Proposals::ProposalEndorsement. * Remove uses of proposal_endorsement. * Remove legady proposal endorsements related exclude from i8n normalization. * Revert "Remove legady proposal endorsements related exclude from i8n normalization." * Update tests. * [TEST] Update endorsement permissions tests. * Do not remove dummy_resources.coauthorships_count column, as factories depend on that. * Extract endorser identities partial into a generic identities cell. (#5564) * Extract endorser identities partial into a generic identities cell. Check if some already exists. * Remove Coauthorable to DummyResource * Complete documentation and small refactors to extract helpers to invoke the cells. * Update decidim-core/app/commands/decidim/endorse_resource.rb Co-Authored-By: Txus <me@txus.io> * Update decidim-core/app/commands/decidim/endorse_resource.rb Co-Authored-By: Txus <me@txus.io> * Update CHANGELOG.md Co-Authored-By: Txus <me@txus.io> * Rubocopify. * Rubocopify again. * Provide migration to automatically move ProposalEndorsements into new decidim-core Endorsement db structures. * Update decidim-proposals/db/migrate/20200120215928_move_proposal_endorsements_to_core_endorsements.rb Co-Authored-By: Ivan Vergés <ivan@platoniq.net> * Fix mispellings in MoveProposalEndorsementsToCoreEndorsements migration * Remove unneeded join clause in Proposal.newsletter_participant_ids(component) * Allow legacy data on rollback move ProposalEndorsements to Endorsements Allow to have rows in decidim_proposals_proposal_endorsements table when rolling back the MoveProposalEndorsementsToCoreEndorsements. Use #find_or_create_by just in case a migrated ProposalEndorsement is moved back to its original table. * [Feature] Make Blog Posts endorsable (#5668) * Fix errors * CHANGELOG entry added * Review when creation_date and comments should be rendered * Refactor author cell * Model tests added * Remove deprecated proposal_endorsement factory. Co-authored-by: Oliver Valls <tramuntanal@gmail.com> * Make blog posts followable (#5690) * Make blog posts followable * Notify followers when creating new comment * Add CHANGELOG entry * Generalize follow button partial * Edit CHANGELOG entry * Fix proposal tests * Update tests after merging latest changes from develop * Update proposal_input_sort_spec when sorting by endorsement_count * Update changelog Co-authored-by: jarvisct <57717422+jarvisct@users.noreply.github.com> Co-authored-by: Txus <me@txus.io> Co-authored-by: Ivan Vergés <ivan@platoniq.net>
microstudi
added a commit
to Platoniq/decidim
that referenced
this pull request
Mar 11, 2020
* Generalize endorsements permissions and extract from proposals. * [WIP] Extracting Endorsable concern * [WIP] EndorseResource and UnendorseRerouce commands. * [WIP] EndorsementsController tests. * Add timestamps to decidim_endorsements db migration. * [I18N] Update yamls. * [WIP] Extract endorsements from proposals module. But keep funcionality for proposals. * [DOC] Update changelog upgrade notes. * Apply edlint.js style. * normalize i18n files. * [TEST|I18N] Pending development translations. * [TEST] Update factory modifications to not break other tests. * [TEST] Extract endorse_proposal_spec logic into system_endorse_resource_examples. * [TEST] Rename shared system example. * [REFACTOR] Separate logic and view in endorsement_buttons_cell#render_endorsements_button_card_part. * Get rid of Decidim::Proposals::ProposalEndorsement. * Remove uses of proposal_endorsement. * Remove legady proposal endorsements related exclude from i8n normalization. * Revert "Remove legady proposal endorsements related exclude from i8n normalization." * Update tests. * [TEST] Update endorsement permissions tests. * Do not remove dummy_resources.coauthorships_count column, as factories depend on that. * Extract endorser identities partial into a generic identities cell. (decidim#5564) * Extract endorser identities partial into a generic identities cell. Check if some already exists. * Remove Coauthorable to DummyResource * Complete documentation and small refactors to extract helpers to invoke the cells. * Update decidim-core/app/commands/decidim/endorse_resource.rb Co-Authored-By: Txus <me@txus.io> * Update decidim-core/app/commands/decidim/endorse_resource.rb Co-Authored-By: Txus <me@txus.io> * Update CHANGELOG.md Co-Authored-By: Txus <me@txus.io> * Rubocopify. * Rubocopify again. * Provide migration to automatically move ProposalEndorsements into new decidim-core Endorsement db structures. * Update decidim-proposals/db/migrate/20200120215928_move_proposal_endorsements_to_core_endorsements.rb Co-Authored-By: Ivan Vergés <ivan@platoniq.net> * Fix mispellings in MoveProposalEndorsementsToCoreEndorsements migration * Remove unneeded join clause in Proposal.newsletter_participant_ids(component) * Allow legacy data on rollback move ProposalEndorsements to Endorsements Allow to have rows in decidim_proposals_proposal_endorsements table when rolling back the MoveProposalEndorsementsToCoreEndorsements. Use #find_or_create_by just in case a migrated ProposalEndorsement is moved back to its original table. * [Feature] Make Blog Posts endorsable (decidim#5668) * Fix errors * CHANGELOG entry added * Review when creation_date and comments should be rendered * Refactor author cell * Model tests added * Remove deprecated proposal_endorsement factory. Co-authored-by: Oliver Valls <tramuntanal@gmail.com> * Make blog posts followable (decidim#5690) * Make blog posts followable * Notify followers when creating new comment * Add CHANGELOG entry * Generalize follow button partial * Edit CHANGELOG entry * Fix proposal tests * Update tests after merging latest changes from develop * Update proposal_input_sort_spec when sorting by endorsement_count * Update changelog Co-authored-by: jarvisct <57717422+jarvisct@users.noreply.github.com> Co-authored-by: Txus <me@txus.io> Co-authored-by: Ivan Vergés <ivan@platoniq.net>
moustachu
added a commit
to OpenSourcePolitics/decidim
that referenced
this pull request
Apr 6, 2020
commit 11c979a37518a95f2a5f107ab298772c35051438
Author: Sébastien Moret <51788811+MoretS@users.noreply.github.com>
Date: Thu Apr 2 13:01:22 2020 +0200
Improve accessibility issues (#5684)
* add alt element to logo and add new translation key logo_alt
* Add label and title elements to topbar_search
* Add alt attribute to author avatar images
* Reformat elements heading on homepage
* Add aria-label element to off-canvas nav button
* Adding screen-reader title to images card links on homepage
* Add temporary submit button to search topbar
* Add button custo to topbar__search class
* Add alt attribute to links and images
* Modify muted color contrast
* Remove h6 attribute and class from legend element in filter section and replace with mini-title class
* Add img role attribute to Decidim icons
* Remove role img attrbute from follow button
* Modify search topbar submit button
* Replace div tag with a nav tag for user menu
* Unify main and mini footer background color
* Add title to notifications link and conversations link in user menu
* Modify secondary color to better contrast in Decidim
* Update search topbar to align with submit button
* Change primary color to better contrast
* Add title attribute to topbar search submit button
* Add label to select_area form
* Add accessibility to budgets filter forms
* Add accessibility to debates filter forms
* Add accessibility to meetings filter forms
* Add accessibility to accountability search form
* Add accessibility to proposals filter forms
* Add accessibility to sortitions filter forms
* Add translation to cloud-download button
* Add title to download link button
* Add alt element to assemblies members avatar
* Add accessibility to initiatives filter forms
* Add accessibility to consultations search form
* Add alt attribute to conferences logo partners
* Add alt attribute to conferences speaker images
* Add alt attribute to conferences media pictures
* Add underline text-decoration to links
* Add screen reader span to social media links on homepage
* Add title attribute and aria_label
* Add title attribute to search form
* Add title attribute and aria_label
* Replace <a> tag with <span> tag and add styling
* Add label tag to search form field
* Delete title from social media icons
* Delete title from share link button
* Replace last activity heading card title h5 to h4
* Fix position error with </article> close tag
* Modify all platform's heading
* Add title to terms and conditions link
* Modify cards tabindex on homepage
* Remove h6 tag from upcoming meetings card
* Redesign of the platform's heading html attributes
* Add title to see_all_assemblies button
* Add aria_label attribute to read_more button
* Add aria_label to number_per_page link
* Add aria_label to first_page link
* Add aria_label to last_page link
* Add aria_label to next_page link
* Add aria_label to previous_page link
* Add aria_label to comments_count
* Add aria_label to endorsements_count
* Add aria_label to page_number
* Add aria_label to comments link on proposal page
* Replace heading with span attribute for card title on last_activity page
* Replace all h4 card__title with span attribute
* Add explicit titles to home page link buttons
* Change calendar_url heading title
* Modify heading of proposal page
* Modify heading of title action results count
* Add href attribute to Cancel link on scope picker
* Add href attribute to order and resut_per_page links
* Replace <u> attribute with <span> for download_data links on processes
* Include <legend> existing tag in the <fieldset> tag
* Remove <fieldset> tag from remember_me checkbox on sign_in page
* Modify title of assemblies social network links
* Add title attribute to proposal comments/endorsements counter links
* Add title attribute to calendar URL field for meetings
* Add title attribute to results_per_page link
* Add translations for result_per_page and pagination links titles
* Add title attrbute to pagination links
* Add title attribute to navigation links for pagination
* Add title attribute to each <li> results_per page links in <ul> menu
* stylelint scss files
* Update jest tests
* erb files linting
* fix i18n missing key 'logo_alt'
* fix rubocop offenses
* fix erblint offenses
* update core spec system according to accessibility
* update specs system
* update specs system
* light refactor layout_helper and implements specs icon helper
* change simplecov version
* change simplecov version
* Update title assertion in spec core filter_form_builder_spec.rb
Co-Authored-By: Armand Fardeau <armandfardeau@users.noreply.github.com>
* Update translation link to root_url
Co-Authored-By: Armand Fardeau <armandfardeau@users.noreply.github.com>
* update font size according to original state
* add headings on cards
* refactor _organization_colors to avoid blank style tag
* remove deprecated xlink:href attribute
* refactor top_search_bar structure
* remove double main tag definition
* remove useless alt attribute on a tag
* change div by span in button tag
* use hidden_field_tag rather than content_tag
* remove aria_label attribute on links
* remove label attribute on search_field_tag in accountability
* remove invalid alt attribute
* remove invalid aria-label attribute on links
* remove invalid aria-label attribute on links
* move alt logo on image tag
* replace span by div
* Remove useless red color on h1
Was a mistake
* extract div tag from label tag
* refactor filter types dropdown
* replace chart article tag by div
* remove logo style tag within span and creates scss file layout
* remove useless comment in css
* remove deprecated frameborder attribute and fix empty p tag
* add missing alt attribute on image
* Allow postgres Docker image without password
* Add alt attribute on avatar
* Change button tag to link
* strip_tags in p tag
* Replace div by span inside button tag
* Allow postgres Docker image without password
* light refactor
* Add :focus styling on navbar links
* Add :focus and underline styling to topbar links
* remove invalid button in a tag
* add alt attribute on image_tag in image_big
* Fix stylelint issues
* correct typo on button type
* move legend tag to h3
* replace multiple main tag by div
* erb lint and rubocop
* Add :focus style to Register link on the home page
* Add :focus style to hollow button
* Add :focus style to card links
* Add :focus style to footer links
* change card__title from h4 to span in cards
* remove fieldset tag in registration form
* add translations for image helpers alt attribute
* replace img tag by image_tag helper
* refactor link_to helper using value rather than block
* add title attribute on links
* remove aria-label on link which contains a title attribute
* create new date format and edit datetime attribute
* add strip_tags option for decidim_sanitize helper
* use strip_tags option in decidim_sanitize helper
* erblint corrections
* Update decidim-blogs/app/views/decidim/blogs/posts/_sidebar_blog.html.erb
* Fix stylelint issue
* Change title attribute for the logo and change translation key name for it
* Update comments component test
* Add background color to focus style for navbar links
* Reformat focus and hover style for title bar
* Fix stylelint issue
* Add focus style for each link on the home page
* Add focus style to main and secondary buttons
* Add skip to main content button
* Fix style issue for register button on home page
* Fix missing translation issue
* Add hover and focus style to Decidim
* Modify focus style for card links
* Fix stylelint issue
* Add focus style to pagination elements
* Add focus style to m-bottom links
* Unify/reformat focus style on Decidim
commit cc2f283ae4fd5def0c11c813ae3bba6792469537
Author: leio10 <leiodd@gmail.com>
Date: Wed Apr 1 13:38:20 2020 +0200
Replace current meetings hook with highlighted elements hook (#5897)
* feat: replace current meetings hook with highlighted elements hook
This will include proposals, accountability and more elements apart from meetings
* doc: add changelog entry
* fix: missing translation added
Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
commit e4df0119962a686f1a2d386a752e4e33478d406e
Author: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
Date: Wed Apr 1 12:34:10 2020 +0300
Change the map marker color to the Decidim primary color (#5870)
* Change the map marker color to the Decidim primary color
* Add CHANGELOG entry
commit 2ca99e775874c7d36826b1e95d25e980d0051cd9
Author: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
Date: Wed Apr 1 10:30:03 2020 +0300
Fix map hovering over the secondary navigation element (#5871)
* Fix map hovering over the secondary navigation element
* Add CHANGELOG entry
commit caaddd6bc4ec501dbe12d6078912b19dca3b9926
Author: Ivan Vergés <ivan@platoniq.net>
Date: Wed Apr 1 09:09:15 2020 +0200
Fix questionnaire answer method to avoid query model relationships (#5819)
* change answer method name to avoid query model relationshiops
* add changelog
* fix survey tests
* additional questionnaire spec fix
* update changelog
* update changelog
commit 904bf5488cef394e741bf8169ad4be252287c67f
Author: leio10 <leiodd@gmail.com>
Date: Mon Mar 30 12:21:51 2020 +0200
fix: indeterminate checkboxes state is not consistent between browsers (#5901)
* fix: indeterminate checkboxes state is not consistent between browsers
It seems that Firefox can have indeterminate checked checkboxes while Chrome don't.
* doc: changelog entry added
Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
commit a728cf903452c0e39b03f773be97837cfcbc30d4
Author: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Date: Fri Mar 27 16:45:35 2020 +0100
Improve documentation on Views/HTML customizations (#5892)
commit bf4eafb4aa9f03a3b96f9b4515878d83ea5f1841
Author: Txus <me@txus.io>
Date: Fri Mar 27 16:34:06 2020 +0100
Security patches (#5553)
* Don't allow comments deeper than MAX_DEPTH
* Force SSL from decidim-core
* Do not expose GraphiQL in production, and do not expose ruby version in GraphQL
* Throttle failed authorization attempts
* Prevent timing attacks on login and leaking timing info
* Expire sessions after 24h of creation
* Do not expose process statistics if hidden
* Invalidate sessions on logout
* Do not allow uploading or attaching SVGs
* Obscure image processing errors
* Sanitize some user input
* Escape process titles and hashtags
* Escape urls and other fields in meetings
* Escape fields in sortitions
* Create configuration for session expiration and exposing graphiql
* Use rails logger instead of STDERR
Co-Authored-By: Oriol Gual <oriolgual@users.noreply.github.com>
* Use a translated message for carrierwave errors
* General fixes and refactoring
* Update changelog
* Do not link to graphiql if it is disabled
* Fix changelog
* Fix CHANGELOG once again
* Undo GraphiQL-related changes
* Fix changelog
* Fix links in changeelog
* Move SSL to a config option
* Don't show stats via the API
* Remove wrong changelog entries
* Fix method name
* Fix changelog
* Undo wrong changes
* Fix changelog
* Fix lints
Co-authored-by: Oriol Gual <oriolgual@users.noreply.github.com>
Co-authored-by: Marc Riera Casals <mrc2407@gmail.com>
commit 476571e5b6d5fc430a02335e04319610fecd2e20
Author: ivan-mr <ivan.mr@coditramuntana.com>
Date: Fri Mar 27 10:33:09 2020 +0100
Apply simplified design for activity cards for the home page, and Timeline and Activity Tab (#5848)
* Activity cards
* New Crowdin translations (#5761)
* New translations en.yml (French)
* New translations en.yml (Hungarian)
* New translations en.yml (Hungarian)
* Apply simplified design for activity cards for the home page, and Timeline and Activity tabs
* Change rspec tests on comment_activity_cell and proposal_activity_cell to check if card__content exists instead of card-data css class and add description into activity card
* Change rspec tests on comment_activity_cell and proposal_activity_cell to check if card__content exists instead of card-data css class and add description into activity card
* Fix text label on decidim-app_design
* Remove changelog lines
Co-authored-by: Javier Usobiaga <javier@swwweet.com>
Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com>
commit 909c281b3c7eb0f7a2c29892dc004dff5e926870
Author: Jesús Di Bari <61017625+jesusdb@users.noreply.github.com>
Date: Fri Mar 27 10:28:25 2020 +0100
Add nowrap white space to compact buttons (#5891)
Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
commit 893e385be9476bafb94f517bbc3f82d15293ab81
Author: Armand Fardeau <armandfardeau@users.noreply.github.com>
Date: Fri Mar 27 10:20:45 2020 +0100
Confirmation emails are sent in user's language (from browser) (#5789)
* Allow users to register in their own language
* Add changelog entry
* Remove local translations
Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com>
commit 2da1a7beda82b83131f60559bc948aaac929ba86
Author: Marc Riera <mrc2407@gmail.com>
Date: Thu Mar 26 09:01:56 2020 +0100
Add missing indexs on foreign keys (#5885)
* Add missing indexs on foreign keys
* Add changelog
commit 544d3600aac64edc29942d7c9ee83383b2b6f544
Author: Marc Riera <mrc2407@gmail.com>
Date: Thu Mar 26 08:37:41 2020 +0100
Force signin on API if the organization requires it (#5859)
* Force signin on API if the org requires it
* Add changelog
* Fix typo
* Fix class name
* Fix docs
* Add tests
* Lint code
commit d463ce76785fc7a71b1c6108f8aaa708283532de
Author: Pierre <pierre@mesu.re>
Date: Thu Mar 26 08:11:11 2020 +0100
Add a paragraph about the settings of the initiatives module (#5855)
commit 61f80a2cfcd20b4983d97ef3d690cd19ebff38dc
Author: Armand Fardeau <armandfardeau@users.noreply.github.com>
Date: Thu Mar 26 08:06:33 2020 +0100
Retry failed test to avoid flaky (#5894)
* Retry failed test 3 times
* Fix offenses
* Add changelog entry
commit 8c6c28d9124339450888d29df3aac787ca9f3f2e
Author: Oliver Valls <oliver.vh@coditramuntana.com>
Date: Wed Mar 25 13:04:33 2020 +0100
Apply latest ActionView patches (#5896)
* Apply latest ActionView patches
* Add changelog entry
* Update Gemfile.lock from modules that depend on main dependencies
commit 5c126498d943bcff65c89d9fb9233029810d2b45
Author: Marc Riera <mrc2407@gmail.com>
Date: Wed Mar 25 08:37:17 2020 +0100
Add missing defaults in initializer template (#5858)
* Add missing defaults in initializer template
* Fix style
commit fd3c145af2e569dda982ae048fc324c2be763a85
Author: Marc Riera <mrc2407@gmail.com>
Date: Mon Mar 23 17:22:57 2020 +0100
Fix duplicated actions workflows (#5883)
* Fix ducplicated actions workflows
On PRs from the repo, the current setup was causing duplicated
workflows. This should fix the issue.
* Run test suite for any base branch on PRs
commit 3174a8b2be2a4242198cd88a8adc78cfef86ea35
Author: Marc Riera <mrc2407@gmail.com>
Date: Fri Mar 20 10:33:25 2020 +0100
Fix workflows to work from forks (#5880)
commit cdba13b6113561a6794102de64bd9490fc0fe044
Author: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
Date: Thu Mar 19 18:54:14 2020 +0200
Fix missing tribute source map (#5869)
* Remove the source map comment from tribute
* Add CHANGELOG entry
commit f6f8da9bb76c4e7d0b21fd61feed8251c73e8d9f
Author: Marc Riera <mrc2407@gmail.com>
Date: Thu Mar 19 12:52:15 2020 +0100
Move test suite to GitHub Actions (#5843)
* Lint code through GitHub Actions
* Actually lint files
* Ignore ruby gems when linting JS files
* Properly cache NPM deps
* Set cache path for npm
* Run rubocop in parallel
* Don't lint ERB files in deps
* Don't make npm verbose
* Test npm caching works
* Remove npm cache
It'sa ctually not working, so it just adds useless seconds to thew
workflow
* Run tests for main folder
* Add tests for core module
* Add missing workflows
Created from a template
* Simplify generators workflow
* Automatically upload screenshots if tests fail
* Ensure path exists before uploading
* Create the screenshots path before uploading it
* Install Ruby deps from inside each module folder
This is how it works on CircleCI.
* Revert "Install Ruby deps from inside each module folder"
This reverts commit ad43682e643645e0fb6daca4e3d2bf3657ac2dfe.
* Add README
* Fix screenshots uploads
They should be uploaded always...
* Improve generators workflow
* Try to fix generators workflow
* Try to install ruby deps for generators
* Install gems globally
* Increase max wait time for slow specs
* Run JS tests from comments workflow
* Split proposals workflow in three
* Install codecov
* Set needed ENV vars for Codecov uploads
* Use GitHub Action to upload coverage reports
* Send coverage for main folder
* Use custom names for the parallel proposals workflows
* Delete decidim-dev workflow
This folder doesn't have any test
* Disable Codecov comments
* Remove unused file
* Don't report to CodeClimate from CircleCI
* Revert "Don't report to CodeClimate from CircleCI"
This reverts commit 5a6a087075a66ddc9efa96d246b794c21e61e9f7.
* Don't change the formatter for CircleCI
* Remove CircleCI config
* Remove CircleCI build status badge
* Add codecov status badge
* Add test suite badges
* Fix badges
* Fix workflows README
* Update .github/workflows/README.md
Co-Authored-By: Oliver Valls <oliver.vh@coditramuntana.com>
* Remove CircleCI env variable
Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
commit 54373f990e04f18989cbcde3cac724dab3cdb319
Author: Jesús Di Bari <61017625+jesusdb@users.noreply.github.com>
Date: Thu Mar 19 11:47:45 2020 +0100
Add scroll to bottom and apply it on conversations (#5718)
* Add scroll to bottom and apply it on conversations
* Add CHANGELOG entry
* Fix CodeClimate and CircleCI errors.
* Fix CodeClimate errors.
* Place the 'scrollToBottom' method on the erb file directly to pass the CircleCI test.
* When entering to a conversation, the window scrolls smoothly to bottom automatically. The code is refactored so there's no js code on show.html.erb but only on the js.s6 file.
* When entering to a conversation, the window scrolls smoothly to bottom automatically. The code is refactored so there's no js code on show.html.erb but only on the js.es6 file.
* Refactored the code: now the procedure won't look for all the elements with the class 'scroll-to-bottom' but it will look for only one instead.
* Adding strings to double quotes instead of single quotes.
* Add 'expect' to expect page to wait until the 'Send' button appears so the test doesn't fail.
* Use jquery and add :slow tag to tests.
* Add another "click_button" on test and change plain JavaScript to jQuery
The extra "click_button" forces the test app to click the existing button. This way the tests inside the context on line 116 from the file system/messaging/conversations_spec.rb will pass successfully.
* Add another 'click_button' to test
* Add slow tag and expect page to have content 'Send'
* Update CHANGELOG.md
Leave only my changes
* Remove lines on test that already exist on 'before' statement
Co-authored-by: Javier Jiménez <57717422+jarvisct@users.noreply.github.com>
Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
Co-authored-by: Ivan Molinero <ivan.mr@coditramuntana.com>
commit 41495b9bd3fae20145f5bd04d2ea3317aceacda1
Author: leio10 <leiodd@gmail.com>
Date: Wed Mar 18 16:35:46 2020 +0100
Allow to see a participant's email from the admin panel (#5849)
* feat: add "show email" icon to participants list
* feat: add the modal to show the email
* feat: make the show button work
* feat: add an entry to the admin log when a user shows an email
* feat: hide the Show button after showing the email address
* docs: changelog entry
* style: fix lint issues
* test: replace unnecesary code with a test
* test: system test for showing a participant email
* style: suggested changes applied
commit 928284518114d6435b60f0fea1de4468e5df3d8a
Author: leio10 <leiodd@gmail.com>
Date: Wed Mar 18 13:16:49 2020 +0100
Request confirmation to exit budgets component (#5765)
* Warn when trying to leave budgets component before completing the vote
* Add test for the alert before exiting the budgets component
* fix: base URL used to detect component URLs was including locale
* Component base URL based on current request instead of EngineRouter
It was working OK when using EngineRouter, but it was very complicated to get the tests passing. EngineRouter uses organization's host attribute, that can't store a port in tests, while the browser adds the host and port to the link's `href` attribute. On the other hand, Capybara uses random ports for the tested application, and #2187 adds a `base` tag to the pages to improve the debugging of failed tests HTML screenshots.
* docs: changelog entry added
commit 3e8640ecadbcce7c7b98acc7c043bbb51379d15d
Author: decidim-bot <decidim-bot@users.noreply.github.com>
Date: Wed Mar 18 12:00:06 2020 +0100
New Crowdin translations (#5836)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Hungarian)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (French)
* New translations en.yml (French)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (German)
* New translations en.yml (Galician)
* New translations en.yml (Galician)
* New translations en.yml (German)
* New translations en.yml (Basque)
* New translations en.yml (Basque)
* New translations en.yml (Catalan)
* New translations en.yml (Arabic)
* New translations en.yml (Arabic)
* New translations en.yml (Catalan)
* New translations en.yml (Dutch)
* New translations en.yml (Dutch)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Swedish)
* New translations en.yml (Swedish)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Russian with many plural form)
* New translations en.yml (Russian with many plural form)
* New translations en.yml (Ukrainian with many plural form)
* New translations en.yml (Ukrainian with many plural form)
* New translations en.yml (Turkish)
* New translations en.yml (Turkish)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Indonesian)
* New translations en.yml (Indonesian)
* New translations en.yml (Italian)
* New translations en.yml (Italian)
* New translations en.yml (Hungarian)
* New translations en.yml (Hungarian)
* New translations en.yml (Icelandic)
* New translations en.yml (Portuguese)
* New translations en.yml (Portuguese)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Norwegian)
* New translations en.yml (Norwegian)
* New translations en.yml (Polish)
* New translations en.yml (Polish)
* New translations en.yml (Czech)
* New translations en.yml (Catalan)
* New translations en.yml (Arabic)
* New translations en.yml (Basque)
* New translations en.yml (Norwegian)
* New translations en.yml (Polish)
* New translations en.yml (Indonesian)
* New translations en.yml (Italian)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Portuguese)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (French)
* New translations en.yml (Finnish)
* New translations en.yml (Galician)
* New translations en.yml (Dutch)
* New translations en.yml (Finnish)
* New translations en.yml (Hungarian)
* New translations en.yml (German)
* New translations en.yml (Russian with many plural form)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Ukrainian with many plural form)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Swedish)
* New translations en.yml (Turkish)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Hungarian)
* New translations en.yml (Hungarian)
* New translations en.yml (Hungarian)
* New translations en.yml (Hungarian)
* New translations en.yml (Hungarian)
* New translations en.yml (French)
* New translations en.yml (Finnish)
* New translations en.yml (German)
* New translations en.yml (Galician)
* New translations en.yml (Basque)
* New translations en.yml (Arabic)
* New translations en.yml (Catalan)
* New translations en.yml (Dutch)
* New translations en.yml (Czech)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Spanish)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Swedish)
* New translations en.yml (Turkish)
* New translations en.yml (Indonesian)
* New translations en.yml (Icelandic)
* New translations en.yml (Hungarian)
* New translations en.yml (Polish)
* New translations en.yml (Portuguese)
* New translations en.yml (Italian)
* New translations en.yml (Norwegian)
* New translations en.yml (Ukrainian with many plural form)
* New translations en.yml (Russian with many plural form)
* New translations en.yml (Catalan)
* New translations en.yml (Hungarian)
* New translations en.yml (Hungarian)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish (plain))
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish, Mexico)
commit 11bc5cabb3cddb47513b8eeb813deae8aba2b35f
Author: Marc Riera <mrc2407@gmail.com>
Date: Mon Mar 16 11:39:23 2020 +0100
Budgets: Sort projects by different criteria (#5808)
* Order budget projects
* Add tests
* Fix rubocop complaints
* Update changelog
* Simplify cases
commit 0ab094fcf5d1f6ee65348d9a4e292851187b7d88
Author: Quentin Champ <26109239+Quentinchampenois@users.noreply.github.com>
Date: Mon Mar 16 11:31:31 2020 +0100
Add a return button for users to get back to indexes (#5591)
* Add back to list buttons for components - Tests included
* fix i18n missing keys from proposals
* remove class button on buttons
* remove translated FR keys
* refactor specs and define shared examples
* The "sortition" component does not include the shared example because it is a special case.
* fix rubocop offense
commit 6af266d7e274210c56bbc2edc200a449d457656c
Author: Oliver Valls <oliver.vh@coditramuntana.com>
Date: Thu Mar 12 16:52:14 2020 +0100
Fix relative path in mentioned proposal email (#5852)
* Fix use absolute url in proposal mentioned notification email
But stay with the relative url for the internal notification.
* Add changelog entry
commit 9219950512920af02dfd168a14e5db692433bfce
Author: Ramon Costa <ramon.costa@gmail.com>
Date: Thu Mar 12 12:21:46 2020 +0100
Add revoke authorizations functionality (#5814)
* Verifier improvement - Add revoke authorizations functionality
* [FIX] Added CHANGELOG entry
* [FIX] Fixed couple Rubocop offenses
* [FIX] Changes on spec test for command revoke_by_condition
* [FIX] Fixed Rubocop offense
* [FIX] Fixed revoke by condition command date issue
* Add fixes related to PR code review
* Fixes PR review's requested changes
Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
commit b5475d80483e9151f02e938f126da571e0eaf59a
Author: Ivan Vergés <ivan@platoniq.net>
Date: Thu Mar 12 09:30:42 2020 +0100
Feature/receive messages from everyone (#5720)
* add direct_message options to user model
* add user preferences tests
* reorder locales
* add methods to accept/reject user conversations
* add conversation model tests
* add tests for new permission handling
* set visualization for profile page. add tests
* changelog
* fix collateral tests causalities
* document method for obtaining conversation path
commit cf06229a5b53d8fa2db23159df8a603b1bc249f6
Author: Ivan Vergés <ivan@platoniq.net>
Date: Wed Mar 11 16:46:23 2020 +0100
Add api entities for blog endorsements (#5847)
* Update proposal_input_sort_spec when sorting by endorsement_count
* add missing api attributes to blog posts
* Update changelog
* Add blog search capabilities to graphql
* changelog
* fix some comments
commit 29648271a74c816aa235545c9c70405d47a2d755
Author: Ivan Vergés <ivan@platoniq.net>
Date: Wed Mar 11 11:19:51 2020 +0100
Be able to mention groups (#5763)
* refactor users endpoint
* Add groups to mention list in tribute container
* Add user group parser
* Add usergroup renderers
* wip
* create user group mentioned event
* complete specs fo new comment notification
* clean duplicated scss
* add members count to tribute container
* changelog
* fix locale order
* rubocop offense
* fix create_comment command spec
* avoid flashing window when querying api
* add debounce funciton
* extract helper methods for group memberships queries
* remove start with underscore limitation in nicknames
commit 444e9c63a08a679f59bcecbd7aa5973340a4fd4e
Author: imgbot[bot] <31301654+imgbot[bot]@users.noreply.github.com>
Date: Tue Mar 10 22:35:27 2020 +0100
[ImgBot] Optimize images (#5638)
* [ImgBot] Optimize images
*Total -- 4,162.49kb -> 3,678.72kb (11.62%)
/decidim_app-design/app/views/public/docs/timeline-steps.svg -- 151.87kb -> 5.11kb (96.64%)
/decidim_app-design/app/views/public/docs/logo-decidim.svg -- 164.12kb -> 15.70kb (90.44%)
/decidim_app-design/app/views/public/docs/icons.svg -- 179.63kb -> 24.29kb (86.48%)
/logo.svg -- 7.29kb -> 4.99kb (31.61%)
/decidim-core/app/assets/images/decidim/default-avatar.svg -- 1.02kb -> 0.75kb (26.22%)
/decidim-forms/app/assets/images/decidim/surveys/icon.svg -- 0.96kb -> 0.78kb (18.92%)
/decidim-consultations/app/assets/images/decidim/consultations/icon2.svg -- 8.50kb -> 7.11kb (16.36%)
/decidim_app-design/app/assets/images/barcelona/pattern.svg -- 1.16kb -> 0.99kb (14.2%)
/decidim_app-design/app/assets/images/badges/diffusion.svg -- 11.02kb -> 9.58kb (13%)
/decidim_app-design/app/assets/images/badges/meetings.svg -- 8.11kb -> 7.08kb (12.69%)
/decidim-meetings/app/assets/images/decidim/gamification/badges/attended_meetings.svg -- 8.11kb -> 7.08kb (12.69%)
/decidim_app-design/app/assets/images/badges/followers.svg -- 9.50kb -> 8.36kb (12.06%)
/decidim-core/app/assets/images/decidim/gamification/badges/followers.svg -- 9.50kb -> 8.36kb (12.06%)
/decidim_app-design/app/assets/images/badges/debates.svg -- 8.39kb -> 7.38kb (12.03%)
/decidim-dev/app/assets/images/decidim/gamification/badges/test.svg -- 11.59kb -> 10.21kb (11.93%)
/decidim_app-design/app/assets/images/badges/supports.svg -- 7.70kb -> 6.81kb (11.56%)
/decidim-proposals/app/assets/images/decidim/gamification/badges/proposal_votes.svg -- 7.70kb -> 6.81kb (11.56%)
/decidim_app-design/app/assets/images/badges/initiatives.svg -- 10.39kb -> 9.19kb (11.52%)
/decidim_app-design/app/assets/images/badges/tutorial.svg -- 8.55kb -> 7.58kb (11.36%)
/decidim-core/app/assets/images/decidim/decidim-logo.svg -- 15.01kb -> 13.44kb (10.46%)
/decidim_app-design/app/assets/images/badges/accepted.svg -- 13.07kb -> 11.72kb (10.36%)
/decidim-proposals/app/assets/images/decidim/gamification/badges/accepted_proposals.svg -- 13.07kb -> 11.72kb (10.36%)
/decidim_app-design/app/assets/images/badges/proposals.svg -- 12.58kb -> 11.29kb (10.27%)
/decidim-proposals/app/assets/images/decidim/gamification/badges/proposals.svg -- 12.58kb -> 11.29kb (10.27%)
/decidim_app-design/app/assets/images/badges/invitations.svg -- 12.19kb -> 11.10kb (8.97%)
/decidim-core/app/assets/images/decidim/gamification/badges/invitations.svg -- 12.19kb -> 11.10kb (8.97%)
/decidim-budgets/app/assets/images/decidim/budgets/icon.svg -- 0.60kb -> 0.55kb (8.41%)
/decidim-debates/app/assets/images/decidim/gamification/badges/commented_debates.svg -- 7.98kb -> 7.38kb (7.6%)
/decidim-initiatives/app/assets/images/decidim/gamification/badges/initiatives.svg -- 9.94kb -> 9.19kb (7.56%)
/decidim-dev/app/assets/images/decidim/dummy.svg -- 0.26kb -> 0.24kb (6.46%)
/decidim_app-design/app/assets/images/badge-ajuntament-header.svg -- 6.17kb -> 5.80kb (5.99%)
/decidim_app-design/app/assets/images/decidim-logo.svg -- 6.02kb -> 5.80kb (3.62%)
/decidim_app-design/app/assets/images/logo.svg -- 0.20kb -> 0.19kb (3.41%)
/decidim-pages/app/assets/images/decidim/pages/icon.svg -- 0.82kb -> 0.80kb (2.38%)
/decidim-core/app/assets/fonts/decidim/Source_Sans_Pro_600.svg -- 57.05kb -> 56.03kb (1.79%)
/decidim-core/app/assets/fonts/decidim/Source_Sans_Pro_900.svg -- 57.09kb -> 56.07kb (1.78%)
/decidim-core/app/assets/fonts/decidim/Source_Sans_Pro_400.svg -- 58.16kb -> 57.15kb (1.75%)
/decidim_app-design/app/assets/images/icons.svg -- 81.72kb -> 80.45kb (1.56%)
/decidim-core/app/assets/images/decidim/icons.svg -- 82.50kb -> 81.22kb (1.55%)
/decidim-meetings/app/assets/images/decidim/meetings/icon.svg -- 0.73kb -> 0.72kb (1.46%)
/decidim-proposals/app/assets/images/decidim/proposals/icon.svg -- 0.35kb -> 0.34kb (1.4%)
/decidim-blogs/app/assets/images/decidim/blogs/icon.svg -- 0.39kb -> 0.39kb (1.25%)
/decidim-conferences/app/assets/images/decidim/conferences/conference.svg -- 0.41kb -> 0.41kb (1.18%)
/decidim-consultations/app/assets/images/decidim/consultations/icon.svg -- 0.69kb -> 0.68kb (0.71%)
/decidim-initiatives/app/assets/images/decidim/initiatives/icon.svg -- 0.72kb -> 0.72kb (0.68%)
/decidim-sortitions/app/assets/images/decidim/sortitions/icon.svg -- 0.81kb -> 0.81kb (0.48%)
/decidim-assemblies/app/assets/images/decidim/assemblies/assembly.svg -- 1.25kb -> 1.24kb (0.39%)
/decidim_app-design/app/assets/images/barcelona/heading-icon.svg -- 0.65kb -> 0.65kb (0.15%)
/decidim_app-design/app/assets/images/barcelona/pattern-big.svg -- 1.44kb -> 1.44kb (0.07%)
/decidim_app-design/app/assets/images/demo-consultations-banner.jpg -- 16.35kb -> 16.35kb (0.02%)
/decidim-participatory_processes/db/seeds/city.jpeg -- 104.54kb -> 104.54kb (0%)
/decidim-assemblies/db/seeds/city.jpeg -- 104.54kb -> 104.54kb (0%)
/decidim-conferences/db/seeds/city.jpeg -- 104.54kb -> 104.54kb (0%)
/decidim-budgets/lib/decidim/budgets/seeds/city.jpeg -- 104.54kb -> 104.54kb (0%)
/decidim-meetings/lib/decidim/meetings/seeds/city.jpeg -- 104.54kb -> 104.54kb (0%)
/decidim-consultations/db/seeds/city.jpeg -- 104.54kb -> 104.54kb (0%)
/decidim-dev/lib/decidim/dev/assets/city.jpeg -- 104.54kb -> 104.54kb (0%)
/decidim-consultations/db/seeds/city2.jpeg -- 127.43kb -> 127.42kb (0%)
/decidim-participatory_processes/db/seeds/city2.jpeg -- 127.43kb -> 127.42kb (0%)
/decidim-assemblies/db/seeds/city2.jpeg -- 127.43kb -> 127.42kb (0%)
/decidim-conferences/db/seeds/city2.jpeg -- 127.43kb -> 127.42kb (0%)
/decidim-initiatives/db/seeds/city2.jpeg -- 127.43kb -> 127.42kb (0%)
/decidim-dev/lib/decidim/dev/assets/city2.jpeg -- 127.43kb -> 127.42kb (0%)
/decidim_app-design/app/assets/images/meeting2.jpg -- 162.35kb -> 162.35kb (0%)
/decidim_app-design/app/assets/images/meeting3.jpg -- 184.36kb -> 184.36kb (0%)
/decidim-dev/lib/decidim/dev/assets/city3.jpeg -- 209.38kb -> 209.38kb (0%)
/decidim_app-design/app/assets/images/demo-debate.jpg -- 253.30kb -> 253.30kb (0%)
/decidim_app-design/app/assets/images/process-demo.jpg -- 332.25kb -> 332.25kb (0%)
/decidim_app-design/app/assets/images/demo-consultations.jpg -- 426.39kb -> 426.39kb (0%)
Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
* Remove white spaces in component icon spec
Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
commit 0af5a9a9671ac0701859699c1e89d479ba5f0888
Author: Oliver Valls <oliver.vh@coditramuntana.com>
Date: Tue Mar 10 22:34:43 2020 +0100
Generalize endorsements and apply to blog posts (#5542)
* Generalize endorsements permissions and extract from proposals.
* [WIP] Extracting Endorsable concern
* [WIP] EndorseResource and UnendorseRerouce commands.
* [WIP] EndorsementsController tests.
* Add timestamps to decidim_endorsements db migration.
* [I18N] Update yamls.
* [WIP] Extract endorsements from proposals module. But keep funcionality for proposals.
* [DOC] Update changelog upgrade notes.
* Apply edlint.js style.
* normalize i18n files.
* [TEST|I18N] Pending development translations.
* [TEST] Update factory modifications to not break other tests.
* [TEST] Extract endorse_proposal_spec logic into system_endorse_resource_examples.
* [TEST] Rename shared system example.
* [REFACTOR] Separate logic and view in endorsement_buttons_cell#render_endorsements_button_card_part.
* Get rid of Decidim::Proposals::ProposalEndorsement.
* Remove uses of proposal_endorsement.
* Remove legady proposal endorsements related exclude from i8n normalization.
* Revert "Remove legady proposal endorsements related exclude from i8n normalization."
* Update tests.
* [TEST] Update endorsement permissions tests.
* Do not remove dummy_resources.coauthorships_count column, as factories depend on that.
* Extract endorser identities partial into a generic identities cell. (#5564)
* Extract endorser identities partial into a generic identities cell. Check if some already exists.
* Remove Coauthorable to DummyResource
* Complete documentation and small refactors to extract helpers to invoke the cells.
* Update decidim-core/app/commands/decidim/endorse_resource.rb
Co-Authored-By: Txus <me@txus.io>
* Update decidim-core/app/commands/decidim/endorse_resource.rb
Co-Authored-By: Txus <me@txus.io>
* Update CHANGELOG.md
Co-Authored-By: Txus <me@txus.io>
* Rubocopify.
* Rubocopify again.
* Provide migration to automatically move ProposalEndorsements into new decidim-core Endorsement db structures.
* Update decidim-proposals/db/migrate/20200120215928_move_proposal_endorsements_to_core_endorsements.rb
Co-Authored-By: Ivan Vergés <ivan@platoniq.net>
* Fix mispellings in MoveProposalEndorsementsToCoreEndorsements migration
* Remove unneeded join clause in Proposal.newsletter_participant_ids(component)
* Allow legacy data on rollback move ProposalEndorsements to Endorsements
Allow to have rows in decidim_proposals_proposal_endorsements table when rolling back the
MoveProposalEndorsementsToCoreEndorsements. Use #find_or_create_by just in case a migrated
ProposalEndorsement is moved back to its original table.
* [Feature] Make Blog Posts endorsable (#5668)
* Fix errors
* CHANGELOG entry added
* Review when creation_date and comments should be rendered
* Refactor author cell
* Model tests added
* Remove deprecated proposal_endorsement factory.
Co-authored-by: Oliver Valls <tramuntanal@gmail.com>
* Make blog posts followable (#5690)
* Make blog posts followable
* Notify followers when creating new comment
* Add CHANGELOG entry
* Generalize follow button partial
* Edit CHANGELOG entry
* Fix proposal tests
* Update tests after merging latest changes from develop
* Update proposal_input_sort_spec when sorting by endorsement_count
* Update changelog
Co-authored-by: jarvisct <57717422+jarvisct@users.noreply.github.com>
Co-authored-by: Txus <me@txus.io>
Co-authored-by: Ivan Vergés <ivan@platoniq.net>
commit de58f6266cbd6dc34647c7c7aa1ac563730b7252
Author: victorol1 <victor.ol@coditramuntana.com>
Date: Tue Mar 10 10:25:02 2020 +0100
Add links to conversations (#5755)
* Add links to conversations
* Updated changelog
* Run rubocop
* Message exportation is no longer sanitized
* Refactored code and removed all renderers but link renderer
* Run rubocop
* Refactor tests and remove body sanitization
Co-authored-by: Javier Jiménez <57717422+jarvisct@users.noreply.github.com>
Co-authored-by: jarvisct <javier.jd@coditramuntana.com>
Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
commit 9c7b36e06b9d792bafc3f6e6136c2e94fd82c020
Author: leio10 <leiodd@gmail.com>
Date: Mon Mar 9 17:04:28 2020 +0100
Use simple_format to add a <p> wrapper to proposals body (#5753)
* Use simple_format to add a <p> wrapper to proposals body
* Changelog entry added
* Apply fix to amendments preview too
Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
commit f9ffcf7007662db2f00753d0ab7e87a8262af28a
Author: Armand Fardeau <armandfardeau@users.noreply.github.com>
Date: Mon Mar 9 15:17:56 2020 +0100
Fix incorrect proposals sortition (#5620)
* Fix incorrect sortition for proposals
* Add changelog entry
Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com>
Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
commit bc4576cd85b847c97d20dfad3e206f014691ce38
Author: Carlo Beltrame <carlo@beltra.me>
Date: Mon Mar 9 13:20:44 2020 +0100
Listen on all interfaces in Docker (#5598)
When starting decidim using the Docker setup, the server listens on 127.0.0.1 by default. This leads to connection reset errors when trying to access the application from outside the container. To fix this, tell the rails server to listen on all network interfaces (0.0.0.0) instead of just the loopback interface (127.0.0.1) when running in Docker.
commit 0685710805ea2ef9022b54d90d53e415f43e44ab
Author: Marc Riera <mrc2407@gmail.com>
Date: Mon Mar 9 10:45:48 2020 +0100
Let components without step settings be added (#5568)
* Let components without step settings be added
* Add changelog
* Add tests
* New Crowdin translations (#5761)
* New translations en.yml (French)
* New translations en.yml (Hungarian)
* New translations en.yml (Hungarian)
Co-authored-by: Txus <me@txus.io>
Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com>
Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
commit e7b5e5683b7254fa600beb2b22945db1e0b4ac59
Author: leio10 <leiodd@gmail.com>
Date: Sat Mar 7 08:39:47 2020 +0100
Fix for the proposals that have theirs state not published (#5832)
* fix: existing proposals before #5810 have theirs state not published
This fix covers two scenarios:
* Proposals answered before #5810
* Proposals with state but not answered (created from other modules without any answer)
* docs: changelog
commit d906b3ae1a98c96dcf477381dc7c550e25e1d3d9
Author: Agusti B.R <agustibr@users.noreply.github.com>
Date: Fri Mar 6 13:56:19 2020 +0100
Update development_guide.md JavaScript linter section (#5670)
commit 3dd651e476196422aa5af4a2a219a32dc670159e
Author: Oliver Valls <oliver.vh@coditramuntana.com>
Date: Fri Mar 6 13:35:32 2020 +0100
Clean CHANGELOG.md for the next release
commit ed663e70774d8576c71f72500f1253a476327fe5
Author: Oliver Valls <oliver.vh@coditramuntana.com>
Date: Fri Mar 6 13:17:15 2020 +0100
Support node.js semver rules (#5828)
* Support node.js semver rules
* Add changelog entry
commit 37475019bb0eab83e563ca11e654dcdec1cc79da
Author: decidim-bot <decidim-bot@users.noreply.github.com>
Date: Fri Mar 6 12:28:59 2020 +0100
New Crowdin translations (#5824)
* New translations en.yml (Icelandic)
* New translations en.yml (Indonesian)
* New translations en.yml (Italian)
* New translations en.yml (Hungarian)
* New translations en.yml (Portuguese)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Norwegian)
* New translations en.yml (Polish)
* New translations en.yml (Catalan)
* New translations en.yml (Dutch)
* New translations en.yml (Czech)
* New translations en.yml (Arabic)
* New translations en.yml (Basque)
* New translations en.yml (French)
* New translations en.yml (German)
* New translations en.yml (Galician)
* New translations en.yml (Finnish)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Turkish)
* New translations en.yml (Ukrainian with many plural form)
* New translations en.yml (Russian with many plural form)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish)
* New translations en.yml (Swedish)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Catalan)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Czech)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Catalan)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish)
* New translations en.yml (Spanish, Mexico)
commit 524f1ec9d415cdc566f8faccfd22159e9809335a
Author: Marc Riera <mrc2407@gmail.com>
Date: Fri Mar 6 12:21:58 2020 +0100
Parallelize rubocop on CI (#5827)
commit 6a49ea695b89f0d5ea5aea7a95c180653936c1c8
Author: Oliver Valls <oliver.vh@coditramuntana.com>
Date: Thu Mar 5 18:39:03 2020 +0100
fix argument camel case definition to comply with graphql gem v1.10.4 (#5829)
* fix argument camel case definition to comply with graphql gem v1.10.4
* add changelog entry
commit ad74e5ee3803507340d1629c2ebdb5963174594e
Author: Oliver Valls <oliver.vh@coditramuntana.com>
Date: Thu Mar 5 10:08:25 2020 +0100
New translations en.yml (Hungarian) (#5821)
commit 7c434fe146426d350ab4166956b67e1a3157f48a
Author: Oliver Valls <oliver.vh@coditramuntana.com>
Date: Thu Mar 5 10:04:13 2020 +0100
Publish proposals anwers at once (#5810)
* Allow admins to avoid publishing proposals answers immediately
* Allow admins to publish pending answers at once
* Fix and complete tests
* Allow proposals to have a state but not answered
This is needed to have accepted proposals created from accountability module that were not answered.
* Publish state from proposals created from the accountability module
* Emendations state is always published
* Withdrawn state doesn't need to be published
* Spec fixed
* Changelog entry added
* I18n and linting fixes
* Tests fixes
* fix: proposals versions history changed when answers are not published
* fix(seeds): create proposals with answer not published
* refactor: removed code duplication
* fix: lint issues
* refactor: simplified command
* fix(tests): too many actions hide "check all" checkboxes
I've changed the tests to press the Actions button after clicking the "check all" checkbox
* fix(tests): basic user for answers publishing must not be an admin
* fix(versions): only ignore update versions
* feat: "published answer" column moved in proposals admin
* refactor: publish answers as a bulk action doesn't need a background job
* fix: improve ordering by answer published field
* Remove unnecessary check
Co-Authored-By: Oliver Valls <oliver.vh@coditramuntana.com>
* refactor: changes suggested in review applied
Co-authored-by: Oliver Valls <tramuntanal@gmail.com>
commit d9894f3f97f9f40c070d8dbc3834a5f640714304
Author: Oliver Valls <oliver.vh@coditramuntana.com>
Date: Wed Mar 4 22:04:41 2020 +0100
fix geocoder compatibility with older versions (#5822)
* fix geocoder compatibility with older versions. Correct new apiKey argument name
* changelog
commit 4f6155fa785c50ffa54683556177b250c1b59f56
Author: Ivan Vergés <ivan@platoniq.net>
Date: Wed Mar 4 15:05:23 2020 +0100
Fix javascript for HERE.com maps with apiKey (#5768)
* fix javascript for here maps with apiKey
* changelog
* add deprecation warning
commit 98520b65bb1137310ed44570f2d86dd7a311b8ed
Author: decidim-bot <decidim-bot@users.noreply.github.com>
Date: Wed Mar 4 12:25:03 2020 +0100
New Crowdin translations (#5806)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Catalan)
* New translations en.yml (Hungarian)
* New translations en.yml (Swedish)
* New translations en.yml (Hungarian)
* New translations en.yml (Galician)
* New translations en.yml (German)
* New translations en.yml (Norwegian)
* New translations en.yml (Polish)
* New translations en.yml (Indonesian)
* New translations en.yml (Italian)
* New translations en.yml (Catalan)
* New translations en.yml (Czech)
* New translations en.yml (Arabic)
* New translations en.yml (Basque)
* New translations en.yml (Finnish)
* New translations en.yml (French)
* New translations en.yml (Dutch)
* New translations en.yml (Turkish)
* New translations en.yml (Swedish)
* New translations en.yml (Ukrainian with many plural form)
* New translations en.yml (Russian with many plural form)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Portuguese)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Spanish)
* New translations en.yml (Arabic)
* New translations en.yml (Arabic)
* New translations en.yml (Arabic)
* New translations en.yml (Arabic)
* New translations en.yml (Arabic)
* New translations en.yml (Hungarian)
* New translations en.yml (Hungarian)
* New translations en.yml (Hungarian)
* New translations en.yml (Hungarian)
* New translations en.yml (Hungarian)
* New translations en.yml (Catalan)
* New translations en.yml (Czech)
* New translations en.yml (Dutch)
* New translations en.yml (Arabic)
* New translations en.yml (Basque)
* New translations en.yml (Italian)
* New translations en.yml (Norwegian)
* New translations en.yml (Icelandic)
* New translations en.yml (Indonesian)
* New translations en.yml (Portuguese, Brazilian)
* New translations en.yml (Spanish)
* New translations en.yml (Polish)
* New translations en.yml (Portuguese)
* New translations en.yml (Finnish)
* New translations en.yml (French)
* New translations en.yml (Galician)
* New translations en.yml (Hungarian)
* New translations en.yml (German)
* New translations en.yml (Finnish (plain))
* New translations en.yml (Ukrainian with many plural form)
* New translations en.yml (Russian with many plural form)
* New translations en.yml (Turkish)
* New translations en.yml (Spanish, Paraguay)
* New translations en.yml (Spanish, Mexico)
* New translations en.yml (Swedish)
commit 457684b3ebf70838a2ae038094195c0434bd450d
Author: Javier Usobiaga <javier@swwweet.com>
Date: Wed Mar 4 12:07:14 2020 +0100
Design for "EPIC: Improve the Comments component" (#5641)
* Permalink icon in comments
* Improved comments - design proposal
* Fixed title in permalink icon
* Removed quote button
* Updated single comment view
* Fix lint errors
* Comment linking fixes
* Lint templates
Co-authored-by: Marc Riera <mrc2407@gmail.com>
commit ed9659f1ad311b3dcd6fe2b33de00b36f2282236
Author: Oliver Valls <oliver.vh@coditramuntana.com>
Date: Wed Mar 4 12:00:34 2020 +0100
Upgrade geocoder to 1.6 with new api_key authentication. (#5644)
* Upgrade geocoder to 1.6 with new api_key authentication.
* Addn Changelog entry.
* Apply new Here maps `api_key` authentication token.
* Rubocopify.
* Apply suggestions from code review
Use the new static_map_url
Co-Authored-By: Ivan Vergés <ivan@platoniq.net>
* Remove duplicated entries from changelog.
* Be flexile on the `geocoder` version that applications can use
This way the final version can be forced form the application's Gemfile.
* Add warning in geocoder upgrade notes
Notify implementers that want to stay with older versions of the Here api to force the gem version in their application.
* Add summary of possilbe configurations for implementors in the changelog
* Consider the two types of Here credentials
Depending on the version of the Here api use api_key or app_id+app_code.
* Remove useless Safe Navigation Operator (&.)
Co-authored-by: Ivan Vergés <ivan@platoniq.net>
commit d32d482b5bae78ab221e37811c117c6fcde0236f
Author: Oliver Valls <oliver.vh@coditramuntana.com>
Date: Wed Mar 4 11:55:31 2020 +0100
Upgrade nokogiri and puma for security (#5820)
* Upgrade nokogiri and puma for security
Solve puma's GHSA-84j7-475p-hp8v vulnerability.
Solve nokogiri's CVE-2020-7595 vulnerability.
* Add changelog entry
* Update CHANGELOG.md
solve double point
Co-Authored-By: Marc Riera <mrc2407@gmail.com>
Co-authored-by: Marc Riera <mrc2407@gmail.com>
commit 4fca1d52d12947097a1b8731b5baac78ac68abdd
Author: Agusti B.R <agustibr@users.noreply.github.com>
Date: Tue Mar 3 13:56:55 2020 +0100
Admin can bulk update proposal's scope (#5759)
* Extra space removed
* Add missing class to proposal tags list
* Admin can bulk update proposal's scope
* Add previous scope in proposal details + refactor
* Use scopes picker to bulk update proposals scope
* Add changelog entry
* fix failing specs
* Move update_scope route to the collection block, fix typo in doc
* fix scope_picker title
* fix failing merge_proposal spec
Co-authored-by: leio10 <leiodd@gmail.com>
commit f5724dd41f3d5be6e36bb6493fa871c9dc6cbec9
Author: Oliver Valls <oliver.vh@coditramuntana.com>
Date: Mon Mar 2 15:32:21 2020 +0100
Do not allow invited users to sign up (#5803)
* Do not allow invited users to sign up
* Remove the deleting of the invited user, now validated by the form
* Add changelog entry.
* Update related tests
* Re-send invitation email if user was already invited
* Update controller test.
commit b9f1e6e26d6d2256b3bcb2200debbb970d91c655
Author: Oliver Valls <oliver.vh@coditramuntana.com>
Date: Mon Mar 2 07:01:39 2020 +0100
Fix admin_manages_proposals_spec (#5812)
commit f03fa83a0955e9106b8c139039c574edb6bcf818
Author: Javier Jiménez <57717422+jarviiis21@users.noreply.github.com>
Date: Fri Feb 28 18:18:28 2020 +0100
Remove created status from scope open (#5805)
Co-authored-by: Oliver Valls <tramuntanal@gmail.com>
commit 248ba67476b35516864cc0c3e7995c30c531cd5e
Author: Javier Jiménez <57717422+jarviiis21@users.noreply.github.com>
Date: Fri Feb 28 18:15:00 2020 +0100
Fix proposal card layout (#5783)
* Fix proposal card layout
* Add CHANGELOG entry
* Fix typo in css
Co-authored-by: Oliver Valls <tramuntanal@gmail.com>
commit b539263af6fd793e1199772e66a11cb4ad56d5c3
Author: Javier Jiménez <57717422+jarviiis21@users.noreply.github.com>
Date: Fri Feb 28 18:11:48 2020 +0100
[FIX] Add description pop up required (#5771)
* Add description pop up required
* Add CHANGELOG entry
Co-authored-by: Oliver Valls <tramuntanal@gmail.com>
commit 72342af6fec845d8159cf7ef135d9273e1f89f6d
Author: Marc Riera <mrc2407@gmail.com>
Date: Fri Feb 28 18:01:11 2020 +0100
Add Valuator role (#5687)
* Add new Valuator role for processes
This role still can't perform much actions.
* Refactor proposal admin permissions to make them clearer
* Add ValuationAssignment model
* Find user roles from a participatory space
* Bulk-assign proposals to valuators
* Love lifts us up where we belong
Where the eagles cry
On a mountain high
* Show valuators count in proposals list
* Valuators can only answer and leave notes on assigned proposals
* Add system specs for bulk assignment
* Ensure valuators can only list assigned proposals
* Get list of proposals assigned to a valuator
* Bulk unassign valuators from a proposal
* Normalize locales
* Add valuators to assemblies
* Add valuator role for conferences
* Add changelog
* Normalize locales
* Remove unused locales
* Unassign valuators from the proposal page
* Normalize locales
* Fix rubocop warnings
* Fix spec
* Ensure transaction works
* Improve code reliability
* Ensure command broadcasts invalid if there's an error
* Fix flow for valuators
* Rubocop lint
* Hide proposals export button for users that don't have permissions
* Let valuators export proposals
* Put files where they belong
* Let process user roles whitelist components
* Let assembly user roles whitelist components
* Let conference user roles whitelist components
* Make initiatives work with the latest changes
* Fix assemblies specs
* Remove redundant assignment
* Extract similar code into parent classes
* Simplify code
* Fix bugs
* Fix wrong class name
* Improve method naming
* Normalize locales file
* Fix valuator column sorting
* Properly filter by valuator ID
* Ensure valuators can only export their visible proposals
* Update decidim-proposals/lib/decidim/proposals/component.rb
* Fix rubocop complaints
* Add tests for the proposals exporter
* Fix rubocop issues
commit 0ce9621dd1cbda9e30b6ebf4f68c482a58c433b9
Author: Jesús Di Bari <61017625+jesusdb@users.noreply.github.com>
Date: Fri Feb 28 14:11:41 2020 +0100
The admin can only send the initiative to technical validation when it has the minimum members required (#5762)
* The admin cannot send the initiative to a technical validation until the committee has the minimum members required by the initiative type.
* Add tests to validate that an initiative can go to technical validation when it has the minimum committee members required, and cannot go when otherwise.
* Changelog
* Change 'update_attribute' to 'update' to pass Rubocop validations.
commit 01826040aee312afb17bc92ad76286be869bf7a7
Author: leio10 <leiodd@gmail.com>
Date: Thu Feb 27 17:38:36 2020 +0100
Fix use of browse history with filters (#5749)
* Fix bug on #5654
Parent checkbox updating was failing
* Add CheckBoxesTree component to Decidim exports
* Fix search updating when using the browser history
* Push initial filters state to URL to allow returning back to that page
* Additional tests
* Changelog entry added
* Move delayed function to a separate file
Triggered by "Too long file" linting message
* Move check_boxes_tree related code to the component
Triggered by "Too long file" linting message
* Avoid unnecesary lets
* Fix and complete JS tests
* Fix lint issues
* Fix rubocop issue
* Undo 71ef93ac and fix bug on #5654
The problem was caused because scopes and categories trees where different.
* Use history state to store initial filters, instead of using URL
Changing the initial URL breaks too many things
Co-authored-by: Oliver Valls <tramuntanal@gmail.com>
commit 28c7f30870b5b4715983ffca117365b354c91f0c
Author: Ramon Costa <ramon.costa@gmail.com>
Date: Thu Feb 27 17:36:57 2020 +0100
Fix visual CSS issues in admin proposal filters (#5801)
* [FIX] Fixed visual css issues in admin proposal filters
* [FIX] Fixed visual css issues in admin proposal filters
Co-authored-by: ramoncodit <37654424+ramoncodit@users.noreply.github.com>
commit 94efd32a4226b385dbaab5a475d3f9f0a72281f3
Author: Agusti B.R <agustibr@users.noreply.github.com>
Date: Thu Feb 27 15:57:18 2020 +0100
…
faithngetich
pushed a commit
to faithngetich/decidim
that referenced
this pull request
Apr 21, 2020
* Generalize endorsements permissions and extract from proposals. * [WIP] Extracting Endorsable concern * [WIP] EndorseResource and UnendorseRerouce commands. * [WIP] EndorsementsController tests. * Add timestamps to decidim_endorsements db migration. * [I18N] Update yamls. * [WIP] Extract endorsements from proposals module. But keep funcionality for proposals. * [DOC] Update changelog upgrade notes. * Apply edlint.js style. * normalize i18n files. * [TEST|I18N] Pending development translations. * [TEST] Update factory modifications to not break other tests. * [TEST] Extract endorse_proposal_spec logic into system_endorse_resource_examples. * [TEST] Rename shared system example. * [REFACTOR] Separate logic and view in endorsement_buttons_cell#render_endorsements_button_card_part. * Get rid of Decidim::Proposals::ProposalEndorsement. * Remove uses of proposal_endorsement. * Remove legady proposal endorsements related exclude from i8n normalization. * Revert "Remove legady proposal endorsements related exclude from i8n normalization." * Update tests. * [TEST] Update endorsement permissions tests. * Do not remove dummy_resources.coauthorships_count column, as factories depend on that. * Extract endorser identities partial into a generic identities cell. (decidim#5564) * Extract endorser identities partial into a generic identities cell. Check if some already exists. * Remove Coauthorable to DummyResource * Complete documentation and small refactors to extract helpers to invoke the cells. * Update decidim-core/app/commands/decidim/endorse_resource.rb Co-Authored-By: Txus <me@txus.io> * Update decidim-core/app/commands/decidim/endorse_resource.rb Co-Authored-By: Txus <me@txus.io> * Update CHANGELOG.md Co-Authored-By: Txus <me@txus.io> * Rubocopify. * Rubocopify again. * Provide migration to automatically move ProposalEndorsements into new decidim-core Endorsement db structures. * Update decidim-proposals/db/migrate/20200120215928_move_proposal_endorsements_to_core_endorsements.rb Co-Authored-By: Ivan Vergés <ivan@platoniq.net> * Fix mispellings in MoveProposalEndorsementsToCoreEndorsements migration * Remove unneeded join clause in Proposal.newsletter_participant_ids(component) * Allow legacy data on rollback move ProposalEndorsements to Endorsements Allow to have rows in decidim_proposals_proposal_endorsements table when rolling back the MoveProposalEndorsementsToCoreEndorsements. Use #find_or_create_by just in case a migrated ProposalEndorsement is moved back to its original table. * [Feature] Make Blog Posts endorsable (decidim#5668) * Fix errors * CHANGELOG entry added * Review when creation_date and comments should be rendered * Refactor author cell * Model tests added * Remove deprecated proposal_endorsement factory. Co-authored-by: Oliver Valls <tramuntanal@gmail.com> * Make blog posts followable (decidim#5690) * Make blog posts followable * Notify followers when creating new comment * Add CHANGELOG entry * Generalize follow button partial * Edit CHANGELOG entry * Fix proposal tests * Update tests after merging latest changes from develop * Update proposal_input_sort_spec when sorting by endorsement_count * Update changelog Co-authored-by: jarvisct <57717422+jarvisct@users.noreply.github.com> Co-authored-by: Txus <me@txus.io> Co-authored-by: Ivan Vergés <ivan@platoniq.net>
faithngetich
pushed a commit
to faithngetich/decidim
that referenced
this pull request
Apr 21, 2020
* Generalize endorsements permissions and extract from proposals. * [WIP] Extracting Endorsable concern * [WIP] EndorseResource and UnendorseRerouce commands. * [WIP] EndorsementsController tests. * Add timestamps to decidim_endorsements db migration. * [I18N] Update yamls. * [WIP] Extract endorsements from proposals module. But keep funcionality for proposals. * [DOC] Update changelog upgrade notes. * Apply edlint.js style. * normalize i18n files. * [TEST|I18N] Pending development translations. * [TEST] Update factory modifications to not break other tests. * [TEST] Extract endorse_proposal_spec logic into system_endorse_resource_examples. * [TEST] Rename shared system example. * [REFACTOR] Separate logic and view in endorsement_buttons_cell#render_endorsements_button_card_part. * Get rid of Decidim::Proposals::ProposalEndorsement. * Remove uses of proposal_endorsement. * Remove legady proposal endorsements related exclude from i8n normalization. * Revert "Remove legady proposal endorsements related exclude from i8n normalization." * Update tests. * [TEST] Update endorsement permissions tests. * Do not remove dummy_resources.coauthorships_count column, as factories depend on that. * Extract endorser identities partial into a generic identities cell. (decidim#5564) * Extract endorser identities partial into a generic identities cell. Check if some already exists. * Remove Coauthorable to DummyResource * Complete documentation and small refactors to extract helpers to invoke the cells. * Update decidim-core/app/commands/decidim/endorse_resource.rb Co-Authored-By: Txus <me@txus.io> * Update decidim-core/app/commands/decidim/endorse_resource.rb Co-Authored-By: Txus <me@txus.io> * Update CHANGELOG.md Co-Authored-By: Txus <me@txus.io> * Rubocopify. * Rubocopify again. * Provide migration to automatically move ProposalEndorsements into new decidim-core Endorsement db structures. * Update decidim-proposals/db/migrate/20200120215928_move_proposal_endorsements_to_core_endorsements.rb Co-Authored-By: Ivan Vergés <ivan@platoniq.net> * Fix mispellings in MoveProposalEndorsementsToCoreEndorsements migration * Remove unneeded join clause in Proposal.newsletter_participant_ids(component) * Allow legacy data on rollback move ProposalEndorsements to Endorsements Allow to have rows in decidim_proposals_proposal_endorsements table when rolling back the MoveProposalEndorsementsToCoreEndorsements. Use #find_or_create_by just in case a migrated ProposalEndorsement is moved back to its original table. * [Feature] Make Blog Posts endorsable (decidim#5668) * Fix errors * CHANGELOG entry added * Review when creation_date and comments should be rendered * Refactor author cell * Model tests added * Remove deprecated proposal_endorsement factory. Co-authored-by: Oliver Valls <tramuntanal@gmail.com> * Make blog posts followable (decidim#5690) * Make blog posts followable * Notify followers when creating new comment * Add CHANGELOG entry * Generalize follow button partial * Edit CHANGELOG entry * Fix proposal tests * Update tests after merging latest changes from develop * Update proposal_input_sort_spec when sorting by endorsement_count * Update changelog Co-authored-by: jarvisct <57717422+jarvisct@users.noreply.github.com> Co-authored-by: Txus <me@txus.io> Co-authored-by: Ivan Vergés <ivan@platoniq.net>
tramuntanal
added a commit
that referenced
this pull request
Aug 31, 2020
* Disable RSpec/RepeatedExampleGroupDescription (#5785) * Disable RSpec/RepeatedExampleGroupDescription rubocop-rspec cop Disabling this cop until there are resources to refactor the code. * Update .rubocop.yml Co-Authored-By: Ivan Vergés <ivan@platoniq.net> Co-authored-by: Ivan Vergés <ivan@platoniq.net> * Fix/proposal filters (#5786) * [FIX] shorten 100 chars description max lenght in last activity cards to 80 chars max limit * [FIX] shorten 100 chars description max lenght in last activity cards to 80 chars max limit * [FIX] Wrong push, undone my last commit changes - My fault, sorry. * New Crowdin translations (#5761) * New translations en.yml (French) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * [FIX] Fixed dynamic translations proposals filter * [FIX] Clean some unwanted changes to PR * [FIX] Clean some unwanted changes to PR * [FIX] Clean some unwanted changes to PR * [FIX] Clean some unwanted changes to PR Co-authored-by: ramoncodit <37654424+ramoncodit@users.noreply.github.com> Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> * Add a navbar link to answer a proposal in the admin (#5706) * Add a navbar link to answer a proposal in the admin * Add Changelog entry * Add docs to add_link and fix typo in cell spec * moved edit_link and extra_admin_link to a partial * Add missing fix applied to proposals but not to projects (#5743) * Add missing fix applied to proposals but not to projects See https://github.com/decidim/decidim/pull/5654/commits/bf3348af33351e372bb4dbbd4be1adfe5d50a7b7 * docs: Add changelog entry * New Crowdin translations (#5774) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Icelandic) * New translations en.yml (German) * New translations en.yml (Norwegian) * New translations en.yml (Polish) * New translations en.yml (Indonesian) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (Arabic) * New translations en.yml (Basque) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (Turkish) * New translations en.yml (Finnish (plain)) * New translations en.yml (Swedish) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Russian with many plural form) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Norwegian) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Hungarian) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (Catalan) * New translations en.yml (Arabic) * New translations en.yml (Basque) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Polish) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Portuguese) * New translations en.yml (Finnish (plain)) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Russian with many plural form) * New translations en.yml (Swedish) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Turkish) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Greek) * New translations en.yml (Greek) * New translations en.yml (German) * New translations en.yml (Greek) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (Greek) * New translations en.yml (Greek) * New translations en.yml (Norwegian) * New translations en.yml (Indonesian) * New translations en.yml (Italian) * New translations en.yml (Greek) * New translations en.yml (Greek) * New translations en.yml (Greek) * New translations en.yml (Greek) * New translations en.yml (Greek) * New translations en.yml (Greek) * New translations en.yml (Greek) * New translations en.yml (Greek) * New translations en.yml (Greek) * New translations en.yml (Greek) * New translations en.yml (Greek) * New translations en.yml (Greek) * New translations en.yml (Greek) * New translations en.yml (Greek) * New translations en.yml (Greek) * New translations en.yml (Greek) * New translations en.yml (Icelandic) * New translations en.yml (Hungarian) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * Normalize the `bundle.js` files Co-authored-by: Oliver Valls <tramuntanal@gmail.com> * Admin: fix "Answer Proposal" action tooltip (#5750) * fix admin proposal tooltip when answering is enabled * change admin icon when answering is not permitted * Fix failing specs * show correct tooltip to valuator role * rename method to icon_with_link_to_proposal * Fix visual CSS issues in admin proposal filters (#5801) * [FIX] Fixed visual css issues in admin proposal filters * [FIX] Fixed visual css issues in admin proposal filters Co-authored-by: ramoncodit <37654424+ramoncodit@users.noreply.github.com> * Fix use of browse history with filters (#5749) * Fix bug on #5654 Parent checkbox updating was failing * Add CheckBoxesTree component to Decidim exports * Fix search updating when using the browser history * Push initial filters state to URL to allow returning back to that page * Additional tests * Changelog entry added * Move delayed function to a separate file Triggered by "Too long file" linting message * Move check_boxes_tree related code to the component Triggered by "Too long file" linting message * Avoid unnecesary lets * Fix and complete JS tests * Fix lint issues * Fix rubocop issue * Undo 71ef93ac and fix bug on #5654 The problem was caused because scopes and categories trees where different. * Use history state to store initial filters, instead of using URL Changing the initial URL breaks too many things Co-authored-by: Oliver Valls <tramuntanal@gmail.com> * The admin can only send the initiative to technical validation when it has the minimum members required (#5762) * The admin cannot send the initiative to a technical validation until the committee has the minimum members required by the initiative type. * Add tests to validate that an initiative can go to technical validation when it has the minimum committee members required, and cannot go when otherwise. * Changelog * Change 'update_attribute' to 'update' to pass Rubocop validations. * Add Valuator role (#5687) * Add new Valuator role for processes This role still can't perform much actions. * Refactor proposal admin permissions to make them clearer * Add ValuationAssignment model * Find user roles from a participatory space * Bulk-assign proposals to valuators * Love lifts us up where we belong Where the eagles cry On a mountain high * Show valuators count in proposals list * Valuators can only answer and leave notes on assigned proposals * Add system specs for bulk assignment * Ensure valuators can only list assigned proposals * Get list of proposals assigned to a valuator * Bulk unassign valuators from a proposal * Normalize locales * Add valuators to assemblies * Add valuator role for conferences * Add changelog * Normalize locales * Remove unused locales * Unassign valuators from the proposal page * Normalize locales * Fix rubocop warnings * Fix spec * Ensure transaction works * Improve code reliability * Ensure command broadcasts invalid if there's an error * Fix flow for valuators * Rubocop lint * Hide proposals export button for users that don't have permissions * Let valuators export proposals * Put files where they belong * Let process user roles whitelist components * Let assembly user roles whitelist components * Let conference user roles whitelist components * Make initiatives work with the latest changes * Fix assemblies specs * Remove redundant assignment * Extract similar code into parent classes * Simplify code * Fix bugs * Fix wrong class name * Improve method naming * Normalize locales file * Fix valuator column sorting * Properly filter by valuator ID * Ensure valuators can only export their visible proposals * Update decidim-proposals/lib/decidim/proposals/component.rb * Fix rubocop complaints * Add tests for the proposals exporter * Fix rubocop issues * [FIX] Add description pop up required (#5771) * Add description pop up required * Add CHANGELOG entry Co-authored-by: Oliver Valls <tramuntanal@gmail.com> * Fix proposal card layout (#5783) * Fix proposal card layout * Add CHANGELOG entry * Fix typo in css Co-authored-by: Oliver Valls <tramuntanal@gmail.com> * Remove created status from scope open (#5805) Co-authored-by: Oliver Valls <tramuntanal@gmail.com> * Fix admin_manages_proposals_spec (#5812) * Do not allow invited users to sign up (#5803) * Do not allow invited users to sign up * Remove the deleting of the invited user, now validated by the form * Add changelog entry. * Update related tests * Re-send invitation email if user was already invited * Update controller test. * Admin can bulk update proposal's scope (#5759) * Extra space removed * Add missing class to proposal tags list * Admin can bulk update proposal's scope * Add previous scope in proposal details + refactor * Use scopes picker to bulk update proposals scope * Add changelog entry * fix failing specs * Move update_scope route to the collection block, fix typo in doc * fix scope_picker title * fix failing merge_proposal spec Co-authored-by: leio10 <leiodd@gmail.com> * Upgrade nokogiri and puma for security (#5820) * Upgrade nokogiri and puma for security Solve puma's GHSA-84j7-475p-hp8v vulnerability. Solve nokogiri's CVE-2020-7595 vulnerability. * Add changelog entry * Update CHANGELOG.md solve double point Co-Authored-By: Marc Riera <mrc2407@gmail.com> Co-authored-by: Marc Riera <mrc2407@gmail.com> * Upgrade geocoder to 1.6 with new api_key authentication. (#5644) * Upgrade geocoder to 1.6 with new api_key authentication. * Addn Changelog entry. * Apply new Here maps `api_key` authentication token. * Rubocopify. * Apply suggestions from code review Use the new static_map_url Co-Authored-By: Ivan Vergés <ivan@platoniq.net> * Remove duplicated entries from changelog. * Be flexile on the `geocoder` version that applications can use This way the final version can be forced form the application's Gemfile. * Add warning in geocoder upgrade notes Notify implementers that want to stay with older versions of the Here api to force the gem version in their application. * Add summary of possilbe configurations for implementors in the changelog * Consider the two types of Here credentials Depending on the version of the Here api use api_key or app_id+app_code. * Remove useless Safe Navigation Operator (&.) Co-authored-by: Ivan Vergés <ivan@platoniq.net> * Design for "EPIC: Improve the Comments component" (#5641) * Permalink icon in comments * Improved comments - design proposal * Fixed title in permalink icon * Removed quote button * Updated single comment view * Fix lint errors * Comment linking fixes * Lint templates Co-authored-by: Marc Riera <mrc2407@gmail.com> * New Crowdin translations (#5806) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Catalan) * New translations en.yml (Hungarian) * New translations en.yml (Swedish) * New translations en.yml (Hungarian) * New translations en.yml (Galician) * New translations en.yml (German) * New translations en.yml (Norwegian) * New translations en.yml (Polish) * New translations en.yml (Indonesian) * New translations en.yml (Italian) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (Arabic) * New translations en.yml (Basque) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Dutch) * New translations en.yml (Turkish) * New translations en.yml (Swedish) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Russian with many plural form) * New translations en.yml (Finnish (plain)) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Spanish) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (Dutch) * New translations en.yml (Arabic) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (Norwegian) * New translations en.yml (Icelandic) * New translations en.yml (Indonesian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Spanish) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Hungarian) * New translations en.yml (German) * New translations en.yml (Finnish (plain)) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Russian with many plural form) * New translations en.yml (Turkish) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Swedish) * Fix javascript for HERE.com maps with apiKey (#5768) * fix javascript for here maps with apiKey * changelog * add deprecation warning * Fix clearing the current_user after sign out * Add CHANGELOG entry * fix geocoder compatibility with older versions (#5822) * fix geocoder compatibility with older versions. Correct new apiKey argument name * changelog * Publish proposals anwers at once (#5810) * Allow admins to avoid publishing proposals answers immediately * Allow admins to publish pending answers at once * Fix and complete tests * Allow proposals to have a state but not answered This is needed to have accepted proposals created from accountability module that were not answered. * Publish state from proposals created from the accountability module * Emendations state is always published * Withdrawn state doesn't need to be published * Spec fixed * Changelog entry added * I18n and linting fixes * Tests fixes * fix: proposals versions history changed when answers are not published * fix(seeds): create proposals with answer not published * refactor: removed code duplication * fix: lint issues * refactor: simplified command * fix(tests): too many actions hide "check all" checkboxes I've changed the tests to press the Actions button after clicking the "check all" checkbox * fix(tests): basic user for answers publishing must not be an admin * fix(versions): only ignore update versions * feat: "published answer" column moved in proposals admin * refactor: publish answers as a bulk action doesn't need a background job * fix: improve ordering by answer published field * Remove unnecessary check Co-Authored-By: Oliver Valls <oliver.vh@coditramuntana.com> * refactor: changes suggested in review applied Co-authored-by: Oliver Valls <tramuntanal@gmail.com> * New translations en.yml (Hungarian) (#5821) * fix argument camel case definition to comply with graphql gem v1.10.4 (#5829) * fix argument camel case definition to comply with graphql gem v1.10.4 * add changelog entry * Parallelize rubocop on CI (#5827) * New Crowdin translations (#5824) * New translations en.yml (Icelandic) * New translations en.yml (Indonesian) * New translations en.yml (Italian) * New translations en.yml (Hungarian) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Norwegian) * New translations en.yml (Polish) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Czech) * New translations en.yml (Arabic) * New translations en.yml (Basque) * New translations en.yml (French) * New translations en.yml (German) * New translations en.yml (Galician) * New translations en.yml (Finnish) * New translations en.yml (Finnish (plain)) * New translations en.yml (Turkish) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Russian with many plural form) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Catalan) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish) * New translations en.yml (Spanish, Mexico) * Support node.js semver rules (#5828) * Support node.js semver rules * Add changelog entry * Clean CHANGELOG.md for the next release * Update development_guide.md JavaScript linter section (#5670) * Fix for the proposals that have theirs state not published (#5832) * fix: existing proposals before #5810 have theirs state not published This fix covers two scenarios: * Proposals answered before #5810 * Proposals with state but not answered (created from other modules without any answer) * docs: changelog * Let components without step settings be added (#5568) * Let components without step settings be added * Add changelog * Add tests * New Crowdin translations (#5761) * New translations en.yml (French) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) Co-authored-by: Txus <me@txus.io> Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com> * Listen on all interfaces in Docker (#5598) When starting decidim using the Docker setup, the server listens on 127.0.0.1 by default. This leads to connection reset errors when trying to access the application from outside the container. To fix this, tell the rails server to listen on all network interfaces (0.0.0.0) instead of just the loopback interface (127.0.0.1) when running in Docker. * Fix incorrect proposals sortition (#5620) * Fix incorrect sortition for proposals * Add changelog entry Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com> * Use simple_format to add a <p> wrapper to proposals body (#5753) * Use simple_format to add a <p> wrapper to proposals body * Changelog entry added * Apply fix to amendments preview too Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com> * Add links to conversations (#5755) * Add links to conversations * Updated changelog * Run rubocop * Message exportation is no longer sanitized * Refactored code and removed all renderers but link renderer * Run rubocop * Refactor tests and remove body sanitization Co-authored-by: Javier Jiménez <57717422+jarvisct@users.noreply.github.com> Co-authored-by: jarvisct <javier.jd@coditramuntana.com> Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com> * Generalize endorsements and apply to blog posts (#5542) * Generalize endorsements permissions and extract from proposals. * [WIP] Extracting Endorsable concern * [WIP] EndorseResource and UnendorseRerouce commands. * [WIP] EndorsementsController tests. * Add timestamps to decidim_endorsements db migration. * [I18N] Update yamls. * [WIP] Extract endorsements from proposals module. But keep funcionality for proposals. * [DOC] Update changelog upgrade notes. * Apply edlint.js style. * normalize i18n files. * [TEST|I18N] Pending development translations. * [TEST] Update factory modifications to not break other tests. * [TEST] Extract endorse_proposal_spec logic into system_endorse_resource_examples. * [TEST] Rename shared system example. * [REFACTOR] Separate logic and view in endorsement_buttons_cell#render_endorsements_button_card_part. * Get rid of Decidim::Proposals::ProposalEndorsement. * Remove uses of proposal_endorsement. * Remove legady proposal endorsements related exclude from i8n normalization. * Revert "Remove legady proposal endorsements related exclude from i8n normalization." * Update tests. * [TEST] Update endorsement permissions tests. * Do not remove dummy_resources.coauthorships_count column, as factories depend on that. * Extract endorser identities partial into a generic identities cell. (#5564) * Extract endorser identities partial into a generic identities cell. Check if some already exists. * Remove Coauthorable to DummyResource * Complete documentation and small refactors to extract helpers to invoke the cells. * Update decidim-core/app/commands/decidim/endorse_resource.rb Co-Authored-By: Txus <me@txus.io> * Update decidim-core/app/commands/decidim/endorse_resource.rb Co-Authored-By: Txus <me@txus.io> * Update CHANGELOG.md Co-Authored-By: Txus <me@txus.io> * Rubocopify. * Rubocopify again. * Provide migration to automatically move ProposalEndorsements into new decidim-core Endorsement db structures. * Update decidim-proposals/db/migrate/20200120215928_move_proposal_endorsements_to_core_endorsements.rb Co-Authored-By: Ivan Vergés <ivan@platoniq.net> * Fix mispellings in MoveProposalEndorsementsToCoreEndorsements migration * Remove unneeded join clause in Proposal.newsletter_participant_ids(component) * Allow legacy data on rollback move ProposalEndorsements to Endorsements Allow to have rows in decidim_proposals_proposal_endorsements table when rolling back the MoveProposalEndorsementsToCoreEndorsements. Use #find_or_create_by just in case a migrated ProposalEndorsement is moved back to its original table. * [Feature] Make Blog Posts endorsable (#5668) * Fix errors * CHANGELOG entry added * Review when creation_date and comments should be rendered * Refactor author cell * Model tests added * Remove deprecated proposal_endorsement factory. Co-authored-by: Oliver Valls <tramuntanal@gmail.com> * Make blog posts followable (#5690) * Make blog posts followable * Notify followers when creating new comment * Add CHANGELOG entry * Generalize follow button partial * Edit CHANGELOG entry * Fix proposal tests * Update tests after merging latest changes from develop * Update proposal_input_sort_spec when sorting by endorsement_count * Update changelog Co-authored-by: jarvisct <57717422+jarvisct@users.noreply.github.com> Co-authored-by: Txus <me@txus.io> Co-authored-by: Ivan Vergés <ivan@platoniq.net> * [ImgBot] Optimize images (#5638) * [ImgBot] Optimize images *Total -- 4,162.49kb -> 3,678.72kb (11.62%) /decidim_app-design/app/views/public/docs/timeline-steps.svg -- 151.87kb -> 5.11kb (96.64%) /decidim_app-design/app/views/public/docs/logo-decidim.svg -- 164.12kb -> 15.70kb (90.44%) /decidim_app-design/app/views/public/docs/icons.svg -- 179.63kb -> 24.29kb (86.48%) /logo.svg -- 7.29kb -> 4.99kb (31.61%) /decidim-core/app/assets/images/decidim/default-avatar.svg -- 1.02kb -> 0.75kb (26.22%) /decidim-forms/app/assets/images/decidim/surveys/icon.svg -- 0.96kb -> 0.78kb (18.92%) /decidim-consultations/app/assets/images/decidim/consultations/icon2.svg -- 8.50kb -> 7.11kb (16.36%) /decidim_app-design/app/assets/images/barcelona/pattern.svg -- 1.16kb -> 0.99kb (14.2%) /decidim_app-design/app/assets/images/badges/diffusion.svg -- 11.02kb -> 9.58kb (13%) /decidim_app-design/app/assets/images/badges/meetings.svg -- 8.11kb -> 7.08kb (12.69%) /decidim-meetings/app/assets/images/decidim/gamification/badges/attended_meetings.svg -- 8.11kb -> 7.08kb (12.69%) /decidim_app-design/app/assets/images/badges/followers.svg -- 9.50kb -> 8.36kb (12.06%) /decidim-core/app/assets/images/decidim/gamification/badges/followers.svg -- 9.50kb -> 8.36kb (12.06%) /decidim_app-design/app/assets/images/badges/debates.svg -- 8.39kb -> 7.38kb (12.03%) /decidim-dev/app/assets/images/decidim/gamification/badges/test.svg -- 11.59kb -> 10.21kb (11.93%) /decidim_app-design/app/assets/images/badges/supports.svg -- 7.70kb -> 6.81kb (11.56%) /decidim-proposals/app/assets/images/decidim/gamification/badges/proposal_votes.svg -- 7.70kb -> 6.81kb (11.56%) /decidim_app-design/app/assets/images/badges/initiatives.svg -- 10.39kb -> 9.19kb (11.52%) /decidim_app-design/app/assets/images/badges/tutorial.svg -- 8.55kb -> 7.58kb (11.36%) /decidim-core/app/assets/images/decidim/decidim-logo.svg -- 15.01kb -> 13.44kb (10.46%) /decidim_app-design/app/assets/images/badges/accepted.svg -- 13.07kb -> 11.72kb (10.36%) /decidim-proposals/app/assets/images/decidim/gamification/badges/accepted_proposals.svg -- 13.07kb -> 11.72kb (10.36%) /decidim_app-design/app/assets/images/badges/proposals.svg -- 12.58kb -> 11.29kb (10.27%) /decidim-proposals/app/assets/images/decidim/gamification/badges/proposals.svg -- 12.58kb -> 11.29kb (10.27%) /decidim_app-design/app/assets/images/badges/invitations.svg -- 12.19kb -> 11.10kb (8.97%) /decidim-core/app/assets/images/decidim/gamification/badges/invitations.svg -- 12.19kb -> 11.10kb (8.97%) /decidim-budgets/app/assets/images/decidim/budgets/icon.svg -- 0.60kb -> 0.55kb (8.41%) /decidim-debates/app/assets/images/decidim/gamification/badges/commented_debates.svg -- 7.98kb -> 7.38kb (7.6%) /decidim-initiatives/app/assets/images/decidim/gamification/badges/initiatives.svg -- 9.94kb -> 9.19kb (7.56%) /decidim-dev/app/assets/images/decidim/dummy.svg -- 0.26kb -> 0.24kb (6.46%) /decidim_app-design/app/assets/images/badge-ajuntament-header.svg -- 6.17kb -> 5.80kb (5.99%) /decidim_app-design/app/assets/images/decidim-logo.svg -- 6.02kb -> 5.80kb (3.62%) /decidim_app-design/app/assets/images/logo.svg -- 0.20kb -> 0.19kb (3.41%) /decidim-pages/app/assets/images/decidim/pages/icon.svg -- 0.82kb -> 0.80kb (2.38%) /decidim-core/app/assets/fonts/decidim/Source_Sans_Pro_600.svg -- 57.05kb -> 56.03kb (1.79%) /decidim-core/app/assets/fonts/decidim/Source_Sans_Pro_900.svg -- 57.09kb -> 56.07kb (1.78%) /decidim-core/app/assets/fonts/decidim/Source_Sans_Pro_400.svg -- 58.16kb -> 57.15kb (1.75%) /decidim_app-design/app/assets/images/icons.svg -- 81.72kb -> 80.45kb (1.56%) /decidim-core/app/assets/images/decidim/icons.svg -- 82.50kb -> 81.22kb (1.55%) /decidim-meetings/app/assets/images/decidim/meetings/icon.svg -- 0.73kb -> 0.72kb (1.46%) /decidim-proposals/app/assets/images/decidim/proposals/icon.svg -- 0.35kb -> 0.34kb (1.4%) /decidim-blogs/app/assets/images/decidim/blogs/icon.svg -- 0.39kb -> 0.39kb (1.25%) /decidim-conferences/app/assets/images/decidim/conferences/conference.svg -- 0.41kb -> 0.41kb (1.18%) /decidim-consultations/app/assets/images/decidim/consultations/icon.svg -- 0.69kb -> 0.68kb (0.71%) /decidim-initiatives/app/assets/images/decidim/initiatives/icon.svg -- 0.72kb -> 0.72kb (0.68%) /decidim-sortitions/app/assets/images/decidim/sortitions/icon.svg -- 0.81kb -> 0.81kb (0.48%) /decidim-assemblies/app/assets/images/decidim/assemblies/assembly.svg -- 1.25kb -> 1.24kb (0.39%) /decidim_app-design/app/assets/images/barcelona/heading-icon.svg -- 0.65kb -> 0.65kb (0.15%) /decidim_app-design/app/assets/images/barcelona/pattern-big.svg -- 1.44kb -> 1.44kb (0.07%) /decidim_app-design/app/assets/images/demo-consultations-banner.jpg -- 16.35kb -> 16.35kb (0.02%) /decidim-participatory_processes/db/seeds/city.jpeg -- 104.54kb -> 104.54kb (0%) /decidim-assemblies/db/seeds/city.jpeg -- 104.54kb -> 104.54kb (0%) /decidim-conferences/db/seeds/city.jpeg -- 104.54kb -> 104.54kb (0%) /decidim-budgets/lib/decidim/budgets/seeds/city.jpeg -- 104.54kb -> 104.54kb (0%) /decidim-meetings/lib/decidim/meetings/seeds/city.jpeg -- 104.54kb -> 104.54kb (0%) /decidim-consultations/db/seeds/city.jpeg -- 104.54kb -> 104.54kb (0%) /decidim-dev/lib/decidim/dev/assets/city.jpeg -- 104.54kb -> 104.54kb (0%) /decidim-consultations/db/seeds/city2.jpeg -- 127.43kb -> 127.42kb (0%) /decidim-participatory_processes/db/seeds/city2.jpeg -- 127.43kb -> 127.42kb (0%) /decidim-assemblies/db/seeds/city2.jpeg -- 127.43kb -> 127.42kb (0%) /decidim-conferences/db/seeds/city2.jpeg -- 127.43kb -> 127.42kb (0%) /decidim-initiatives/db/seeds/city2.jpeg -- 127.43kb -> 127.42kb (0%) /decidim-dev/lib/decidim/dev/assets/city2.jpeg -- 127.43kb -> 127.42kb (0%) /decidim_app-design/app/assets/images/meeting2.jpg -- 162.35kb -> 162.35kb (0%) /decidim_app-design/app/assets/images/meeting3.jpg -- 184.36kb -> 184.36kb (0%) /decidim-dev/lib/decidim/dev/assets/city3.jpeg -- 209.38kb -> 209.38kb (0%) /decidim_app-design/app/assets/images/demo-debate.jpg -- 253.30kb -> 253.30kb (0%) /decidim_app-design/app/assets/images/process-demo.jpg -- 332.25kb -> 332.25kb (0%) /decidim_app-design/app/assets/images/demo-consultations.jpg -- 426.39kb -> 426.39kb (0%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com> * Remove white spaces in component icon spec Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com> Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com> * Be able to mention groups (#5763) * refactor users endpoint * Add groups to mention list in tribute container * Add user group parser * Add usergroup renderers * wip * create user group mentioned event * complete specs fo new comment notification * clean duplicated scss * add members count to tribute container * changelog * fix locale order * rubocop offense * fix create_comment command spec * avoid flashing window when querying api * add debounce funciton * extract helper methods for group memberships queries * remove start with underscore limitation in nicknames * Add api entities for blog endorsements (#5847) * Update proposal_input_sort_spec when sorting by endorsement_count * add missing api attributes to blog posts * Update changelog * Add blog search capabilities to graphql * changelog * fix some comments * Feature/receive messages from everyone (#5720) * add direct_message options to user model * add user preferences tests * reorder locales * add methods to accept/reject user conversations * add conversation model tests * add tests for new permission handling * set visualization for profile page. add tests * changelog * fix collateral tests causalities * document method for obtaining conversation path * Add revoke authorizations functionality (#5814) * Verifier improvement - Add revoke authorizations functionality * [FIX] Added CHANGELOG entry * [FIX] Fixed couple Rubocop offenses * [FIX] Changes on spec test for command revoke_by_condition * [FIX] Fixed Rubocop offense * [FIX] Fixed revoke by condition command date issue * Add fixes related to PR code review * Fixes PR review's requested changes Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com> * Fix relative path in mentioned proposal email (#5852) * Fix use absolute url in proposal mentioned notification email But stay with the relative url for the internal notification. * Add changelog entry * Add a return button for users to get back to indexes (#5591) * Add back to list buttons for components - Tests included * fix i18n missing keys from proposals * remove class button on buttons * remove translated FR keys * refactor specs and define shared examples * The "sortition" component does not include the shared example because it is a special case. * fix rubocop offense * Budgets: Sort projects by different criteria (#5808) * Order budget projects * Add tests * Fix rubocop complaints * Update changelog * Simplify cases * Show the login form from the follow button if not yet logged in * New Crowdin translations (#5836) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Hungarian) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (German) * New translations en.yml (Galician) * New translations en.yml (Galician) * New translations en.yml (German) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Arabic) * New translations en.yml (Arabic) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Dutch) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Russian with many plural form) * New translations en.yml (Russian with many plural form) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Icelandic) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Norwegian) * New translations en.yml (Norwegian) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Czech) * New translations en.yml (Catalan) * New translations en.yml (Arabic) * New translations en.yml (Basque) * New translations en.yml (Norwegian) * New translations en.yml (Polish) * New translations en.yml (Indonesian) * New translations en.yml (Italian) * New translations en.yml (Spanish) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Galician) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (Hungarian) * New translations en.yml (German) * New translations en.yml (Russian with many plural form) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Swedish) * New translations en.yml (Turkish) * New translations en.yml (Finnish) * New translations en.yml (Finnish (plain)) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (German) * New translations en.yml (Galician) * New translations en.yml (Basque) * New translations en.yml (Arabic) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Czech) * New translations en.yml (Spanish, Mexico) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Spanish) * New translations en.yml (Finnish (plain)) * New translations en.yml (Swedish) * New translations en.yml (Turkish) * New translations en.yml (Indonesian) * New translations en.yml (Icelandic) * New translations en.yml (Hungarian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Italian) * New translations en.yml (Norwegian) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Russian with many plural form) * New translations en.yml (Catalan) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Czech) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish) * New translations en.yml (Spanish, Mexico) * Request confirmation to exit budgets component (#5765) * Warn when trying to leave budgets component before completing the vote * Add test for the alert before exiting the budgets component * fix: base URL used to detect component URLs was including locale * Component base URL based on current request instead of EngineRouter It was working OK when using EngineRouter, but it was very complicated to get the tests passing. EngineRouter uses organization's host attribute, that can't store a port in tests, while the browser adds the host and port to the link's `href` attribute. On the other hand, Capybara uses random ports for the tested application, and #2187 adds a `base` tag to the pages to improve the debugging of failed tests HTML screenshots. * docs: changelog entry added * Allow to see a participant's email from the admin panel (#5849) * feat: add "show email" icon to participants list * feat: add the modal to show the email * feat: make the show button work * feat: add an entry to the admin log when a user shows an email * feat: hide the Show button after showing the email address * docs: changelog entry * style: fix lint issues * test: replace unnecesary code with a test * test: system test for showing a participant email * style: suggested changes applied * Add CHANGELOG entry * Add scroll to bottom and apply it on conversations (#5718) * Add scroll to bottom and apply it on conversations * Add CHANGELOG entry * Fix CodeClimate and CircleCI errors. * Fix CodeClimate errors. * Place the 'scrollToBottom' method on the erb file directly to pass the CircleCI test. * When entering to a conversation, the window scrolls smoothly to bottom automatically. The code is refactored so there's no js code on show.html.erb but only on the js.s6 file. * When entering to a conversation, the window scrolls smoothly to bottom automatically. The code is refactored so there's no js code on show.html.erb but only on the js.es6 file. * Refactored the code: now the procedure won't look for all the elements with the class 'scroll-to-bottom' but it will look for only one instead. * Adding strings to double quotes instead of single quotes. * Add 'expect' to expect page to wait until the 'Send' button appears so the test doesn't fail. * Use jquery and add :slow tag to tests. * Add another "click_button" on test and change plain JavaScript to jQuery The extra "click_button" forces the test app to click the existing button. This way the tests inside the context on line 116 from the file system/messaging/conversations_spec.rb will pass successfully. * Add another 'click_button' to test * Add slow tag and expect page to have content 'Send' * Update CHANGELOG.md Leave only my changes * Remove lines on test that already exist on 'before' statement Co-authored-by: Javier Jiménez <57717422+jarvisct@users.noreply.github.com> Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com> Co-authored-by: Ivan Molinero <ivan.mr@coditramuntana.com> * Move test suite to GitHub Actions (#5843) * Lint code through GitHub Actions * Actually lint files * Ignore ruby gems when linting JS files * Properly cache NPM deps * Set cache path for npm * Run rubocop in parallel * Don't lint ERB files in deps * Don't make npm verbose * Test npm caching works * Remove npm cache It'sa ctually not working, so it just adds useless seconds to thew workflow * Run tests for main folder * Add tests for core module * Add missing workflows Created from a template * Simplify generators workflow * Automatically upload screenshots if tests fail * Ensure path exists before uploading * Create the screenshots path before uploading it * Install Ruby deps from inside each module folder This is how it works on CircleCI. * Revert "Install Ruby deps from inside each module folder" This reverts commit ad43682e643645e0fb6daca4e3d2bf3657ac2dfe. * Add README * Fix screenshots uploads They should be uploaded always... * Improve generators workflow * Try to fix generators workflow * Try to install ruby deps for generators * Install gems globally * Increase max wait time for slow specs * Run JS tests from comments workflow * Split proposals workflow in three * Install codecov * Set needed ENV vars for Codecov uploads * Use GitHub Action to upload coverage reports * Send coverage for main folder * Use custom names for the parallel proposals workflows * Delete decidim-dev workflow This folder doesn't have any test * Disable Codecov comments * Remove unused file * Don't report to CodeClimate from CircleCI * Revert "Don't report to CodeClimate from CircleCI" This reverts commit 5a6a087075a66ddc9efa96d246b794c21e61e9f7. * Don't change the formatter for CircleCI * Remove CircleCI config * Remove CircleCI build status badge * Add codecov status badge * Add test suite badges * Fix badges * Fix workflows README * Update .github/workflows/README.md Co-Authored-By: Oliver Valls <oliver.vh@coditramuntana.com> * Remove CircleCI env variable Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com> * Fix missing tribute source map (#5869) * Remove the source map comment from tribute * Add CHANGELOG entry * Fix workflows to work from forks (#5880) * Fix duplicated actions workflows (#5883) * Fix ducplicated actions workflows On PRs from the repo, the current setup was causing duplicated workflows. This should fix the issue. * Run test suite for any base branch on PRs * Add missing defaults in initializer template (#5858) * Add missing defaults in initializer template * Fix style * Apply latest ActionView patches (#5896) * Apply latest ActionView patches * Add changelog entry * Update Gemfile.lock from modules that depend on main dependencies * Retry failed test to avoid flaky (#5894) * Retry failed test 3 times * Fix offenses * Add changelog entry * Add a paragraph about the settings of the initiatives module (#5855) * Force signin on API if the organization requires it (#5859) * Force signin on API if the org requires it * Add changelog * Fix typo * Fix class name * Fix docs * Add tests * Lint code * Add missing indexs on foreign keys (#5885) * Add missing indexs on foreign keys * Add changelog * Confirmation emails are sent in user's language (from browser) (#5789) * Allow users to register in their own language * Add changelog entry * Remove local translations Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> * Add nowrap white space to compact buttons (#5891) Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com> * Apply simplified design for activity cards for the home page, and Timeline and Activity Tab (#5848) * Activity cards * New Crowdin translations (#5761) * New translations en.yml (French) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * Apply simplified design for activity cards for the home page, and Timeline and Activity tabs * Change rspec tests on comment_activity_cell and proposal_activity_cell to check if card__content exists instead of card-data css class and add description into activity card * Change rspec tests on comment_activity_cell and proposal_activity_cell to check if card__content exists instead of card-data css class and add description into activity card * Fix text label on decidim-app_design * Remove changelog lines Co-authored-by: Javier Usobiaga <javier@swwweet.com> Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> * Security patches (#5553) * Don't allow comments deeper than MAX_DEPTH * Force SSL from decidim-core * Do not expose GraphiQL in production, and do not expose ruby version in GraphQL * Throttle failed authorization attempts * Prevent timing attacks on login and leaking timing info * Expire sessions after 24h of creation * Do not expose process statistics if hidden * Invalidate sessions on logout * Do not allow uploading or attaching SVGs * Obscure image processing errors * Sanitize some user input * Escape process titles and hashtags * Escape urls and other fields in meetings * Escape fields in sortitions * Create configuration for session expiration and exposing graphiql * Use rails logger instead of STDERR Co-Authored-By: Oriol Gual <oriolgual@users.noreply.github.com> * Use a translated message for carrierwave errors * General fixes and refactoring * Update changelog * Do not link to graphiql if it is disabled * Fix changelog * Fix CHANGELOG once again * Undo GraphiQL-related changes * Fix changelog * Fix links in changeelog * Move SSL to a config option * Don't show stats via the API * Remove wrong changelog entries * Fix method name * Fix changelog * Undo wrong changes * Fix changelog * Fix lints Co-authored-by: Oriol Gual <oriolgual@users.noreply.github.com> Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> * Improve documentation on Views/HTML customizations (#5892) * fix: indeterminate checkboxes state is not consistent between browsers (#5901) * fix: indeterminate checkboxes state is not consistent between browsers It seems that Firefox can have indeterminate checked checkboxes while Chrome don't. * doc: changelog entry added Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com> * Fix questionnaire answer method to avoid query model relationships (#5819) * change answer method name to avoid query model relationshiops * add changelog * fix survey tests * additional questionnaire spec fix * update changelog * update changelog * Fix map hovering over the secondary navigation element (#5871) * Fix map hovering over the secondary navigation element * Add CHANGELOG entry * Change the map marker color to the Decidim primary color (#5870) * Change the map marker color to the Decidim primary color * Add CHANGELOG entry * Replace current meetings hook with highlighted elements hook (#5897) * feat: replace current meetings hook with highlighted elements hook This will include proposals, accountability and more elements apart from meetings * doc: add changelog entry * fix: missing translation added Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com> * Improve accessibility issues (#5684) * add alt element to logo and add new translation key logo_alt * Add label and title elements to topbar_search * Add alt attribute to author avatar images * Reformat elements heading on homepage * Add aria-label element to off-canvas nav button * Adding screen-reader title to images card links on homepage * Add temporary submit button to search topbar * Add button custo to topbar__search class * Add alt attribute to links and images * Modify muted color contrast * Remove h6 attribute and class from legend element in filter section and replace with mini-title class * Add img role attribute to Decidim icons * Remove role img attrbute from follow button * Modify search topbar submit button * Replace div tag with a nav tag for user menu * Unify main and mini footer background color * Add title to notifications link and conversations link in user menu * Modify secondary color to better contrast in Decidim * Update search topbar to align with submit button * Change primary color to better contrast * Add title attribute to topbar search submit button * Add label to select_area form * Add accessibility to budgets filter forms * Add accessibility to debates filter forms * Add accessibility to meetings filter forms * Add accessibility to accountability search form * Add accessibility to proposals filter forms * Add accessibility to sortitions filter forms * Add translation to cloud-download button * Add title to download link button * Add alt element to assemblies members avatar * Add accessibility to initiatives filter forms * Add accessibility to consultations search form * Add alt attribute to conferences logo partners * Add alt attribute to conferences speaker images * Add alt attribute to conferences media pictures * Add underline text-decoration to links * Add screen reader span to social media links on homepage * Add title attribute and aria_label * Add title attribute to search form * Add title attribute and aria_label * Replace <a> tag with <span> tag and add styling * Add label tag to search form field * Delete title from social media icons * Delete title from share link button * Replace last activity heading card title h5 to h4 * Fix position error with </article> close tag * Modify all platform's heading * Add title to terms and conditions link * Modify cards tabindex on homepage * Remove h6 tag from upcoming meetings card * Redesign of the platform's heading html attributes * Add title to see_all_assemblies button * Add aria_label attribute to read_more button * Add aria_label to number_per_page link * Add aria_label to first_page link * Add aria_label to last_page link * Add aria_label to next_page link * Add aria_label to previous_page link * Add aria_label to comments_count * Add aria_label to endorsements_count * Add aria_label to page_number * Add aria_label to comments link on proposal page * Replace heading with span attribute for card title on last_activity page * Replace all h4 card__title with span attribute * Add explicit titles to home page link buttons * Change calendar_url heading title * Modify heading of proposal page * Modify heading of title action results count * Add href attribute to Cancel link on scope picker * Add href attribute to order and resut_per_page links * Replace <u> attribute with <span> for download_data links on processes * Include <legend> existing tag in the <fieldset> tag * Remove <fieldset> tag from remember_me checkbox on sign_in page * Modify title of assemblies social network links * Add title attribute to proposal comments/endorsements counter links * Add title attribute to calendar URL field for meetings * Add title attribute to results_per_page link * Add translations for result_per_page and pagination links titles * Add title attrbute to pagination links * Add title attribute to navigation links for pagination * Add title attribute to each <li> results_per page links in <ul> menu * stylelint scss files * Update jest tests * erb files linting * fix i18n missing key 'logo_alt' * fix rubocop offenses * fix erblint offenses * update core spec system according to accessibility * update specs system * update specs system * light refactor layout_helper and implements specs icon helper * change simplecov version * change simplecov version * Update title assertion in spec core filter_form_builder_spec.rb Co-Authored-By: Armand Fardeau <armandfardeau@users.noreply.github.com> * Update translation link to root_url Co-Authored-By: Armand Fardeau <armandfardeau@users.noreply.github.com> * update font size according to original state * add headings on cards * refactor _organization_colors to avoid blank style tag * remove deprecated xlink:href attribute * refactor top_search_bar structure * remove double main tag definition * remove useless alt attribute on a tag * change div by span in button tag * use hidden_field_tag rather than content_tag * remove aria_label attribute on links * remove label attribute on search_field_tag in accountability * remove invalid alt attribute * remove invalid aria-label attribute on links * remove invalid aria-label attribute on links * move alt logo on image tag * replace span by div * Remove useless red color on h1 Was a mistake * extract div tag from label tag * refactor filter types dropdown * replace chart article tag by div * remove logo style tag within span and creates scss file layout * remove useless comment in css * remove deprecated frameborder attribute and fix empty p tag * add missing alt attribute on image * Allow postgres Docker image without password * Add alt attribute on avatar * Change button tag to link * strip_tags in p tag * Replace div by span inside button tag * Allow postgres Docker image without password * light refactor * Add :focus styling on navbar links * Add :focus and underline styling to topbar links * remove invalid button in a tag * add alt attribute on image_tag in image_big * Fix stylelint issues * correct typo on button type * move legend tag to h3 * replace multiple main tag by div * erb lint and rubocop * Add :focus style to Register link on the home page * Add :focus style to hollow button * Add :focus style to card links * Add :focus style to footer links * change card__title from h4 to span in cards * remove fieldset tag in registration form * add translations for image helpers alt attribute * replace img tag by image_tag helper * refactor link_to helper using value rather than block * add title attribute on links * remove aria-label on link which contains a title attribute * create new date format and edit datetime attribute * add strip_tags option for decidim_sanitize helper * use strip_tags option in decidim_sanitize helper * erblint corrections * Update decidim-blogs/app/views/decidim/blogs/posts/_sidebar_blog.html.erb * Fix stylelint issue * Change title attribute for the logo and change translation key name for it * Update comments component test * Add background color to focus style for navbar links * Reformat focus and hover style for title bar * Fix stylelint issue * Add focus style for each link on the home page * Add focus style to main and secondary buttons * Add skip to main content button * Fix style issue for register button on home page * Fix missing translation issue * Add hover and focus style to Decidim * Modify focus style for card links * Fix stylelint issue * Add focus style to pagination elements * Add focus style to m-bottom links * Unify/reformat focus style on Decidim * Fix parent/child loop on Assemblies (#5807) * ensure assembly can have a parent * Avoid loop between parent and child * Add changelog entry * Fix case when assembly is created * light refactor assemblies sorting in assemblies spec (#7) * light refactor assemblies sorting in assemblies spec * avoid fails due to order * update parent assemblies spec Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> Co-authored-by: Quentin Champ <26109239+Quentinchampenois@users.noreply.github.com> Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com> * Mockup design for Complex Voting flow and Budget Improvements (#5931) * New Crowdin translations (#5761) * New translations en.yml (French) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * Budget card fixes * Budget flow - several pages * Budget already voted pages * Budget voted list * Budget flow fixes * partial prop fix * Budget custom filters * Tags, order by, filter fix - budget list * Updated copies for vote removal * fix erblint offenses * Already voted page - delete and start again info * Removed bug in finished voting page * Revert "New Crowdin translations (#5761)" This reverts commit e66e49a8dae5f5b3ce67c8e024a514d64fab373d. Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> Co-authored-by: Javier Usobiaga <javier@swwweet.com> * Fix the scopes picker rendereding escaped characters (#5793) * Fix the scopes picker rendereding escaped characters When a value was already selected for the scopes picker, fix the rendering of the new selected value. Before there was double escaping of the string causing the output to look weird. * Add CHANGELOG entry * Make coverage reports more relevant (#5934) * Ignore test files on coverage reports * Manually track all Ruby files on coverage reports * Don't include migrations on coverage reports * Don't include config files on converage reports * Remove command filter on coverage reports * Re-track all files * Fix tracked files * Revert "Fix the scopes picker rendereding escaped characters (#5793)" (#5937) This reverts commit ed494f91081eba5adfc878f8aa2ee8766516ef94. * Fix the scopes picker rendereding escaped characters (#5939) * Fix the scopes picker rendereding escaped characters * Adds changelog Co-authored-by: Ramon <ramon.ct@coditramuntana.com> * fix move proposal endorsements migration (#5953) * fix move proposal endorsements migration * add changelog * Fix bad formatted changelog entries * Update changelog with current develop * Add minimum projects rule to Budgets (#5865) * Add minimum projects rule to Budgets * refactor(js): budget_rule_toggler * validate budget component form * add specs for budgets voting rules * move to Budgets module extra logic of settings validation * move to Proposals extra logic of settings validations * documentation improvements * refactor current_order method * Upgrade sassc and sassc-rails dependency (#5910) * Fix error 500 when showing new debate notifications (#5964) * do not delegate author to resource directly. Let the concern provide the method * add changelog * Add a parameter to specify a list of whitelist ip on /system (#5669) * Add a parameter to specify a list of ip to white list * Change blocklist name * Change config accessor name * Avoid unnecessary iterations Co-Authored-By: Oliver Valls <tramuntanal@gmail.com> * Change whitelist for accesslist * Refactor to add tests * Fix rubocop offense * don't mutate the config accessor directly Co-authored-by: Oliver Valls <tramuntanal@gmail.com> * Fix supported versions in SECURITY.md (#5957) * Fix supported versions in SECURITY.md * Add changelog entry * Conversations with more than one participant (#5861) * Allow to create conversations with more than one participant * Added new form param to converstation controller * Check conversation with multiple users * Clean code debugs * Added changelog file * Cleans debug code line * Fixes rubocop offenses * Fixes some js lints * Disable mentioning users with notifications disabled * Fixes a) some js linter issues b) refactor some helper methods c) added more conv…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Make Blog Posts endorsable.
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots
Post example