Add copy to clipboard feature to share links #7697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcasals
previously approved these changes
Apr 6, 2021
mrcasals
added
module: core
type: feature
|
@ahukkanen some conflicts appear and I can't resolve them using the GitHub UI, could you review them please? |
|
@mrcasals Conflicts resolved. |
|
Ah there was a HTML validation issue that caused system specs to fail. Thanks to #7751, we did not introduce a new HTML validation issue. 🥳 |
mrcasals
approved these changes
Apr 7, 2021
entantoencuanto
added a commit
that referenced
this pull request
Apr 13, 2021
* develop: Let admins disable participatory space filters (#7819) Identify online voters (#7777) Restore vote tests in the elections module using the real bulletin board (#7802) Show initiative image in homepage (#7824) Let admins filter participatory space private users (#7817) Add Ballot Style to Census Datum (#7788) Show missing election component callout also for in-person votings (#7809) Fix canceling scope select doesnt open reveal (#7805) Fix: Reported users are displayed in all tenants (#7628) Evote - onboarding workflow (#7758) Add copy to clipboard feature to share links (#7697)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
We've received user feedback that the copy share link feature is unclear because it shows the "not allowed" cursor for the text field.
This fixes that issue and adds a "copy to clipboard" button to the share link window.
Testing
📋 Checklist
docs/.📷 Screenshots
Now it looks like this with the cursor:
After this change it looks like this:
In addition, it will announce the screen reader that the link was copied to clipboard.