Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix canceling scope select doesnt open reveal #7805

Merged
merged 1 commit into from Apr 7, 2021
Merged

Fix canceling scope select doesnt open reveal #7805

merged 1 commit into from Apr 7, 2021

Conversation

lahdeero
Copy link
Contributor

@lahdeero lahdeero commented Apr 7, 2021

🎩 What? Why?

Canceling scope select opens reveal

📌 Related Issues

#7621

Testing

  1. Go to /processes
  2. Click "Select a scope"
  3. Click "Cancel"

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

♥️ Thank you!

@lahdeero lahdeero changed the title Closing modal doesnt open reveal Fix canceling scope select doesnt open reveal Apr 7, 2021
@mrcasals mrcasals added module: core type: fix PRs that implement a fix for a bug labels Apr 7, 2021
@mrcasals mrcasals merged commit caf891c into decidim:develop Apr 7, 2021
@mrcasals
Copy link
Contributor

mrcasals commented Apr 7, 2021

@lahdeero thanks!!

@ahukkanen ahukkanen deleted the fix/cancel-scope-select branch April 7, 2021 18:17
entantoencuanto added a commit that referenced this pull request Apr 13, 2021
@entantoencuanto
Merge branch 'develop' into chore/rails-6-upgrade
0cf09e7 
* develop:
  Let admins disable participatory space filters (#7819)
  Identify online voters (#7777)
  Restore vote tests in the elections module using the real bulletin board (#7802)
  Show initiative image in homepage (#7824)
  Let admins filter participatory space private users (#7817)
  Add Ballot Style to Census Datum (#7788)
  Show missing election component callout also for in-person votings (#7809)
  Fix canceling scope select doesnt open reveal (#7805)
  Fix: Reported users are displayed in all tenants (#7628)
  Evote - onboarding workflow (#7758)
  Add copy to clipboard feature to share links (#7697)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcasals mrcasals mrcasals approved these changes

Assignees
No one assigned
Labels
module: core type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lahdeero @mrcasals