Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show missing election component callout also for in-person votings #7809

Merged
merged 1 commit into from Apr 8, 2021
Merged

Show missing election component callout also for in-person votings #7809

merged 1 commit into from Apr 8, 2021

Conversation

orlera
Copy link
Contributor

@orlera orlera commented Apr 7, 2021 •
edited by mrcasals

🎩 What? Why?

In #7217, we added a callout to warn the admin when an online/hybrid voting does not have any Election component.
We actually want to show the callout also for in_person votings (basically for all kinds).

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

image

♥️ Thank you!

@orlera orlera self-assigned this Apr 7, 2021
@orlera orlera added contract: e-voting Barcelona City Council contract module: elections type: bug Issues that describe a bug labels Apr 7, 2021
leio10
leio10 approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 💎

slickepinne
slickepinne approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@slickepinne slickepinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@orlera
Copy link
Contributor Author

orlera commented Apr 8, 2021

@decidim/mantainers could you please review this? 👓

@mrcasals mrcasals merged commit b259b34 into develop Apr 8, 2021
@mrcasals mrcasals deleted the fix/missing-elections-callout-for-inperson-votings branch April 8, 2021 14:06
@mrcasals mrcasals added type: fix PRs that implement a fix for a bug and removed type: bug Issues that describe a bug labels Apr 8, 2021
entantoencuanto added a commit that referenced this pull request Apr 13, 2021
@entantoencuanto
Merge branch 'develop' into chore/rails-6-upgrade
0cf09e7 
* develop:
  Let admins disable participatory space filters (#7819)
  Identify online voters (#7777)
  Restore vote tests in the elections module using the real bulletin board (#7802)
  Show initiative image in homepage (#7824)
  Let admins filter participatory space private users (#7817)
  Add Ballot Style to Census Datum (#7788)
  Show missing election component callout also for in-person votings (#7809)
  Fix canceling scope select doesnt open reveal (#7805)
  Fix: Reported users are displayed in all tenants (#7628)
  Evote - onboarding workflow (#7758)
  Add copy to clipboard feature to share links (#7697)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leio10 leio10 leio10 approved these changes

@mrcasals mrcasals mrcasals approved these changes

@slickepinne slickepinne slickepinne approved these changes

@agustibr agustibr Awaiting requested review from agustibr

@beagleknight beagleknight Awaiting requested review from beagleknight

Assignees

@orlera orlera

Labels
contract: e-voting Barcelona City Council contract module: elections type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@orlera @leio10 @mrcasals @slickepinne