Fix voting with single election #9097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oriolgual
force-pushed
the
fix-voting-with-single-election
branch
from
0253923
to
4b211e3
Compare
andreslucena
added
module: elections
type: fix
andreslucena
requested changes
Mar 29, 2022
oriolgual
force-pushed
the
fix-voting-with-single-election
branch
2 times, most recently
from
09904bf
to
6df2cf3
Compare
|
Done @andreslucena! |
ahukkanen
reviewed
Apr 29, 2022
The controller will try to load the Election from the params but when rendering an election that's the single one in a voting there are no params. Instead, it's better to use the model in the cell.
oriolgual
force-pushed
the
fix-voting-with-single-election
branch
from
6df2cf3
to
358b7cb
Compare
ahukkanen
approved these changes
May 1, 2022
andreslucena
pushed a commit
that referenced
this pull request
May 6, 2022
The controller will try to load the Election from the params but when rendering an election that's the single one in a voting there are no params. Instead, it's better to use the model in the cell.
andreslucena
pushed a commit
that referenced
this pull request
May 6, 2022
The controller will try to load the Election from the params but when rendering an election that's the single one in a voting there are no params. Instead, it's better to use the model in the cell.
ahukkanen
pushed a commit
that referenced
this pull request
May 10, 2022
The controller will try to load the Election from the params but when rendering an election that's the single one in a voting there are no params. Instead, it's better to use the model in the cell. Co-authored-by: Oriol Gual <oriolgual@users.noreply.github.com>
Merged
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
When there's only one voting enabled, and this voting only has an election, the election is rendered directly.
This was failing because the cell was delegating some methods to the controller, but the controller is trying to load the election from the params.
Instead, we should use the election that's already loaded in the cell.