Upgrade Rubocop libraries

[alecslupu]

🎩 What? Why?

Upgrade

Gem                           Current     Latest      Requested  Groups
rubocop                       0.92.0      1.28.2
rubocop-rails                 2.9.1       2.14.2
rubocop-rspec                 1.43.2      2.10.0

♥️ Thank you!

[alecslupu]

It appears that the upgrade itself has changed the standards or naming, revealing a lot of linting errors.

@ahukkanen , @andreslucena please advise on the following:

1. Fix the violations as new Rubocop setup is instructing (becoming a very large PR)
2. Adjust the settings of Rubocop to ignore the violations

[ahukkanen]

It appears that the upgrade itself has changed the standards or naming, revealing a lot of linting errors.

@ahukkanen , @andreslucena please advise on the following:

1. Fix the violations as new Rubocop setup is instructing (becoming a very large PR)
2. Adjust the settings of Rubocop to ignore the violations

I would vote for option 1, i.e. fixing the violations. I ran rubocop against the whole codebase with these changes and there were 1397 violations of which 997 were automatically corrected. So that leaves 400 violations to correct which is quite a "chore" but doable.

We are not expecting you to do those changes unless you want to @alecslupu. We can also take this issue into the maintenance backlog.

The current RSpec rule block also needs to be fixed, as that's old syntax right now.

[alecslupu]

It appears that the upgrade itself has changed the standards or naming, revealing a lot of linting errors.
@ahukkanen , @andreslucena please advise on the following:

1. Fix the violations as new Rubocop setup is instructing (becoming a very large PR)
2. Adjust the settings of Rubocop to ignore the violations

I would vote for option 1, i.e. fixing the violations. I ran rubocop against the whole codebase with these changes and there were 1397 violations of which 997 were automatically corrected. So that leaves 400 violations to correct which is quite a "chore" but doable.

We are not expecting you to do those changes unless you want to @alecslupu. We can also take this issue into the maintenance backlog.

The current RSpec rule block also needs to be fixed, as that's old syntax right now.

I can start working on this...

[andreslucena]

Awesome, thanks for taking care of this one @alecslupu

[alecslupu]

@ahukkanen I have updated the PR to add a list of disabled cops to help us through upgrade. I would not want to make this PR a 100+ files changed.
Once this PR is merged, i will move to fix cop by cop in a separate PRs.

[ahukkanen]

For me this approach seems perfectly fine.

Just one thing I did not completely understand so if you could explain @alecslupu I'd appreciate that.

@andreslucena Are you fine with the suggested approach fixing these issues?