Enable Rails related Rubocop rules

[alecslupu]

🎩 What? Why?

Please describe your pull request.

📌 Related Issues

Link your PR to an issue

• Related to Upgrade Rubocop libraries #9201
• Fixes #?

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

• ❓ CONSIDER adding a unit test if your PR resolves an issue.
• ✔️ DO check open PR's to avoid duplicates.
• ✔️ DO keep pull requests small so they can be easily reviewed.
• ✔️ DO build locally before pushing.
• ✔️ DO make sure tests pass.
• ✔️ DO make sure any new changes are documented in docs/.
• ✔️ DO add and modify seeds if necessary.
• ✔️ DO add CHANGELOG upgrade notes if required.
• ✔️ DO add to GraphQL API if there are new public fields.
• ✔️ DO add link to MetaDecidim if it's a new feature.
• ❌AVOID breaking the continuous integration build.
• ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing

♥️ Thank you!

[ahukkanen]

I just noticed one potential issue below but I also think it's outside of the scope for this PR.

I also noticed you left Rails/I18nLocaleTexts enabled, is it on purpose?

decidim/.rubocop-disabled.yml

Lines 49 to 50 in 2068f4a

	Rails/I18nLocaleTexts:
	Enabled: false

The only violation from that seems to be here:

decidim/decidim-elections/app/forms/decidim/votings/admin/voting_form.rb

Line 32 in 7b2a3d6

validates :voting_type, presence: true, inclusion: { in: Votings::Voting.voting_types, message: "%{value} is not a valid voting type" }

Can we fix that too?

[alecslupu]

Can we fix that too?

Yes, it was left on purpose as that translation key may be tricky ( i do not have a working election test suite on my local ).
I would leave it at the moment the way it is, close the most of rubocop violations, and handle the 'hard' ones at the end.

[alecslupu]

Can we fix that too?

Yes, it was left on purpose as that translation key may be tricky ( i do not have a working election test suite on my local ). I would leave it at the moment the way it is, close the most of rubocop violations, and handle the 'hard' ones at the end.

@ahukkanen , the requested violation has been fixed in 223f0cd

[alecslupu]

@ahukkanen , can you have a look on this, so we can minimize the rubocop issues ? I am waiting for this to be merged, so I can unlock #9272

[ahukkanen]

Thanks @alecslupu, it looks good now.

There's still the dependent: :destroy thing I mentioned but I think that's a wider problem in Decidim and I don't think it's very common case.

Could you please remove this comment from the disabled rules:

decidim/.rubocop-disabled.yml

Lines 22 to 23 in 223f0cd

	#Rails/I18nLocaleTexts:
	# Enabled: false

After that it's good to go for me.

[alecslupu]

Thanks @alecslupu, it looks good now.

There's still the dependent: :destroy thing I mentioned but I think that's a wider problem in Decidim and I don't think it's very common case.

Could you please remove this comment from the disabled rules:

decidim/.rubocop-disabled.yml

Lines 22 to 23 in 223f0cd

	#Rails/I18nLocaleTexts:
	# Enabled: false

After that it's good to go for me.

The commented code removed in 463aff2
The dependent: :destroy, should be handled separately by module, but that may be a chore work to be done.

[ahukkanen]

The dependent: :destroy, should be handled separately by module, but that may be a chore work to be done.

Yep, I created a separate issue #9291 to track that.