Fix multiple rubocop violations #9272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecslupu
force-pushed
the
ale-fix-rubocops
branch
from
0e24001
to
2f02629
Compare
alecslupu
added
dependencies
alecslupu
force-pushed
the
ale-fix-rubocops
branch
7 times, most recently
from
8232ab5
to
862189f
Compare
12 tasks
alecslupu
force-pushed
the
ale-fix-rubocops
branch
from
1ee07aa
to
80d8ae8
Compare
|
@ahukkanen , this PR can be reviewed. Please have a look and decide if The other 3 remaining can be addressed on a later date, or via a chore task. Currently: |
ahukkanen
requested changes
May 13, 2022
There was a problem hiding this comment.
Thanks @alecslupu once again!
Could you please revert the changes in other locales than en.yml please?
Those will be automatically updated through Crowdin and if we manually edit those files, it may mean also manually fixing the merge conflicts in the Crowdin PRs.
That's why we only want to do changes in the en.yml files.
|
@alecslupu there's some pending comment, can you take it a look please? Thanks |
roxanaopr
force-pushed
the
ale-fix-rubocops
branch
from
f108df2
to
14e3ef4
Compare
roxanaopr
force-pushed
the
ale-fix-rubocops
branch
from
14e3ef4
to
a1cdf92
Compare
ahukkanen
approved these changes
Jun 9, 2022
andreslucena
pushed a commit
that referenced
this pull request
Jul 6, 2022
* Fix Style/HashConversion * Fix Style/QuotedSymbols * Fix: Security/Open * Fix Security/IoMethods * Refactor for Naming/VariableNumber * Rename total_admins_last_24 stat to mitigate Rubocop Naming/VariableNumber * Rename total_participants_last_24 stat to mitigate Rubocop Naming/VariableNumber * Finish Naming/VariableNumber refactor * Cleanup the rubocop disabled * Revert changes done in other languages than en * Revert changes done in other languages than en * Fix lnting issues Co-authored-by: roxana.oprescu <roxana.oprescu@tremend.com> Co-authored-by: roxanaopr <66411127+roxanaopr@users.noreply.github.com>
eliegaboriau
pushed a commit
to eliegaboriau/decidim
that referenced
this pull request
Oct 25, 2022
* Fix Style/HashConversion * Fix Style/QuotedSymbols * Fix: Security/Open * Fix Security/IoMethods * Refactor for Naming/VariableNumber * Rename total_admins_last_24 stat to mitigate Rubocop Naming/VariableNumber * Rename total_participants_last_24 stat to mitigate Rubocop Naming/VariableNumber * Finish Naming/VariableNumber refactor * Cleanup the rubocop disabled * Revert changes done in other languages than en * Revert changes done in other languages than en * Fix lnting issues Co-authored-by: roxana.oprescu <roxana.oprescu@tremend.com> Co-authored-by: roxanaopr <66411127+roxanaopr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Fix the following Rubocop violations:
📌 Related Issues
Link your PR to an issue
Testing
This PR does not add any new Decidim functionality
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
