Backport 'Don't show deleted resources in last activities ' to v0.26 #9330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clarify describe block title * Improve CSS selector in spec so it's more specific * Add failing spec * Make ActionLog aware of deleted resources * Move the deleted comment factory to a trait * Fix linter offenses
andreslucena
added
backport
ahukkanen
previously approved these changes
May 19, 2022
|
@andreslucena There seems to be a broken spec here. I re-ran it but it is still failing due to the same reason. |
andreslucena
force-pushed
the
backport/dont-show-deleted-resources-in-9293
branch
from
ad99108
to
a643d99
Compare
|
@ahukkanen I've fixed the spec. The problem was related with #8756, as I was using markup that's only available in |
ahukkanen
approved these changes
May 24, 2022
Merged
12 tasks
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃帺 What? Why?
Backport #9293 to v0.26