Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved bash code styling #16

Open
AlexSkrypnyk opened this issue Jul 14, 2016 · 0 comments
Open

Improved bash code styling #16

AlexSkrypnyk opened this issue Jul 14, 2016 · 0 comments

Comments

@AlexSkrypnyk
Copy link

AlexSkrypnyk commented Jul 14, 2016

I suggest following https://google.github.io/styleguide/shell.xml#Variable_Names

Currently, global constants, env variables and one-time variables that can be local are using the same UPPERCASE format. Would be nice to have local vars as lowercase.

Also, lots of functionality is executed in global context without being split into functions. I suggest moving some functionality into functions to make contribution and debugging easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant