address view does not show unconfirmed transactions

[raedah]

No description provided.

[papacarp]

Some sleuthing guidance for this one:

1. if an address has no transactions in it previously, then addressHistory fails and it falls back to RPC to display the transactions which includes unconfirmed transactions.

dcrdata/explorer/explorerroutes.go

Lines 353 to 358 in e22ff16

	addrHist, balance, errH := exp.explorerSource.AddressHistory(
	address, limitN, offsetAddrOuts, txnType)
	// Fallback to RPC if DB query fails
	if errH != nil {
	log.Errorf("Unable to get address %s history: %v", address, errH)
	addrData = exp.blockData.GetExplorerAddress(address, limitN, offsetAddrOuts)

Thus we are able to see unconfirmed transactions sometimes.

2. if an address does have transactions in it previously, then AddressHistory succeeds, unconfirmed transactions are retrieved, but never merged into the resulting output.

dcrdata/explorer/explorerroutes.go

Line 441 in e22ff16

addressOuts, numUnconfirmed, err := exp.blockData.UnconfirmedTxnsForAddress(address)

They are just left in a the var uctxn and ignored. The fix is to merge these into the addrData.Transactions list, and likely re-slice that list to adhere to the start/limit inputs.

This is my theory as I haven't noticed an unconfirmed transaction go through that has previous history in it to verify and my testnet is not up right now.

If this is not urgent then due to the rework happening on addresses table this should likely be fixed after we sort out the disposition of #427 by either @dmigwi or I. If urgent I can put a PR in for it based on existing architecture.

[chappjc]

Yes, this is absolutely right. I had started a branch fixing these issues, but never finished up. https://github.com/chappjc/dcrdata/commits/addr-page-fixes

I must have stashed teh changes related to the above issues though.

[chappjc]

Please feel free to pick this up of course. But do not wait on PR #427 . It's big and breaking, so we're not going to rush it through. Although it's getting closer.

[dmigwi]

Since the unconfirmed transactions are already available in the frontend and the only problem is when they are displayed why not add a link to the UNCONFIRMED metric value such that when the link is clicked the unconfirmed txs appear.

I suggest we add the link to the box in red. Whats your take on this @papacarp?

[chappjc]

Correction: I meant do not wait on *PR #427 *

[raedah]

I would do it the way @papacarp suggested, "merge these into the addrData.Transactions list, and likely re-slice that list to adhere to the start/limit inputs." That way the information is inline and does not require additional user interaction to access.

[chappjc]

I agree with @raedah

[papacarp]

Ok. I will put in a PR for it.