Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tickets page: distinguish between live and immature #404

Merged
merged 2 commits into from
Jun 25, 2019
Merged

tickets page: distinguish between live and immature #404

merged 2 commits into from
Jun 25, 2019

Conversation

beansgum
Copy link
Contributor

@beansgum beansgum commented Jun 9, 2019

Closes #349
Screenshot 2019-06-09 at 6 30 55 PM

jholdstock
jholdstock reviewed Jun 9, 2019
View reviewed changes
controllers/main.go Outdated Show resolved Hide resolved
@jholdstock
Copy link
Member

Discussed with @C-ollins that a better way to achieve this would be to have dcrwallet set the status correctly to "immature" rather than "live".

This needs to be changed because the call to GetBestBlock is removed in #402, so this change should not depend on the current height being known.

@jholdstock
Copy link
Member

Work to identify immature/live tickets being done in decred/dcrwallet#1478

@dajohi
Copy link
Member

dajohi commented Jun 11, 2019

Will need to require RPC version check
decred/dcrwallet#1481

@jholdstock
Copy link
Member

dcrstakepool/backend/stakepoold/rpcclient.go

Line 15 in b25f430

var requiredWalletAPI = semver{major: 6, minor: 0, patch: 0}

@beansgum
use same struct for immature & live tickets
8c44e3e 
- set json-rpc required version to 6.0.1
jholdstock
jholdstock reviewed Jun 24, 2019
View reviewed changes
Copy link
Member

@jholdstock jholdstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be working well and the code looks good.

I just want to wait until my testnet ticket matures and I see it move from Immature to Live, and then I will approve this PR.

jholdstock
jholdstock approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@jholdstock jholdstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed working perfectly

@dajohi dajohi merged commit dcd6a5e into decred:master Jun 25, 2019
girino added a commit to girino/dcrstakepool that referenced this pull request Sep 7, 2019
@girino
Merge commit 'dcd6a5e5b66ce42b9d0eaed458820c8b6761c2fe'
1bca257 
* commit 'dcd6a5e5b66ce42b9d0eaed458820c8b6761c2fe':
  tickets page: distinguish between live and immature (decred#404)
  stats page: split stats & status into network stats & pool stats (decred#408)
  sync deps (decred#411)
  Fix confirmation messages for Registration and password reset (decred#419)
  gui: fix broken image paths. (decred#418)
  Minor style fixes (decred#409)
jyap808 pushed a commit to ubiq/dcrstakepool that referenced this pull request Dec 12, 2019
@beansgum @jyap808
tickets page: distinguish between live and immature (decred#404)
6e6e543 
* tickets page: distinguish between live and immature

* use same struct for immature & live tickets

- set json-rpc required version to 6.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dajohi dajohi dajohi approved these changes

@jholdstock jholdstock jholdstock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Design] Tickets page: Distinguish between live and immature
3 participants
@beansgum @jholdstock @dajohi