[ln] Initial Version #2107
[ln] Initial Version #2107
Conversation
There was a problem hiding this comment.
Good job on this PR!
Tested the basic functionalities and everything seems to be working.
- connecting to ln unlocked wallet
- fund / withdraw from wallet to LN
- open/ close channel
- creating invoice (noticed an error )
- send payments
Only the invoice creation which I noticed this error. Not sure what this might be.
I also left some comments on the code, but nothing really important
Good job!
|
Fixed review issues. Also, I added the node's info to the ln wallet tab to make it easier to open channels from faucets. |
|
needs rebase |
This is the first version of an embedded LN wallet UI on decrediton. Current features: - Startup, link dcrlnd to the currently running wallet and unlock it - Open/Close channels - Create invoices - Send payments - Enable autopilot - Show logs The current implementation relies on the remote wallet functionality of dcrlnd. For the moment, in order to enable support to LN, users need to manually edit the global decrediton config file to set `"ln_enabled: true"`.
There was a problem hiding this comment.
This is getting really good, thanks for it Matheus.
I re-reviewed and have a couple comments. I noticed a warning when starting the dcrlnd:
It looks like I couldn't open channels, it says that the peers is offline, but looking at https://ln-map.jamieholdstock.com/ it says online
As I couldn't open channel I was not able to test create invoice and payments, but I like how we add the invoice at send payment and it shows the information. Very clean and descriptive.
This requires the dcrlnd pr decred#41
There was a problem hiding this comment.
Thanks for fixing my comments. I have a few more nits, but I believe this PR is fine for an initial commit. I am commenting the issues here so we can have knowledge about them.
-
There are still some uncaught errors on dcrlnd start, for example:
My dcrd has started without--txindex, so starting dcrlnd failed, but the error never happened in the gui (just logged into the terminal logs) -
When first starting I noticed a warning:
-
Now I am able to open channels. I noticed the confirmations are not updating automatic, but the channel state is updating from pending --> open.
-
When trying to send an invoice payment without path, nothing happened. Just keeps loading and then stops. I believe it silently fails. Also after this, if we try to pay a new invoice, nothing happens as well.
If paying invoice with path it works fine.
I believe we can have some of these issues fixed in a new PR as this one is really long already. We can do what you think the best approach.
This is the first version of an embedded LN wallet UI on decrediton.
Current features:
Due to current limitations of dcrlnd, this can only be used on wallets that
have been previously unlocked.
It also requires the user to open a regular wallet before connecting to a ln
wallet, which is something we might wanna change in the future.
For the moment, in order to enable support to LN, users need to manually edit
the global decrediton config file to set
"ln_enabled: true".It's likely that this can only be merged after updating the grpc and electron versions (which will come on a separate PR)