Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ln] Initial Version #2107

Open
wants to merge 1 commit into
base: master
from

Conversation

@matheusd
Copy link
Member

commented May 6, 2019

This is the first version of an embedded LN wallet UI on decrediton.

Current features:

  • Connect to initialized and unlocked ln wallets
  • Fund/Withdraw funds from onchain ln wallet
  • Open/Close channels
  • Create invoices
  • Send payments

Due to current limitations of dcrlnd, this can only be used on wallets that
have been previously unlocked.

It also requires the user to open a regular wallet before connecting to a ln
wallet, which is something we might wanna change in the future.

For the moment, in order to enable support to LN, users need to manually edit
the global decrediton config file to set "ln_enabled: true".

It's likely that this can only be merged after updating the grpc and electron versions (which will come on a separate PR)

@matheusd matheusd force-pushed the matheusd:ln branch from 2b7b005 to 72aa424 May 6, 2019

@vctt94
Copy link
Member

left a comment

Good job on this PR!

Tested the basic functionalities and everything seems to be working.

  • connecting to ln unlocked wallet
  • fund / withdraw from wallet to LN
  • open/ close channel
  • creating invoice (noticed an error )
    image
  • send payments

Only the invoice creation which I noticed this error. Not sure what this might be.

I also left some comments on the code, but nothing really important

Good job!

app/components/SideBar/MenuLinks/index.js Outdated Show resolved Hide resolved
app/actions/LNActions.js Outdated Show resolved Hide resolved
app/components/views/LNPage/index.js Outdated Show resolved Hide resolved
app/reducers/ln.js Show resolved Hide resolved
@matheusd

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

Fixed review issues. Also, I added the node's info to the ln wallet tab to make it easier to open channels from faucets.

@vctt94

vctt94 approved these changes May 14, 2019

@noahpierau noahpierau referenced this pull request May 23, 2019
0 of 4 tasks complete
@vctt94

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

needs rebase

[ln] Initial Version
This is the first version of an embedded LN wallet UI on decrediton.

Current features:
  - Connect to initialized and unlocked ln wallets
  - Fund/Withdraw funds from onchain ln wallet
  - Open/Close channels
  - Create invoices
  - Send payments

Due to current limitations of dcrlnd, this can only be used on wallets that
have been previously unlocked.

It also requires the user to open a regular wallet before connecting to a ln
wallet, which is something we might wanna change in the future.

For the moment, in order to enable support to LN, users need to manually edit
the global decrediton config file to set `"ln_enabled: true"`.

@matheusd matheusd force-pushed the matheusd:ln branch from 43eff37 to 2d45e89 Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.