Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn upgrade packages with security vulnerabilities #2156

Merged
merged 2 commits into from
Jul 23, 2019
Merged

yarn upgrade packages with security vulnerabilities #2156

merged 2 commits into from
Jul 23, 2019

Conversation

dajohi
Copy link
Member

@dajohi dajohi commented Jul 16, 2019 •
edited
Loading

Before:
15931 vulnerabilities found - Packages audited: 873185
Severity: 1 Low | 1 Moderate | 15929 High

After:
1 vulnerabilities found - Packages audited: 886178
Severity: 1 Low

vctt94
vctt94 requested changes Jul 17, 2019
View reviewed changes
Copy link
Member

@vctt94 vctt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did not push the package.json diff. Only the ones at yarn.lock

vctt94
vctt94 reviewed Jul 19, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
vctt94
vctt94 approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@vctt94 vctt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexlyp alexlyp merged commit 87807be into decred:master Jul 23, 2019
@dajohi dajohi deleted the gg branch June 21, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheusd matheusd matheusd approved these changes

@alexlyp alexlyp alexlyp approved these changes

@vctt94 vctt94 vctt94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dajohi @matheusd @alexlyp @vctt94