Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rig to remove public password on wallet creation for now #219

Merged
merged 1 commit into from
Feb 3, 2017

Conversation

alexlyp
Copy link
Member

@alexlyp alexlyp commented Feb 3, 2017

Due to user confusion, we'll just be removing the public passphrase on wallet creation which has dcrwallet use the default 'public' passphrase instead. Now on wallet open it will attempt to use that public passphrase first and if that fails it will ask the user for a proper password

Copy link
Contributor

@jolan jolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I guess this is the best approach for now. IIRC, the public password doesn't actually encrypt everything it should anyway.

Tested/OK.

@alexlyp alexlyp merged commit a0e0aed into decred:master Feb 3, 2017
@alexlyp alexlyp deleted the ayp_remove_pubpass branch February 3, 2017 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants