[trezor] Send sequence for prevtx inputs #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sequence field for inputs of prevtxs was not being sent to the device, causing a failure to verify that the hash of the previous transaction and its contents matched. This error could be triggered if the trezor wallet received funds from a non-dcrwallet sender that did not set the Sequence field of the authored transaction to MaxTxInSequenceNum.
alexlyp
approved these changes
Dec 9, 2019
alexlyp
pushed a commit
that referenced
this pull request
Dec 9, 2019
The sequence field for inputs of prevtxs was not being sent to the device, causing a failure to verify that the hash of the previous transaction and its contents matched. This error could be triggered if the trezor wallet received funds from a non-dcrwallet sender that did not set the Sequence field of the authored transaction to MaxTxInSequenceNum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sequence field for inputs of prevtxs was not being sent to the device,
causing a failure to verify that the hash of the previous transaction and its
contents matched.
This error could be triggered if the trezor wallet received funds from a
non-dcrwallet sender that did not set the Sequence field of the authored
transaction to MaxTxInSequenceNum.