Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow runtime translation of Electron menus #3134

Conversation

guilhermemntt
Copy link
Contributor

This PR allows runtime translation of Electron menus - top menu bar and context menu - when setting a different locale on the Settings page.

image

Closes #3132.

Copy link
Member

@vctt94 vctt94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs rebase

@guilhermemntt guilhermemntt force-pushed the guilhermemntt-allow-runtime-translation-of-menus branch from 5148e6f to 163f18f Compare January 19, 2021 14:35
@guilhermemntt
Copy link
Contributor Author

Rebased.

Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@alexlyp alexlyp merged commit f6ed252 into decred:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language change in settings doesn't affect menu bar
4 participants