[dex] Allow selection of Dex account #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
reviewed
Apr 28, 2021
matheusd
approved these changes
Apr 28, 2021
|
Overall works well! After discussing with @matheusd on matrix, due to the possibility of buys going back into the mixed account we need to exclude the mixed account from being in the dropdown for the dex account selection. dcrdex will support privacy at some point and then we'll probably just have the dex accounts to be set to mixed (for selling) and unmixed (for buying). |
|
@alexlyp updated |
alexlyp
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff allows users to select an existing account to become the dex account besides creating a new account.
Closes #3419