libdexc: update for dex 0.3 #3549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
commented
Sep 1, 2021
go.mod
Outdated
| @@ -3,7 +3,7 @@ module github.com/decred/decrediton | |||
| go 1.16 | |||
|
|
|||
| require ( | |||
| decred.org/dcrdex v0.2.0 | |||
| decred.org/dcrdex v0.0.0-20210831153144-015961e12930 | |||
There was a problem hiding this comment.
Will be v0.3.0 pretty soon.
This updates for the changes in the dcrdex/client APIs. This also prepares the CoreAdapter for a language to be specified on construction of Core and WebServer. The init method of CoreAdapter is modified for the new InitializeClient syntax, which includes a seed []byte input argument for restoring. This can be nil to generate fresh account keys. Given new "restore from seed?" dialogs, DEX accounts may be restored from seed. A new method, (*CoreAdapter).discoverAcct, is created for use when and if the init call is updated with an optional restoration seed. This would be used to improve UX when discovering existing paid DEX accounts as described in the docs for discoverAcct. app: set DEX locale
|
The ubuntu-latest virtual environment used by github actions appears to use the Go 1.15 toolset by default, which won't compile the libdexc module. https://github.com/actions/virtual-environments/blob/b9c994fd6caaeb84739c882ed50b7c6288030de2/images/linux/toolsets/toolset-2004.json#L51 I added a commit to configure Go 1.16 so it can build. |
alexlyp
approved these changes
Oct 13, 2021
|
tested and working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates for the changes in the dcrdex/client APIs from 0.2 to 0.3.
This also prepares the
CoreAdapterfor a language to be specified on construction ofCoreandWebServer.Firstly, note that "localized_html" folder is used instead of the "templates" folder from 0.2. These are not in the PR, but if testing do grab the localized_html folders and put them in the "site" directory.
The
initmethod ofCoreAdapteris modified for the newInitializeClientsyntax, which includes aseed []byteinput argument for restoring. This can benilto generate fresh account keys (what previously happened). Given new "restore from seed?" dialogs, DEX accounts may be restored from seed.A new method,
(*CoreAdapter).discoverAcct, is created for use when and if theinitcall is updated with an optional restoration seed. This would be used to improve UX when discovering existing paid DEX accounts as described in the docs fordiscoverAcct.