Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redesign][ln] Overview tab #3551

Merged
merged 7 commits into from Oct 4, 2021
Merged

Conversation

bgptr
Copy link
Collaborator

@bgptr bgptr commented Sep 8, 2021

Toward issue #3296
Requires #3543

Also, in this diff, as @MariaPleshkova suggested, the Wallet, Network, and Watchtowers tabs are grouped under a newly introduced Advanced tab.

Updated screenshot:

2021-09-16_12-47

2021-09-16_12-45

@bgptr bgptr marked this pull request as ready for review September 16, 2021 12:10
Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job on getting the transactions list to the overview page!

I feel the notation is slightly awkward, since (hopefully) no funds are lost on a channel creation so I'm not sure using a negative amount is correct there, but we can iterate on this stuff.

@alexlyp alexlyp merged commit eadd291 into decred:master Oct 4, 2021
@bgptr bgptr deleted the ln-redesign-overview branch January 17, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants