Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[redesign][ln] Channels tab #3543

Merged
merged 13 commits into from
Sep 20, 2021
Merged

[redesign][ln] Channels tab #3543

merged 13 commits into from
Sep 20, 2021

Conversation

bgptr
Copy link
Collaborator

@bgptr bgptr commented Aug 27, 2021 •
edited
Loading

Toward issue #3296

I used the StatusBar pi-ui component and needed a new type of layout, which has been implemented in decred/pi-ui#354
Until it will be merged, I edited the package.json.

Notes:

  • as @matheusd suggested, the "suggested nodes" are left out because figuring out good nodes is a hard problem and points beyond this PR.
  • until the first channel has been created the search button is hidden because there is no way to discover the network.

Updated screenshots:

DeepinScreenshot_select-area_20210906200639

DeepinScreenshot_select-area_20210906200838

DeepinScreenshot_select-area_20210902162507

DeepinScreenshot_select-area_20210906200415

DeepinScreenshot_select-area_20210906200428

DeepinScreenshot_select-area_20210906201122

DeepinScreenshot_select-area_20210906201609

@bgptr bgptr mentioned this pull request Sep 2, 2021
Merged
@bgptr bgptr marked this pull request as ready for review September 2, 2021 14:50
@bgptr bgptr marked this pull request as draft September 3, 2021 20:11
@bgptr
update node search modal style as @MariaPleshkova suggested
3e4136d 
+ Recent Nodes and Search results stretched to the full content width of the modal
+ in case of searching, the recent Nodes section will change to Search Results
+ anchor search modal to the top of the window instead of aligning it center
@bgptr bgptr marked this pull request as ready for review September 6, 2021 18:29
@bgptr bgptr mentioned this pull request Sep 8, 2021
Merged
matheusd
matheusd reviewed Sep 17, 2021
View reviewed changes
Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only found a small validation issue. Otherwise, UI is looking very nice

app/components/views/LNPage/ChannelsTab/hooks.js Outdated Show resolved Hide resolved
matheusd
matheusd approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as intended now

@alexlyp alexlyp merged commit 7a4a6d6 into decred:master Sep 20, 2021
@bgptr bgptr mentioned this pull request Sep 30, 2021
Merged
@bgptr bgptr deleted the ln-redesign-channels branch January 17, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheusd matheusd matheusd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgptr @matheusd @alexlyp