Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication Pages layout #15

Closed
fernandoabolafio opened this issue May 8, 2019 · 2 comments
Closed

Authentication Pages layout #15

fernandoabolafio opened this issue May 8, 2019 · 2 comments
Labels
component-request Request for the implementation of a new component type: layout Refers to a layout component

Comments

@fernandoabolafio
Copy link
Member

We're missing the layout for authentication context pages such as Login, Signup and Reset Password.

@fernandoabolafio
Copy link
Member Author

fernandoabolafio commented May 8, 2019

I think we can accomplish that with a minor modification of the main component. By doing the composition:

<Container>
      <Header />
      <Main>
        <Card  paddingSize={1}>
          {children}
        </Card>
      </Main>
    </Container>

We have pretty much what is necessary for the authentication layouts. Just the Main component needs a bit of work as it will need to start in col 4and end in col 8 for bigger screens if I am not mistaken.

Maybe passing a boolean Centralize to main or creating another layout wrapper with those properties?

@fernandoabolafio fernandoabolafio added component-request Request for the implementation of a new component type: layout Refers to a layout component labels May 8, 2019
@fernandoabolafio
Copy link
Member Author

It can be easily worked around in the main repository. You can close if you want @tiagoalvesdulce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-request Request for the implementation of a new component type: layout Refers to a layout component
Projects
None yet
Development

No branches or pull requests

2 participants