Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pictl: Return timestamps of all comments when no IDs provided. #1616

Closed
amass01 opened this issue Jan 11, 2022 · 0 comments · Fixed by #1617
Closed

pictl: Return timestamps of all comments when no IDs provided. #1616

amass01 opened this issue Jan 11, 2022 · 0 comments · Fixed by #1617
Assignees
@amass01
Labels
bug A bug that made it into a production enviroment.

Comments

@amass01
Copy link
Member

amass01 commented Jan 11, 2022

While working on #1538 found a bug in pictl commenttimestamps command.

The help message says:

If comment IDs are not provided then the timestamps for all comments will be
returned.

This currently does not work and if no comment IDs are passed the command returns an empty
response. This is not the expected behavior, it should fetch all comment IDs and then fetch the
timestamps page by page.

This is a prerequisite for #1538.
@lukebp lukebp added 91cfcc8 bug A bug that made it into a production enviroment. labels Jan 12, 2022
@amass01 amass01 mentioned this issue Jan 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amass01 amass01

Labels
bug A bug that made it into a production enviroment.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pictl: commenttimestamps improvements. amass01/politeia
2 participants
@lukebp @amass01