Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal diff bugs. #2583

Closed
victorgcramos opened this issue Sep 14, 2021 · 3 comments · Fixed by #2639
Closed

Proposal diff bugs. #2583

victorgcramos opened this issue Sep 14, 2021 · 3 comments · Fixed by #2639
Assignees
@vibros68
Labels
bug A bug that made it into a production environment.
Milestone
v1.3.0

Comments

@victorgcramos
Copy link
Member

While navigating on proposals app, I noticed that diff is not working for censored proposals and unvetted proposals when user is not the author or admin. Also, noticed that the Diff modal is triggering duplicate requests and looks weird for mobile screens. See below:

  1. Censored proposals diff bug:
    diff-censored-bug

  2. Unvetted proposals for users that aren't admins or authors:
    diff-unvetted-bug

  3. Duplicate details request on diff modal:
    diff-duplicate-requests

  4. Edited timestamps being overlayed for mobile screens (using an iPhone X screen resolution):
    Screen Shot 2021-09-14 at 1 55 39 PM
@lukebp lukebp added 91cfcc8 bug A bug that made it into a production environment. labels Sep 14, 2021
@lukebp
Copy link
Member

lukebp commented Sep 14, 2021

@victorgcramos what PR introduded this bug.

@victorgcramos
Copy link
Member Author

The first two were introduced by #1988, and the last 2 by #2524.

@lukebp lukebp added this to the v1.3.0 milestone Oct 1, 2021
@vibros68
Copy link
Contributor

I am on it

@vibros68 vibros68 mentioned this issue Oct 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vibros68 vibros68

Labels
bug A bug that made it into a production environment.
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

fix: Proposal diff bugs vibros68/politeiagui
3 participants
@lukebp @victorgcramos @vibros68