minor fixes for proposal diff and error handlers #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorgcramos
force-pushed
the
minor-fixes-rfp
branch
from
852feb8
to
e6756a8
Compare
victorgcramos
force-pushed
the
minor-fixes-rfp
branch
from
e6756a8
to
1b0719a
Compare
tiagoalvesdulce
requested changes
Jun 9, 2020
There was a problem hiding this comment.
@victorgcramos title diff is working fine but the scroll isn't. See:
|
Weird though... Pi-ui package is up to date with the latest pi-ui commit. Could you please check it again to see if you still get this? Looks like pi-ui's changes are not up, because tab's content seems to have no className. |
|
Yep, I had an old |
tiagoalvesdulce
approved these changes
Jun 10, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a couple of minor fixes reported by #1970 and #1982
Closes #1970
Closes #1982
Solution description
This diff adds a new
<DiffText>component, which can be used to track simple diffs from texts, highlighting changes according to thediffWordsWithSpacealgorithm.Also, this adds missing error codes.
Use Cases
DiffTextcomponent can be used whenever you want to get a diff between 2 texts.Code:
Result:
Dependencies
This depends on decred/pi-ui#274
UI Changes Screenshot