fix: Proposal diff bugs #2639
Merged
fix: Proposal diff bugs #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukebp ready for review |
lukebp
approved these changes
Oct 20, 2021
|
Needs code approval from @tiagoalvesdulce. |
victorgcramos
approved these changes
Oct 21, 2021
Comment on lines
+54
to
+87
| const [state, send] = useFetchMachine({ | ||
| actions: { | ||
| initial: () => { | ||
| if (versionsQueue.length) { | ||
| return send(START); | ||
| } | ||
| return send(RESOLVE); | ||
| }, | ||
| start: () => { | ||
| if (!versionsQueue.length) { | ||
| return send(RESOLVE); | ||
| } | ||
| const version = versionsQueue[0]; | ||
| if (version <= 0) { | ||
| setVersionsQueue(drop(versionsQueue)); | ||
| return send(START); | ||
| } | ||
| onFetchProposalDetailsWithoutState(token, version) | ||
| .then((proposal) => { | ||
| setFetchedProposals({ | ||
| ...fetchedProposals, | ||
| [version]: proposal | ||
| }); | ||
| setVersionsQueue(drop(versionsQueue)); | ||
| if (setVersionsQueue.length) { | ||
| return send(START); | ||
| } | ||
| return send(RESOLVE); | ||
| }) | ||
| .catch((e) => send(REJECT, e)); | ||
|
|
||
| return send(FETCH); | ||
| }, | ||
| done: () => {} |
There was a problem hiding this comment.
AWESOME! Good job here, mate!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2583
This diff fixes some bugs on proposal diff version.
the server.
the proposal is unvetted and the user is not admin or author.