Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cms] feat: switch proposal token to proposal name on invoice lineitem #2041

Merged
merged 2 commits into from
Jul 23, 2020
Merged

[cms] feat: switch proposal token to proposal name on invoice lineitem #2041

merged 2 commits into from
Jul 23, 2020

Commits on Jul 8, 2020

  1. [cms] feat: change proposaltoken to proposalname on invoice lineitem 

    This diff now allows users to select proposals by its name, instead of
its token.

Since getting proposals names require a batching request, and those
requests are bounded by 20 proposals for each request, those requests
have to be done more than once in case the token from the
invoice (details and diff), or
the proposal (new and edit actions) are not on the dropdown list.
    @victorgcramos
    victorgcramos committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    a689f16 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. improve useApprovedProposals hook readability. 

    - add onFetchRemainingProposalsBatch method to fetch remaining
  tokens and lazy load proposal list
    @victorgcramos
    victorgcramos committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    a253fc4 View commit details
    Browse the repository at this point in the history