[cms] feat: switch proposal token to proposal name on invoice lineitem #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorgcramos
changed the title
victorgcramos
changed the title
amass01
approved these changes
Jul 6, 2020
thi4go
approved these changes
Jul 7, 2020
There was a problem hiding this comment.
Hey mate good job!
Was getting a CSRF token issue, but then switched to decred/politeia#1242 and it is working fine now. 👍
|
after moving the batch proposals csrf issue fix to decred/politeia#1242, we now depend on it instead of decred/politeia#1224 |
|
Waiting on decred/politeia#1242 |
tiagoalvesdulce
requested changes
Jul 8, 2020
This diff now allows users to select proposals by its name, instead of its token. Since getting proposals names require a batching request, and those requests are bounded by 20 proposals for each request, those requests have to be done more than once in case the token from the invoice (details and diff), or the proposal (new and edit actions) are not on the dropdown list.
victorgcramos
force-pushed
the
2016-cms-proposal-list-invoice
branch
from
746c501
to
a689f16
Compare
tiagoalvesdulce
approved these changes
Jul 8, 2020
- add onFetchRemainingProposalsBatch method to fetch remaining tokens and lazy load proposal list
tiagoalvesdulce
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff Closes #2016 and changes the lineitem selector for proposal token to proposal name.
Solution description
Creates a
useApprovedProposalshook to manage approved proposals when needed. Now, invoices send abatch proposalsrequest to fetch proposals according to the lineitem's token.On
InvoiceForm, when selecting the proposal token lineitem, we do atokeninventoryrequest to fetch all proposals tokens, and thenbatchthe approved ones to get the corresponding proposal.Use Cases
Now,
useApprovedProposalshook can be used when fetching approved proposals is needed.Dependencies
Depends on decred/politeia#1242
UI Changes Screenshot
before:
after:
