[CMS] feat: add proposalsowned and proposalbilling #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagoalvesdulce
changed the title
|
Needs a rebase, then should be good to go |
alexlyp
approved these changes
Jul 24, 2020
This diff now allows users to select proposals by its name, instead of its token. Since getting proposals names require a batching request, and those requests are bounded by 20 proposals for each request, those requests have to be done more than once in case the token from the invoice (details and diff), or the proposal (new and edit actions) are not on the dropdown list.
tiagoalvesdulce
force-pushed
the
proposalsOwned
branch
from
0e1b329
to
bcd2286
Compare
thi4go
suggested changes
Jul 29, 2020
There was a problem hiding this comment.
Hey mate, thanks for this PR, looking really nice. Left some minor comments.
Also, do you think we can add a <- go back link on the proposal billing details page? Like we have on other details page. See:
Another thing I noticed is that the line items listed in this page are not getting cached, so it reloads when we leave then go back to it. Pretty minor though, so might be out of scope for this PR.
edit: travis seems to be bitching about some unused imported packages :b
|
Thanks for the review! Both your suggestions should be done in separate PRs. This one is for the Proposals Owned tab. I'll create issues for both. |
amass01
approved these changes
Jul 29, 2020
| invoice && | ||
| invoice.input && | ||
| invoice.input.lineitems && | ||
| flow( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
Proposals Ownedtab if the user owns proposals and proposal billing details.Solution description
Added a new tab and
proposals/billingendpoint.UI Changes Screenshot
Dependencies
Depends on decred/politeia#1242 and #2041
Question
What's the best option to get the proposal title? I'm currently showing the proposal token returned byproposalsowned. Should we hitbatchProposalson the FE or should the BE return an object of the format:{title, token}forproposalsownedinstead of just thetokenstring?