[CMS] Set owned proposals on manage cms user #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff now allows users to select proposals by its name, instead of its token. Since getting proposals names require a batching request, and those requests are bounded by 20 proposals for each request, those requests have to be done more than once in case the token from the invoice (details and diff), or the proposal (new and edit actions) are not on the dropdown list.
- add onFetchRemainingProposalsBatch method to fetch remaining tokens and lazy load proposal list
tiagoalvesdulce
requested changes
Jul 14, 2020
src/containers/User/Detail/ManageContractor/ManageContractor.jsx
Outdated
Show resolved
Hide resolved
…d proposals field; code cleanup
tiagoalvesdulce
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff adds the option to set owned proposals on the manage cms user tab.
Depends on #2041
Closes #2020
Solution description
Add proposals owned field to the manage cms form. Modifies calls to manage cms user endpoint to set the corresponding field correctly.
UI Changes Screenshot