Voting wallet consistency checking #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jholdstock
force-pushed
the
conssss
branch
6 times, most recently
from
830ea82
to
5ec05cb
Compare
jholdstock
changed the title
|
Ran into an issue.
When a ticket is missing from This means that the current code is continuously trying to add tickets which have already voted to the voting wallets. Ticket Info RPC will be added to dcrwallet to accomodate this (decred/dcrwallet#1783) |
jholdstock
force-pushed
the
conssss
branch
2 times, most recently
from
d0f9a2d
to
4710400
Compare
jholdstock
changed the title
jholdstock
force-pushed
the
conssss
branch
2 times, most recently
from
5e8dd07
to
406473e
Compare
jholdstock
force-pushed
the
conssss
branch
3 times, most recently
from
5bb6627
to
65893d8
Compare
jholdstock
force-pushed
the
conssss
branch
2 times, most recently
from
b6eb566
to
4881189
Compare
|
Ready to go, just waiting for the wallet PR to be merged |
jholdstock
force-pushed
the
conssss
branch
2 times, most recently
from
95a08e9
to
61bbd24
Compare
dajohi
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of the
ticketinfoRPC added to dcrwallet to:Consistency checking
Consistency checks are run immediately on vspd startup and then once every 30 minutes (Closes #46). Consistency checking is a two step process:
ticketinfoon each voting wallet to ensure all of the wallets are aware of all of the ticketsSet ticket outcome
Using
ticketinfoallows vspd to determine when a ticket is no longer votable, either because it has already voted or because it has been revoked. This information is now stored in the vspd database. TheticketinfoRPC does not distinguish between missed and expired tickets, and so vspd simply buckets both of these intorevoked.This occurs each time a block is connected by the local dcrd instance, which provides a regular check on the status of dcrwallet RPC connections (Closes #103).
Counts of
Voting/Voted/Revokedtickets are now reported on both the web front-end and through the/vspinfoAPI call. This replaces the previous counts ofTotal ticketsandFee confirmed tickets. Tickets with unconfirmed fees are no longer reported.