IE tests

[rvagg]

2 changes:

1. latest pull request screwed up IE support even more by double using the global i so I've simply redefined it locally where it's causing the problem.
2. I finally got my head around it and figured out why the IE<9 tests weren't all passing: the context-node collection wasn't working because if you don't have an ID selector anywhere in your query then you default to document which you can't collect siblings of and you really have to do a brute-force through getElementsByTagName('*').

Now all tests are passing in IE6+ et. al.

[ded]

i believe you bundled this with the last, no?

[rvagg]

Nope, totally different set of issues, I figured a separate pull request was appropriate so you could review in isolation. Here's my compare with your latest master: https://github.com/rvagg/qwery/compare/master...ieieie

[rvagg]

no hurry from me btw, I believe you're on holiday so enjoy yourself!

[rvagg]

Merged latest master so the diff now shows only the 2 lines that have changes to fix IE; currently many selectors with IE throw an error due to the global i and not all tests pass because of the wonky context-node collection. This commit makes everything green and happy.

[mr-le]

qwery is very slow in IE8 compared to other selectors
http://jsperf.com/css-selector-libraries/5

[rvagg]

Qwery wins in my normal browser, FF8b on Linux 64bit, take a bow @ded.

I'm keen to get stuck into the non-native selector routines in Qwery some time and see if I can figure out why Qwery doesn't pass lots of common selector use cases in IE, I might see if I can get my head around the performance while I'm at it. Although, I'm not overly concerned because I'm not sure these kinds of benchmarks really reflect real-world selector-engine usage very well and I don't think it really serves Ender to wind back the clock to the days of the selector-engine wars. If you need raw speed then there's a few obvious alternatives.

[rvagg]

Oh, I see what you mean, in my IE8 VM I get 545 ops/sec for Qwery vs 16,621 ops/sec for Sizzle. That is quite a difference.

[rvagg]

OK, so the difference in speed is that Qwery doesn't use querySelectorAll when it's available if it isn't CSS3 compliant, which the IE8 version isn't. But for such a simple case as "tag.class" or just ".class" there's no reason not to IMO, we're already branching for this case anyway. So I've put in a shortcut for it in my latest commit to my ieieie branch. See diff.

See http://jsperf.com/css-selector-libraries/9 if you want reassurance re speed.

Tests still passing.

[ded]

i love how qwery is still faster than querySelectorAll because when it finds just .class it uses getElementsByClassName instead