-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE tests #49
IE tests #49
Conversation
i believe you bundled this with the last, no? |
Nope, totally different set of issues, I figured a separate pull request was appropriate so you could review in isolation. Here's my compare with your latest master: https://github.com/rvagg/qwery/compare/master...ieieie |
no hurry from me btw, I believe you're on holiday so enjoy yourself! |
Merged latest master so the diff now shows only the 2 lines that have changes to fix IE; currently many selectors with IE throw an error due to the global |
qwery is very slow in IE8 compared to other selectors |
Qwery wins in my normal browser, FF8b on Linux 64bit, take a bow @ded. I'm keen to get stuck into the non-native selector routines in Qwery some time and see if I can figure out why Qwery doesn't pass lots of common selector use cases in IE, I might see if I can get my head around the performance while I'm at it. Although, I'm not overly concerned because I'm not sure these kinds of benchmarks really reflect real-world selector-engine usage very well and I don't think it really serves Ender to wind back the clock to the days of the selector-engine wars. If you need raw speed then there's a few obvious alternatives. |
Oh, I see what you mean, in my IE8 VM I get 545 ops/sec for Qwery vs 16,621 ops/sec for Sizzle. That is quite a difference. |
OK, so the difference in speed is that Qwery doesn't use See http://jsperf.com/css-selector-libraries/9 if you want reassurance re speed. Tests still passing. |
i love how qwery is still faster than |
2 changes:
i
so I've simply redefined it locally where it's causing the problem.document
which you can't collect siblings of and you really have to do a brute-force throughgetElementsByTagName('*')
.Now all tests are passing in IE6+ et. al.