Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: global cachebuster option #66

Closed
boye opened this issue May 14, 2014 · 1 comment
Closed

Feature: global cachebuster option #66

boye opened this issue May 14, 2014 · 1 comment

Comments

@boye
Copy link
Contributor

boye commented May 14, 2014

I am thinking about moving from require.js to $script as default script loader. Though, an option that I am currently missing is a way to easily 'cachebust' all scripts that are loaded by $script. Perhaps the following would be an option:

// In our staging and live env `app.cachebuster` holds the current rev number
// and acts as global cachebuster. So it would be nice to do something like:
$script.urlArgs('bust=' + app.cachebuster);

Is this something that's on the roadmap already?

Update: I took the liberty to add it myself :)

@boye boye changed the title global cachebuster option Feature: global cachebuster option May 14, 2014
boye added a commit to e-sites/script.js that referenced this issue May 14, 2014
urlArgs makes it possible to concat a querystring to all scripts, e.g. for cache busting purposes.
boye added a commit to e-sites/script.js that referenced this issue May 14, 2014
ded added a commit that referenced this issue Jun 26, 2014
Added public urlArgs method (as suggested in #66)
@boye
Copy link
Contributor Author

boye commented Jul 1, 2014

this issue is solved with #67 and can be closed :)

@boye boye closed this as completed Aug 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant