Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added public urlArgs method (as suggested in #66) #67

Merged
merged 3 commits into from
Jun 26, 2014
Merged

Conversation

boye
Copy link
Contributor

@boye boye commented May 14, 2014

urlArgs makes it possible to concat a querystring to all scripts, e.g. for cache busting purposes.

boye added 3 commits May 14, 2014 10:47
urlArgs makes it possible to concat a querystring to all scripts, e.g. for cache busting purposes.
I noticed that the in the last unit-test (double load), the .js extension got added twice. This patches fixes it.
@ded
Copy link
Owner

ded commented May 16, 2014

@boye cool!. let me review it and i'll send some thoughts shortly

@houston88
Copy link

Hey this is great! Beats having to come up with a complicated grunt build to hash our file names.

@ded
Copy link
Owner

ded commented Jun 17, 2014

ah! cool. with a PR and everything. i'll have a look

@houston88
Copy link

Wanted to mention I get the following error sometimes on my main index.html when I run with the urlArgs changes in the pull request... I could be doing something wrong. The url args are getting appended to the request for the main page for some reason. The page still loads fine.

Resource interpreted as Script but transferred with MIME type text/html: "https://local.blah.comp.com:8443/login/?v=1403280636567". script.js:84
create script.js:84
loading script.js:67
(anonymous function) script.js:32
every script.js:27
each script.js:31
(anonymous function) script.js:55

Uncaught SyntaxError: Unexpected token < local.blah.comp.com/:1

@boye
Copy link
Contributor Author

boye commented Jun 25, 2014

I am using the urlArgs functionality in a production environment for several weeks now...without any problems :)

@houston88
Copy link

I think it has something to do with angular, happens after angular lib is loaded. In any case, adding the following to the path conditional fixed for me. if (path === null || path === '') return callback()

Anyone see any gotchas with that change?

@ded
Copy link
Owner

ded commented Jun 26, 2014

that would be a solid change. it's always another lib do something weird messing it up for others

@houston88
Copy link

Doh my bad, turned out to be something we were doing. No worries with the
existing code.

Thanks, -Houston
On Jun 25, 2014 7:15 PM, "Dustin Diaz" notifications@github.com wrote:

that would be a solid change. it's always another lib do something weird
messing it up for others


Reply to this email directly or view it on GitHub
#67 (comment).

@boye
Copy link
Contributor Author

boye commented Jun 26, 2014

@houston88 good to know, thanks for testing it! Now it's up to @ded to merge the pull request ;)

ded added a commit that referenced this pull request Jun 26, 2014
Added public urlArgs method (as suggested in #66)
@ded ded merged commit 5795aba into ded:master Jun 26, 2014
This was referenced Jul 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants