-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added public urlArgs method (as suggested in #66) #67
Conversation
urlArgs makes it possible to concat a querystring to all scripts, e.g. for cache busting purposes.
I noticed that the in the last unit-test (double load), the .js extension got added twice. This patches fixes it.
@boye cool!. let me review it and i'll send some thoughts shortly |
Hey this is great! Beats having to come up with a complicated grunt build to hash our file names. |
ah! cool. with a PR and everything. i'll have a look |
Wanted to mention I get the following error sometimes on my main index.html when I run with the urlArgs changes in the pull request... I could be doing something wrong. The url args are getting appended to the request for the main page for some reason. The page still loads fine. Resource interpreted as Script but transferred with MIME type text/html: "https://local.blah.comp.com:8443/login/?v=1403280636567". script.js:84 Uncaught SyntaxError: Unexpected token < local.blah.comp.com/:1 |
I am using the urlArgs functionality in a production environment for several weeks now...without any problems :) |
I think it has something to do with angular, happens after angular lib is loaded. In any case, adding the following to the path conditional fixed for me. if (path === null || path === '') return callback() Anyone see any gotchas with that change? |
that would be a solid change. it's always another lib do something weird messing it up for others |
Doh my bad, turned out to be something we were doing. No worries with the Thanks, -Houston
|
@houston88 good to know, thanks for testing it! Now it's up to @ded to merge the pull request ;) |
Added public urlArgs method (as suggested in #66)
urlArgs makes it possible to concat a querystring to all scripts, e.g. for cache busting purposes.