Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THREAT - Denial of Service, Dkg public key will always return false if an adversary compromise one device. #217

Open
chenchanglew opened this issue Nov 23, 2022 · 0 comments
Assignees
Labels
dkg security issue A bad thing...

Comments

@chenchanglew
Copy link
Contributor

chenchanglew commented Nov 23, 2022

Scenario

During the node initialization phase, the master node will run dkg init and collect all the dkgPubKeys to make sure all the keys are the same or the process will fail. However, a malicious node can just always return a false key then will always let the dkg initialization process fail. And right now there is not a monitor system or log to determine which node has the different output thus we are not able to track malicious users.

Source

“services/dkg/pedersen/mod.go” function setup()
The code here will check that all the dkgPubKeys returned from the nodes are the same, and will output false if any of those fails.

Breaking Property

Availability

Risk

CVSS Score: 4.4/10

Mitigation

The DKG server will proceed to the next phase once it receives more than ⅔ of the correct dkg pubkey.
The DKG server will also report the nodes that return fake keys and raise an alarm to notify there exist some malicious node.

Target

All unit test should have pass.
Add one unit test to test if dkg receives the false dkg public key

@chenchanglew chenchanglew self-assigned this Nov 23, 2022
@chenchanglew chenchanglew changed the title Threat - Denial of Service, Dkg public key will always return false if an adversary compromise one device. THREAT - Denial of Service, Dkg public key will always return false if an adversary compromise one device. Dec 21, 2022
@chenchanglew chenchanglew added security issue A bad thing... and removed THREAT labels Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dkg security issue A bad thing...
Projects
None yet
Development

No branches or pull requests

1 participant