QSC initial implementation #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nkcr I had to change the address iterator thing as we need the length of the set in the Call functions. Let me know what you think about the Take function. |
Gilthoniel
added
R4M 🚀
nkcr
reviewed
Mar 18, 2020
mino/option.go
Outdated
| } | ||
|
|
||
| // ParseFilters applies the filters and return the result. | ||
| func ParseFilters(filters []Filter) *Filters { |
There was a problem hiding this comment.
Suggested change
| func ParseFilters(filters []Filter) *Filters { | |
| func ApplyFilters(filters []Filter) *Filters { |
mino/option.go
Outdated
| ) | ||
|
|
||
| // Filters is a set of parameters for the Players.Take function. | ||
| type Filters struct { |
There was a problem hiding this comment.
Wondering if we should not call it "Filter" in singular. At the end this structure is providing one description of the elements we keep. We can see it as a single filter that is built with multiple updaters. Then the actual type Filter func(*Filters) could be renamed to "FilterUpdater"
consensus/qsc/broadcast.go
Outdated
|
|
||
| ms, ok := resp.(*MessageSet) | ||
| if !ok { | ||
| return nil, xerrors.Errorf("invalid message type: %T", resp) |
There was a problem hiding this comment.
Suggested change
| return nil, xerrors.Errorf("invalid message type: %T", resp) | |
| return nil, xerrors.Errorf("invalid message type: Got '%T' but "+ | |
| "expected '*MessageSet'", resp) |
Co-Authored-By: Noémien Kocher <nkcr.je@gmail.com>
|
@nkcr comments fixed. |
nkcr
approved these changes
Mar 19, 2020
bbjubjub2494
pushed a commit
to bbjubjub2494/dela
that referenced
this pull request
Aug 3, 2024
QSC initial implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes an initial implementation of the QSC algorithm. It does not support Byzantine behavior.