Rotation in view change #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gilthoniel
force-pushed
the
viewchange_rotation
branch
4 times, most recently
from
6fef1d1
to
0376f0e
Compare
nkcr
reviewed
May 14, 2020
| leader := int(prop.GetIndex()) % authority.Len() | ||
|
|
||
| iter := authority.AddressIterator() | ||
| iter.Seek(leader) |
There was a problem hiding this comment.
finally a way to reset an iterator \o/
cosi/mod.go
Outdated
| @@ -37,6 +37,11 @@ type Actor interface { | |||
| // CollectiveSigning is the interface that provides the primitives to sign a | |||
| // message by members of a network. | |||
| type CollectiveSigning interface { | |||
| // GetSigner returns the individual signer assigned to the instance. One | |||
| // should not used it to verify a collective signature but only for identity | |||
There was a problem hiding this comment.
Suggested change
| // should not used it to verify a collective signature but only for identity | |
| // should not use it to verify a collective signature but only for identity |
crypto/mod.go
Outdated
Comment on lines
48
to
49
| // GetNext returns the next public key only if a call to HasNext returns | ||
| // true. |
There was a problem hiding this comment.
Suggested change
| // GetNext returns the next public key only if a call to HasNext returns | |
| // true. | |
| // GetNext returns the next public key in case HasNext returns true. If not | |
| // no assumption can be done. |
| String() string | ||
| } | ||
|
|
||
| // AddressIterator is an iterator over the list of addresses of a membership. | ||
| type AddressIterator interface { | ||
| Seek(int) |
There was a problem hiding this comment.
There should be the same comments as in the PublicKeyIterator interface.
blockchain/skipchain/ops.go
Outdated
| @@ -138,3 +176,31 @@ func (ops *operations) catchUp(target SkipBlock, addr mino.Address) error { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // waitBlock releases the catch up lock and wait for new blocks to be committed. | |||
| // It will return true if the expected block index exists before the timeout. | |||
There was a problem hiding this comment.
I guess you changed the plan ^^
| func (q *queue) Clear() { | ||
| q.Lock() | ||
| q.locked = false | ||
| q.items = nil |
There was a problem hiding this comment.
isn't it dangerous to set it to nil? I would expect a clear to empty the list, not "invalidate" it.
There was a problem hiding this comment.
nkcr
approved these changes
May 15, 2020
|
Will be able to merge once the tests pass again |
Gilthoniel
force-pushed
the
viewchange_rotation
branch
from
a71f316
to
a310504
Compare
bbjubjub2494
pushed a commit
to bbjubjub2494/dela
that referenced
this pull request
Aug 3, 2024
Rotation in view change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implement a simple view change that rotates the leader every block.