Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceProcessor.RegisterStreamingHandler fails to return error to the client when failing to start. #669

Open
tharvik opened this issue Dec 14, 2020 · 0 comments
Assignees

Comments

@tharvik
Copy link
Contributor

tharvik commented Dec 14, 2020

When a streaming handler returns a non-nil error, it is logged but the client is not informed of the call's failure.

s.RegisterStreamingHandler(func(*struct{}) (chan *struct{}, chan bool, error) { return nil, nil, errors.New("") })

blocks the client until the channel is closed via timeout.

See #668 for a test case triggering it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant