Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On taking the maximum projection on SHE patterns #90

Open
paulnovello opened this issue Apr 22, 2024 · 0 comments
Open

On taking the maximum projection on SHE patterns #90

paulnovello opened this issue Apr 22, 2024 · 0 comments

Comments

@paulnovello
Copy link
Member

paulnovello commented Apr 22, 2024

In the original paper, SHE projects the features on all the patterns and takes the projection on that which corresponds to the predicted class. In our implementation, we simply take the maximum projection (as in mahalanobis) for implementation reasons. It does not seem to affect the results. it should be further checked.

Ref: #87 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant