Skip to content

Commit

Permalink
feat: Rename DetailView.show to DetailView.show_with_item for Godot 3…
Browse files Browse the repository at this point in the history
….5 compatibility

BREAKING CHANGE: This requires renaming the call to DetailView.show to DetailView.show_with_item in all code
  • Loading branch information
dploeger committed Aug 25, 2022
1 parent 4ebe882 commit 7ae2533
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion addons/egoventure/nodes/inventory/detail_view.gd
Expand Up @@ -53,7 +53,7 @@ func _on_panel_gui_input(event: InputEvent):
# ** Parameters **
#
# - item: The inventory item to display
func show(item: InventoryItem):
func show_with_item(item: InventoryItem):
self._item = item
$Panel/VBox/Description.text = item.description
if item.detail_scene == '':
Expand Down
2 changes: 1 addition & 1 deletion addons/egoventure/nodes/inventory/inventory.gd
Expand Up @@ -306,7 +306,7 @@ func _on_Reveal_gui_input(event):
if DetailView.is_visible:
DetailView.hide()
else:
DetailView.show(Inventory.selected_item.item)
DetailView.show_with_item(Inventory.selected_item.item)


# Wether to ignore game pauses
Expand Down
2 changes: 1 addition & 1 deletion addons/egoventure/nodes/inventory/inventory_item_node.gd
Expand Up @@ -46,7 +46,7 @@ func configure(p_item: InventoryItem):

# Show the detail view
func show_detail():
DetailView.show(item)
DetailView.show_with_item(item)


# Show active image on inventory item hover
Expand Down
2 changes: 1 addition & 1 deletion core.gd
Expand Up @@ -22,7 +22,7 @@ func _on_triggered_inventory_item(item1: InventoryItem, item2: InventoryItem):
Inventory.remove_item(preload("res://inventory/file.tres"))
(EgoVenture.state as GameState).screw_comb = 1
Notepad.finished_step(4, 2)
DetailView.show(preload("res://inventory/screwdriver_mod.tres"))
DetailView.show_with_item(preload("res://inventory/screwdriver_mod.tres"))

func _on_new_game():
_initialization()
Expand Down
2 changes: 1 addition & 1 deletion scenes/man/man01.gd
Expand Up @@ -20,4 +20,4 @@ func _ready():


func _on_Hotspot3_pressed() -> void:
DetailView.show(preload("res://inventory/file.tres"))
DetailView.show_with_item(preload("res://inventory/file.tres"))

0 comments on commit 7ae2533

Please sign in to comment.