Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 1adrianb/face-alignment to project #16

Closed
Jack29913 opened this issue Dec 22, 2017 · 10 comments
Closed

Adding 1adrianb/face-alignment to project #16

Jack29913 opened this issue Dec 22, 2017 · 10 comments

Comments

@Jack29913
Copy link
Contributor

As deepfakes suggested on Reddit Face alignment scripts based on 1adrianb/face-alignment works better.
It would be great if its added to project and pipeline. It maybe automatic but as deepfakes points out there might be bad aligned images needed to be deleted so maybe readme can be updated about how to use the script manually.

https://www.reddit.com/r/deepfakes/comments/7lae4c/face_alignment_scripts_based_on/
https://github.com/1adrianb/face-alignment

@Clorr
Copy link
Contributor

Clorr commented Dec 22, 2017

Yes, I have seen that and it looks promising. Do you want to take a look at it ?

There is also a Gist with a sample:
https://gist.github.com/anonymous/5832a6fffb8309ac851a29874c3dbb7b

@Clorr
Copy link
Contributor

Clorr commented Dec 22, 2017

Btw, note that face recognition seems to be better with the face_recognition module integrated here. So the dlib.get_frontal_face_detector() should be replaced where relevant

@Clorr
Copy link
Contributor

Clorr commented Dec 22, 2017

I pushed a first draft on my repo, inside the align folder, it is the GIST code reworked to separate program logic from processing logic.

It is not intended to work, but if you want to work on it, please start from there.

CC @Ganonmaster

@Jack29913
Copy link
Contributor Author

@Clor would love to but I can't nowadays. coming months I will be helping other issues and features though

@Clorr
Copy link
Contributor

Clorr commented Dec 22, 2017

A better merge function is also provided

https://gist.github.com/anonymous/8f468972d6286f403318c94bc6dbe382

@Ganonmaster
Copy link
Contributor

Ganonmaster commented Dec 23, 2017

The face alignment script seems to rely on PyTorch, which is not fully supported on GPU for Windows users at this time. This could be blocking if we want it to be accessible and fast for non-tech users.

@Clorr
Copy link
Contributor

Clorr commented Dec 23, 2017

Yes and it is also heavy as hell....

I'm still investigating because if it used just for faces landmarks, face_recognition does it pretty well also...

@Clorr
Copy link
Contributor

Clorr commented Dec 31, 2017

Closing this issue because the referenced scripted has evolved and should not be integrated as is in the project.

I'll reopen an issue to handle the new script when I'll be more available on the project

@1adrianb
Copy link

1adrianb commented Jan 9, 2018

Hey guys @Clorr @Ganonmaster just accidentally found this :) I have recently addressed some accuracy issues and now the code should be on par (or very close) with the results reported in the paper.

Regarding support on windows, while official support will be added soon, there is already a conda package available that works fine on windows: https://anaconda.org/peterjc123/pytorch

With respect to the speed, the slowest bit is dlib face detector, however, one can replace it with almost any other face detection method.

@Clorr
Copy link
Contributor

Clorr commented Jan 9, 2018

Hi @1adrianb , and welcome around!

Thanks for the info. Meanwhile we switched to face_detection lib since we are just using 2D landmarks and that face_detection was already used for face extraction.

If you think we can take advantage of any part of your work, feel free to suggest or even make a PR, we will take care of it with great pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants