Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topics (Read) supported #164

Closed
jpvajda opened this issue Nov 6, 2023 · 6 comments
Closed

Topics (Read) supported #164

jpvajda opened this issue Nov 6, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@jpvajda
Copy link
Contributor

jpvajda commented Nov 6, 2023

  • new param topics added for topic detection for /read requests.
@jpvajda jpvajda added the enhancement New feature or request label Nov 6, 2023
@jpvajda jpvajda added this to the Python SDK Post-v3 milestone Nov 6, 2023
@UniversalDevGenius
Copy link
Contributor

@jpvajda I would like to work on this issue, can you provide more context regarding it.

@dvonthenen
Copy link
Contributor

@UniversalDevGenius You missed it by about a day... it's already implemented here:
https://github.com/dvonthenen/deepgram-python-sdk/tree/feature-sits-impl

Just need to rename a couple of functions after discussing what they should be called.

@dvonthenen
Copy link
Contributor

it should all be working in that branch including examples

@UniversalDevGenius
Copy link
Contributor

@UniversalDevGenius You missed it by about a day... it's already implemented here: https://github.com/dvonthenen/deepgram-python-sdk/tree/feature-sits-impl

Just need to rename a couple of functions after discussing what they should be called.

@dvonthenen Can you share me some issues that I can contribute just tag them here or assign them to me, I really appreciate if you give me an chance to work on interesting issue to start mine first every open source contribution.

1 similar comment
@UniversalDevGenius
Copy link
Contributor

@UniversalDevGenius You missed it by about a day... it's already implemented here: https://github.com/dvonthenen/deepgram-python-sdk/tree/feature-sits-impl

Just need to rename a couple of functions after discussing what they should be called.

@dvonthenen Can you share me some issues that I can contribute just tag them here or assign them to me, I really appreciate if you give me an chance to work on interesting issue to start mine first every open source contribution.

@dvonthenen
Copy link
Contributor

PR Merged. Will be available on the next release (today or tomorrow-ish).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants