Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit DownsampleFailed when the output size is still too large #4564

Open
mattrunyon opened this issue Sep 27, 2023 · 0 comments
Open

Emit DownsampleFailed when the output size is still too large #4564

mattrunyon opened this issue Sep 27, 2023 · 0 comments
Milestone

Comments

@mattrunyon
Copy link
Contributor

We currently enable optional downsampling over 30k points and mandate it over 200k (for time series line plots). This is to keep the web UI responsive and reduce unnecessary data transmission.

There is an issue when downsampling a table with nulls. Nulls are preserved so that gaps appear in the plot where necessary; however, this can lead to downsampling resulting in over 200k points.

The problem is at a certain table size w/ certain frequency of nulls, the downsample call still returns hundreds of thousands of points. The UI struggles to render these. If you had a table with alternating null and non-null values, downsampling would effectively do nothing, but we would still try to plot it.

It would be nice to have some way of limiting the output size of downsampling from the client and emitting a failure or some other message to the client when it is exceeded. We could check these on the web side, but that still results in a large data transfer to the web which we would then just ignore if plots don't render in a timely manner at that size.

Related #4563 when you reach a certain number of nulls, you also exceed the 100MB payload size limit and just get an infinite spinner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants