Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: initial rough draft of dx docs with templates #487

Merged
merged 9 commits into from
Jun 3, 2024
Merged

Conversation

dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented May 22, 2024

I've roughed out each file, scatter.md is the only one though that is roughly complete

To-do create relevant examples for everything. Which may require additional example data sets.

@dsmmcken dsmmcken changed the title initial draft of dx docs initial rough draft of dx docs with templates May 22, 2024
@dsmmcken dsmmcken changed the title initial rough draft of dx docs with templates docs: initial rough draft of dx docs with templates May 22, 2024
@dsmmcken
Copy link
Contributor Author

@jnumainville I am probably missing some types for rough-in too. I have the images, but not the .md files for all current types.

plugins/plotly-express/docs/README.md Outdated Show resolved Hide resolved
plugins/plotly-express/docs/README.md Outdated Show resolved Hide resolved
plugins/plotly-express/docs/README.md Show resolved Hide resolved
plugins/plotly-express/docs/README.md Outdated Show resolved Hide resolved
plugins/plotly-express/docs/area.md Outdated Show resolved Hide resolved

```python order=scatter_plot_diamonds,scatter_plot_symbol_by,scatter_plot_symbol_map
import deephaven.plot.express as dx
my_table = dx.data.iris() # import the example iris data set
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random thought I happened to have here - I know the datasets are very much tied to the examples we are making, but it could be worth having a separate page that explains a bit more about the data sets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, absolutely.

plugins/plotly-express/docs/timeline.md Outdated Show resolved Hide resolved
title: Timelint Plot
---

Timeline plots in offer a means to visualize time-related data, displaying events, durations, or activities along a time axis. Developers can utilize these plots for applications that require users to understand temporal patterns and relationships, such as project management, event scheduling, and historical data analysis.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth pointing out that this is also known as a Gantt plot

title: Treemap Plot
---

Treemap plots are a data visualization technique used to represent hierarchical data in a space-filling manner. They display data as nested rectangles or squares, where the size and color of each rectangle represent the values or categories within the hierarchy. Developers can create treemaps to provide users with an efficient and visually intuitive way to explore hierarchical data structures and understand relationships between categories and subcategories, making them a valuable tool for various applications that involve hierarchical data presentation, analysis, and exploration.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Treemap, sunbursts, and icicles are more or less identical - worth linking?

title: Violin Plot
---

A violin plot is a data visualization that combines a box plot with a rotated kernel density plot to provide a comprehensive representation of the data distribution. It offers a detailed view of the data's central tendency, spread and density.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, for some of these plot groups where they are so similar (strip vs box vs violin or treemap vs icicle vs sunburst for example) it might be worth having a direct comparison page, maybe with a table or something. Doesn't have to be done now but could be worth it because some of the nuances with these are so subtle.


### Basic Plots

[![Scatter plot](_assets/plot_icons/scatter.svg)](scatter.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably have the name visible underneath as well, so that you can Find it in the doc easily.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I need to lookup how to add a caption using GFM.

plugins/plotly-express/docs/CONTRIBUTING.md Outdated Show resolved Hide resolved

We should have a seperate section covering shared concepts such as:

- Plot by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plotBy / plot_by? or explain what "plot by" means


<!-- Update number if count changes -->

This page contains a collection of links to examples demonstrating 24 different plot types and usage scenarios. You can explore these examples to gain a better understanding of how to leverage the library in your projects.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a specific number?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, and could remove.

plugins/plotly-express/docs/README.md Outdated Show resolved Hide resolved
plugins/plotly-express/docs/area.md Show resolved Hide resolved
plugins/plotly-express/docs/box.md Outdated Show resolved Hide resolved

Candlestick plots are a financial data visualization tool commonly used in technical analysis. Similar to an OHLC, they also represent the open, close, high, and low prices of a financial instrument for a specific time period, providing insights into price movements and patterns, and aiding in the identification of trends and potential reversal points in financial markets.

Interpreting a candlestick chart involves understanding the visual representation of price data within a specific time frame. Each candlestick consists of a rectangular "body" representing the price range between the opening and closing prices, with the "wick" or "shadow" lines extending above and below the body indicating the high and low prices during that time period.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chart or plot? maybe stick to plot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plot would be preferred wording for consistency.

plugins/plotly-express/docs/candlestick.md Outdated Show resolved Hide resolved
margaretkennedy and others added 2 commits May 30, 2024 18:58
Co-authored-by: Joe <josephnumainville@deephaven.io>
Co-authored-by: margaretkennedy <82049573+margaretkennedy@users.noreply.github.com>
@dsmmcken
Copy link
Contributor Author

dsmmcken commented Jun 3, 2024

Joe's suggestions are good and should be address in follow up PRs if we want to merge this now, and let Alex keep grinding.

@alexpeters1208
Copy link
Contributor

Joe's suggestions are good and should be address in follow up PRs if we want to merge this now, and let Alex keep grinding.

Noted. If we could do without resolving these comments so that I can navigate the feedback as I work through, that would be good.

@dsmmcken dsmmcken merged commit 50f6e9a into main Jun 3, 2024
14 checks passed
@dsmmcken dsmmcken deleted the dx-docs branch June 3, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants